Browse Source

Add 'make checkheaders' to developer guidelines and patch checklist.

Originally committed as revision 15741 to svn://svn.ffmpeg.org/ffmpeg/trunk
tags/v0.5
Diego Biurrun 17 years ago
parent
commit
2cdba8bfc4
1 changed files with 5 additions and 0 deletions
  1. +5
    -0
      doc/general.texi

+ 5
- 0
doc/general.texi View File

@@ -951,6 +951,9 @@ should also be avoided if they don't make the code easier to understand.
@item @item
If you add a new file, give it a proper license header. Do not copy and If you add a new file, give it a proper license header. Do not copy and
paste it from a random place, use an existing file as template. paste it from a random place, use an existing file as template.
@item
If you add a new header or change an existing one, make sure it passes
@code{make checkheaders}.
@end enumerate @end enumerate


We think our rules are not too hard. If you have comments, contact us. We think our rules are not too hard. If you have comments, contact us.
@@ -1025,6 +1028,8 @@ do not attach several unrelated patches to the same mail.
@enumerate @enumerate
@item @item
Do the regression tests pass with the patch applied? Do the regression tests pass with the patch applied?
@item
Does @code{make checkheaders} pass with the patch applied?
@item @item
Is the patch a unified diff? Is the patch a unified diff?
@item @item


Loading…
Cancel
Save