Browse Source

avformat/aviobuf: Don't check for overflow after it happened

If adding two ints overflows, it doesn't matter whether the result will
be stored in an unsigned or not; and checking afterwards does not make it
retroactively defined.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
tags/n4.4
Andreas Rheinhardt 5 years ago
parent
commit
28a078eded
1 changed files with 1 additions and 1 deletions
  1. +1
    -1
      libavformat/aviobuf.c

+ 1
- 1
libavformat/aviobuf.c View File

@@ -1287,7 +1287,7 @@ static int dyn_buf_write(void *opaque, uint8_t *buf, int buf_size)
unsigned new_size, new_allocated_size;

/* reallocate buffer if needed */
new_size = d->pos + buf_size;
new_size = (unsigned)d->pos + buf_size;
new_allocated_size = d->allocated_size;
if (new_size < d->pos || new_size > INT_MAX/2)
return -1;


Loading…
Cancel
Save