Browse Source

avformat/takdec: zero padding area before use

Fixes use of uninitialized memory
Fixes: msan_uninit-mem_7fcecee73d71_6470_luckynight-partial.tak
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
tags/n2.2-rc1
Michael Niedermayer 11 years ago
parent
commit
243b9fea90
1 changed files with 1 additions and 0 deletions
  1. +1
    -0
      libavformat/takdec.c

+ 1
- 0
libavformat/takdec.c View File

@@ -85,6 +85,7 @@ static int tak_read_header(AVFormatContext *s)
buffer = av_malloc(size - 3 + FF_INPUT_BUFFER_PADDING_SIZE);
if (!buffer)
return AVERROR(ENOMEM);
memset(buffer + size - 3, 0, FF_INPUT_BUFFER_PADDING_SIZE);

ffio_init_checksum(pb, tak_check_crc, 0xCE04B7U);
if (avio_read(pb, buffer, size - 3) != size - 3) {


Loading…
Cancel
Save