Browse Source

rv10/20: Fix a buffer overread caused by losing track of the remaining buffer size.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
(cherry picked from commit 2f6528537f)

Signed-off-by: Reinhard Tartler <siretart@tauware.de>
tags/n0.10.1
Alex Converse Reinhard Tartler 14 years ago
parent
commit
19da1a39e8
1 changed files with 5 additions and 1 deletions
  1. +5
    -1
      libavcodec/rv10.c

+ 5
- 1
libavcodec/rv10.c View File

@@ -642,8 +642,12 @@ static int rv10_decode_frame(AVCodecContext *avctx,

if(!avctx->slice_count){
slice_count = (*buf++) + 1;
buf_size--;
slices_hdr = buf + 4;
buf += 8 * slice_count;
buf_size -= 8 * slice_count;
if (buf_size <= 0)
return AVERROR_INVALIDDATA;
}else
slice_count = avctx->slice_count;

@@ -682,7 +686,7 @@ static int rv10_decode_frame(AVCodecContext *avctx,
s->current_picture_ptr= NULL; //so we can detect if frame_end wasnt called (find some nicer solution...)
}

return buf_size;
return avpkt->size;
}

AVCodec ff_rv10_decoder = {


Loading…
Cancel
Save