From 100a54da5264436202daeedd68ed5e4a8be41459 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Sun, 29 Dec 2013 22:58:38 +0100 Subject: [PATCH] avcodec/lagarith: disable lag_decode_zero_run_line() and ask for a sample The code seems to have never been tested fixing it should be quite easy but needs a sample/testcase Fixes use of uninitialized memory Fixes: msan_uninit-mem_7f9a862dfabf_413_2889_assassin_OL.avi Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/lagarith.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/lagarith.c b/libavcodec/lagarith.c index 0a4d23e7a2..23934ceed8 100644 --- a/libavcodec/lagarith.c +++ b/libavcodec/lagarith.c @@ -369,6 +369,9 @@ static int lag_decode_zero_run_line(LagarithContext *l, uint8_t *dst, uint8_t mask2 = -(esc_count < 3); uint8_t *end = dst + (width - 2); + avpriv_request_sample(l->avctx, "zero_run_line"); + return AVERROR_PATCHWELCOME; + output_zeros: if (l->zeros_rem) { count = FFMIN(l->zeros_rem, width - i);