Browse Source

avcodec/vqavideo: clear uninitialized parts of the decode buffer

Fixes use of uninitialized memory
Fixes part of msan_uninit-mem_7f841fe2ab3b_4608_cow2_1.vqa
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
tags/n2.2-rc1
Michael Niedermayer 12 years ago
parent
commit
03acb035d1
1 changed files with 3 additions and 1 deletions
  1. +3
    -1
      libavcodec/vqavideo.c

+ 3
- 1
libavcodec/vqavideo.c View File

@@ -303,9 +303,11 @@ static int decode_format80(VqaContext *s, int src_size,
* codebook entry; it is not important for compressed codebooks because
* not every entry needs to be filled */
if (check_size)
if (dest_index < dest_size)
if (dest_index < dest_size) {
av_log(s->avctx, AV_LOG_ERROR, "decode_format80 problem: decode finished with dest_index (%d) < dest_size (%d)\n",
dest_index, dest_size);
memset(dest + dest_index, 0, dest_size - dest_index);
}

return 0; // let's display what we decoded anyway
}


Loading…
Cancel
Save