Browse Source

mov: Save number of stsd elements after stream extradata allocation

Avoid freeing an unallocated array in mov_read_close() in case
of a malloc failure.

Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>
tags/n3.3
Vittorio Giovara 9 years ago
parent
commit
029cf99c51
1 changed files with 4 additions and 3 deletions
  1. +4
    -3
      libavformat/mov.c

+ 4
- 3
libavformat/mov.c View File

@@ -1883,7 +1883,7 @@ static int mov_read_stsd(MOVContext *c, AVIOContext *pb, MOVAtom atom)
{
AVStream *st;
MOVStreamContext *sc;
int ret;
int ret, entries;

if (c->fc->nb_streams < 1)
return 0;
@@ -1892,13 +1892,14 @@ static int mov_read_stsd(MOVContext *c, AVIOContext *pb, MOVAtom atom)

avio_r8(pb); /* version */
avio_rb24(pb); /* flags */
sc->stsd_count = avio_rb32(pb); /* entries */
entries = avio_rb32(pb);

/* Prepare space for hosting multiple extradata. */
sc->extradata = av_mallocz_array(sc->stsd_count, sizeof(*sc->extradata));
sc->extradata = av_mallocz_array(entries, sizeof(*sc->extradata));
if (!sc->extradata)
return AVERROR(ENOMEM);

sc->stsd_count = entries;
sc->extradata_size = av_mallocz_array(sc->stsd_count, sizeof(sc->extradata_size));
if (!sc->extradata_size)
return AVERROR(ENOMEM);


Loading…
Cancel
Save