Browse Source

avcodec/utils: initialize pixel buffer pool

This should silence many valgrind warnings about use of uninitialized
data, all the warnings i looked at where false positives having their
uninitialized data not actually used.

The same effect could be achieved by listing all code that touches
the pixel buffer in the valgrind suppression file.
Note, valgrind also fails to trace the origins correctly.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
tags/n2.0
Michael Niedermayer 12 years ago
parent
commit
01df2a13c3
1 changed files with 4 additions and 1 deletions
  1. +4
    -1
      libavcodec/utils.c

+ 4
- 1
libavcodec/utils.c View File

@@ -408,7 +408,10 @@ static int update_frame_pool(AVCodecContext *avctx, AVFrame *frame)
av_buffer_pool_uninit(&pool->pools[i]); av_buffer_pool_uninit(&pool->pools[i]);
pool->linesize[i] = picture.linesize[i]; pool->linesize[i] = picture.linesize[i];
if (size[i]) { if (size[i]) {
pool->pools[i] = av_buffer_pool_init(size[i] + 16, NULL);
pool->pools[i] = av_buffer_pool_init(size[i] + 16,
CONFIG_MEMORY_POISONING ?
NULL :
av_buffer_allocz);
if (!pool->pools[i]) { if (!pool->pools[i]) {
ret = AVERROR(ENOMEM); ret = AVERROR(ENOMEM);
goto fail; goto fail;


Loading…
Cancel
Save