This avoids a link failure with MMX disabled as now code and initialization are compiled under the same condition.tags/n2.3
| @@ -53,7 +53,6 @@ MMX-OBJS-$(CONFIG_BLOCKDSP) += x86/blockdsp_mmx.o | |||
| MMX-OBJS-$(CONFIG_DSPUTIL) += x86/dsputil_mmx.o | |||
| MMX-OBJS-$(CONFIG_HPELDSP) += x86/fpel_mmx.o \ | |||
| x86/hpeldsp_mmx.o | |||
| MMX-OBJS-$(CONFIG_HUFFYUVDSP) += x86/huffyuvdsp_mmx.o | |||
| MMX-OBJS-$(CONFIG_IDCTDSP) += x86/idctdsp_mmx.o \ | |||
| x86/idct_mmx_xvid.o \ | |||
| x86/idct_sse2_xvid.o \ | |||
| @@ -1,30 +0,0 @@ | |||
| /* | |||
| * This file is part of Libav. | |||
| * | |||
| * Libav is free software; you can redistribute it and/or | |||
| * modify it under the terms of the GNU Lesser General Public | |||
| * License as published by the Free Software Foundation; either | |||
| * version 2.1 of the License, or (at your option) any later version. | |||
| * | |||
| * Libav is distributed in the hope that it will be useful, | |||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | |||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |||
| * Lesser General Public License for more details. | |||
| * | |||
| * You should have received a copy of the GNU Lesser General Public | |||
| * License along with Libav; if not, write to the Free Software | |||
| * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA | |||
| */ | |||
| #ifndef AVCODEC_X86_HUFFYUVDSP_H | |||
| #define AVCODEC_X86_HUFFYUVDSP_H | |||
| #include <stdint.h> | |||
| void ff_add_bytes_mmx(uint8_t *dst, uint8_t *src, int w); | |||
| void ff_add_hfyu_median_pred_cmov(uint8_t *dst, const uint8_t *top, | |||
| const uint8_t *diff, int w, | |||
| int *left, int *left_top); | |||
| #endif /* AVCODEC_X86_HUFFYUVDSP_H */ | |||
| @@ -1,4 +1,6 @@ | |||
| /* | |||
| * Copyright (c) 2009 Loren Merritt <lorenm@u.washington.edu> | |||
| * | |||
| * This file is part of Libav. | |||
| * | |||
| * Libav is free software; you can redistribute it and/or | |||
| @@ -23,11 +25,6 @@ | |||
| #include "libavutil/x86/cpu.h" | |||
| #include "libavcodec/huffyuvdsp.h" | |||
| void ff_add_bytes_mmx(uint8_t *dst, uint8_t *src, int w); | |||
| void ff_add_hfyu_median_pred_cmov(uint8_t *dst, const uint8_t *top, | |||
| const uint8_t *diff, int w, | |||
| int *left, int *left_top); | |||
| void ff_add_hfyu_median_pred_mmxext(uint8_t *dst, const uint8_t *top, | |||
| const uint8_t *diff, int w, | |||
| int *left, int *left_top); | |||
| @@ -37,17 +34,87 @@ int ff_add_hfyu_left_pred_ssse3(uint8_t *dst, const uint8_t *src, | |||
| int ff_add_hfyu_left_pred_sse4(uint8_t *dst, const uint8_t *src, | |||
| int w, int left); | |||
| #if HAVE_INLINE_ASM | |||
| #if HAVE_7REGS | |||
| static void add_hfyu_median_pred_cmov(uint8_t *dst, const uint8_t *top, | |||
| const uint8_t *diff, int w, | |||
| int *left, int *left_top) | |||
| { | |||
| x86_reg w2 = -w; | |||
| x86_reg x; | |||
| int l = *left & 0xff; | |||
| int tl = *left_top & 0xff; | |||
| int t; | |||
| __asm__ volatile ( | |||
| "mov %7, %3 \n" | |||
| "1: \n" | |||
| "movzbl (%3, %4), %2 \n" | |||
| "mov %2, %k3 \n" | |||
| "sub %b1, %b3 \n" | |||
| "add %b0, %b3 \n" | |||
| "mov %2, %1 \n" | |||
| "cmp %0, %2 \n" | |||
| "cmovg %0, %2 \n" | |||
| "cmovg %1, %0 \n" | |||
| "cmp %k3, %0 \n" | |||
| "cmovg %k3, %0 \n" | |||
| "mov %7, %3 \n" | |||
| "cmp %2, %0 \n" | |||
| "cmovl %2, %0 \n" | |||
| "add (%6, %4), %b0 \n" | |||
| "mov %b0, (%5, %4) \n" | |||
| "inc %4 \n" | |||
| "jl 1b \n" | |||
| : "+&q"(l), "+&q"(tl), "=&r"(t), "=&q"(x), "+&r"(w2) | |||
| : "r"(dst + w), "r"(diff + w), "rm"(top + w) | |||
| ); | |||
| *left = l; | |||
| *left_top = tl; | |||
| } | |||
| #endif /* HAVE_7REGS */ | |||
| static void add_bytes_mmx(uint8_t *dst, uint8_t *src, int w) | |||
| { | |||
| x86_reg i = 0; | |||
| __asm__ volatile ( | |||
| "jmp 2f \n\t" | |||
| "1: \n\t" | |||
| "movq (%1, %0), %%mm0 \n\t" | |||
| "movq (%2, %0), %%mm1 \n\t" | |||
| "paddb %%mm0, %%mm1 \n\t" | |||
| "movq %%mm1, (%2, %0) \n\t" | |||
| "movq 8(%1, %0), %%mm0 \n\t" | |||
| "movq 8(%2, %0), %%mm1 \n\t" | |||
| "paddb %%mm0, %%mm1 \n\t" | |||
| "movq %%mm1, 8(%2, %0) \n\t" | |||
| "add $16, %0 \n\t" | |||
| "2: \n\t" | |||
| "cmp %3, %0 \n\t" | |||
| "js 1b \n\t" | |||
| : "+r" (i) | |||
| : "r" (src), "r" (dst), "r" ((x86_reg) w - 15)); | |||
| for (; i < w; i++) | |||
| dst[i + 0] += src[i + 0]; | |||
| } | |||
| #endif /* HAVE_INLINE_ASM */ | |||
| av_cold void ff_huffyuvdsp_init_x86(HuffYUVDSPContext *c) | |||
| { | |||
| int cpu_flags = av_get_cpu_flags(); | |||
| #if HAVE_7REGS && HAVE_INLINE_ASM | |||
| #if HAVE_INLINE_ASM | |||
| #if HAVE_7REGS | |||
| if (cpu_flags & AV_CPU_FLAG_CMOV) | |||
| c->add_hfyu_median_pred = ff_add_hfyu_median_pred_cmov; | |||
| #endif | |||
| c->add_hfyu_median_pred = add_hfyu_median_pred_cmov; | |||
| #endif /* HAVE_7REGS */ | |||
| if (INLINE_MMX(cpu_flags)) | |||
| c->add_bytes = ff_add_bytes_mmx; | |||
| c->add_bytes = add_bytes_mmx; | |||
| #endif /* HAVE_INLINE_ASM */ | |||
| if (EXTERNAL_MMXEXT(cpu_flags)) { | |||
| /* slower than cmov version on AMD */ | |||
| @@ -1,91 +0,0 @@ | |||
| /* | |||
| * Copyright (c) 2009 Loren Merritt <lorenm@u.washington.edu> | |||
| * | |||
| * This file is part of Libav. | |||
| * | |||
| * Libav is free software; you can redistribute it and/or | |||
| * modify it under the terms of the GNU Lesser General Public | |||
| * License as published by the Free Software Foundation; either | |||
| * version 2.1 of the License, or (at your option) any later version. | |||
| * | |||
| * Libav is distributed in the hope that it will be useful, | |||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | |||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |||
| * Lesser General Public License for more details. | |||
| * | |||
| * You should have received a copy of the GNU Lesser General Public | |||
| * License along with Libav; if not, write to the Free Software | |||
| * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA | |||
| */ | |||
| #include "config.h" | |||
| #include "libavutil/x86/asm.h" | |||
| #include "huffyuvdsp.h" | |||
| #if HAVE_INLINE_ASM | |||
| #if HAVE_7REGS | |||
| void ff_add_hfyu_median_pred_cmov(uint8_t *dst, const uint8_t *top, | |||
| const uint8_t *diff, int w, | |||
| int *left, int *left_top) | |||
| { | |||
| x86_reg w2 = -w; | |||
| x86_reg x; | |||
| int l = *left & 0xff; | |||
| int tl = *left_top & 0xff; | |||
| int t; | |||
| __asm__ volatile ( | |||
| "mov %7, %3 \n" | |||
| "1: \n" | |||
| "movzbl (%3, %4), %2 \n" | |||
| "mov %2, %k3 \n" | |||
| "sub %b1, %b3 \n" | |||
| "add %b0, %b3 \n" | |||
| "mov %2, %1 \n" | |||
| "cmp %0, %2 \n" | |||
| "cmovg %0, %2 \n" | |||
| "cmovg %1, %0 \n" | |||
| "cmp %k3, %0 \n" | |||
| "cmovg %k3, %0 \n" | |||
| "mov %7, %3 \n" | |||
| "cmp %2, %0 \n" | |||
| "cmovl %2, %0 \n" | |||
| "add (%6, %4), %b0 \n" | |||
| "mov %b0, (%5, %4) \n" | |||
| "inc %4 \n" | |||
| "jl 1b \n" | |||
| : "+&q"(l), "+&q"(tl), "=&r"(t), "=&q"(x), "+&r"(w2) | |||
| : "r"(dst + w), "r"(diff + w), "rm"(top + w) | |||
| ); | |||
| *left = l; | |||
| *left_top = tl; | |||
| } | |||
| #endif | |||
| void ff_add_bytes_mmx(uint8_t *dst, uint8_t *src, int w) | |||
| { | |||
| x86_reg i = 0; | |||
| __asm__ volatile ( | |||
| "jmp 2f \n\t" | |||
| "1: \n\t" | |||
| "movq (%1, %0), %%mm0 \n\t" | |||
| "movq (%2, %0), %%mm1 \n\t" | |||
| "paddb %%mm0, %%mm1 \n\t" | |||
| "movq %%mm1, (%2, %0) \n\t" | |||
| "movq 8(%1, %0), %%mm0 \n\t" | |||
| "movq 8(%2, %0), %%mm1 \n\t" | |||
| "paddb %%mm0, %%mm1 \n\t" | |||
| "movq %%mm1, 8(%2, %0) \n\t" | |||
| "add $16, %0 \n\t" | |||
| "2: \n\t" | |||
| "cmp %3, %0 \n\t" | |||
| "js 1b \n\t" | |||
| : "+r" (i) | |||
| : "r" (src), "r" (dst), "r" ((x86_reg) w - 15)); | |||
| for (; i < w; i++) | |||
| dst[i + 0] += src[i + 0]; | |||
| } | |||
| #endif /* HAVE_INLINE_ASM */ | |||