falkTX
bac54233ef
Add some safeties around invalid connection-id
Need to investigate this more deeply later on
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
fda792130a
Fix missing ports if client uuid fetch fails
Error case was returning instead of continuing
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
a6aaccc6eb
Final tweaks for internal/external patchbay usage and projects
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
18554a3692
Skip graph CV source reconfigure when loading plugin state
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
88c3255786
Tweaks to loading external patchbay data into internal one
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
d951215570
Only care about client name prefix in multi-client mode
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
3e87f7dff2
Add --cnprefix arg, for client name prefix; Set it also when needed
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
d7d33f7697
Don't rely on jack metadata callback being there for positions
Since we no longer have recursion issues, having this is fine.
This ensures carla keeps working in case JACK is fixed.
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
501b3206b8
Don't print message if client prefix conversion matches original
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
df042eed76
Be smarter about giving idle time during load, making it faster
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
0463d8f1b7
Better error reporting regarding missing clients during load
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
53c8f6965b
Handle client name prefix during jack client rename
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
01c1aed761
Convert from and to client name prefix as needed
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
54141061d0
Load canvas positions before loading connections
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
797278456c
JACK: Be able to load canvas positions regardless of client prefix
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
367ed6e218
Reserve '/' character in plugin names (needed for client prefix)
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
04205a780f
Fix strict build
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
743ed07ac7
Always load patchbay connections when importing a carla project
This ignores SM, as it should for this specific case
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
5ce90bcdad
Fix callback recursion on carla-plugin patchbay group moves
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
e283075a88
Fix bridges build yet yet again
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
5819b37389
Fix bridges build once again
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
ccb52ad79c
Make the previous changes backwards compatible
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
c4c387ed29
Use jack client prefic when renaming clients too
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
3d767f9be8
Allow to set custom prefix for jack clients, use it under NSM
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
d82ae66928
Fix carla-plugin never deleting plugins
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
89566a1a0f
Add API to know current project folder
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
843bb34910
Better handle case of JACK server stop (or killed)
Fixes #1175
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
7f24fb331c
Fix useless assertion when deactivating client for final cleanup
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
c7db817df5
Run plugin idle() ourselves when engine is not running
A non-running engine means no separate thread for events is available,
this breaks plugin-bridges in some scenarios.
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
e4a124d5ec
plugin-bridge: send back empty/null responses when plugin disabled
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
040b0b6636
Fix false positives regarding jack meta-data and internal clients
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
6ab431a469
JACK: prevent recursion on patchbay group position changes
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
6ef541d1da
Fix strict build warnings against clang
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
b02fe8ad80
Ignore one assertion regarding JACK meta-data (false positive)
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
1d2b88052c
Correct and modify a few debug messages
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
43c3a9923a
Fix usage without jack meta-data support
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
3afa203408
Fix JACK internal client build
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
f58fe233c1
Fix OSC handling method check for long strings
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
dbfc6116a9
Fix a couple of issues with carla-plugin
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
22a6006c70
Avoid comparing shared_ptr directly to nullptr
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
90a868aba6
Fix bridge build
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
f73cafcea8
Backwards compatible std::shared_ptr
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
d06159d2c9
Fix build, partially
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
3ab47c9481
Change the way plugins are deleted, ensure they are not being used
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
29c55500a7
Pass DLS/GIG files into fluidsynth if version is recent enough
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
92f7396caa
Protect *all* metadata access, even in bridge mode
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
0f53835c6d
Protect jack metadata usage with a mutex; other position fixes
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
8f27bff6c4
Add new CARLA_CUSTOM_SAFE_ASSERT
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
b95d082d1f
Set correct Carla-VST UI size based on scale factor
Closes #1057
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago
falkTX
e697553406
Fix for dumb compilers
Signed-off-by: falkTX <falktx@falktx.com>
4 years ago