 Sebastian Lohff
|
14e9ec85fa
|
Disable GraphicsScene indexing method to prevent crashes
Under certain circumstances Carla would crash when frequent updates on
the QGraphicsScene occurred, especially in combination with scrolling or
panning by the user. Backtraces showed either a segfault in
QGraphicsItem::parentItem() or around
QGraphicsSceneBspTree::climbTree(). While the first trace points towards
missing calls to pepareGeometryChange() in combination with custom
boundingRect() methods, inserting these did not yield a positive change,
though people with this issue also had success in disabling the
ItemIndexingMethod of their QGraphicsScene[0][1]. Setting this to
NoIndex solves this problem.
The original problem is reproducible with an ever-reconnecting client:
$ while true; do klick 120 & (sleep 0.1; killall klick); done
[0] https://bugreports.qt.io/browse/QTBUG-18021?focusedCommentId=367566&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-367566
[1] https://forum.qt.io/topic/71316/qgraphicsscenefinditembsptreevisitor-visit-crashes-due-to-an-obsolete-paintevent-after-qgraphicsscene-removeitem
|
3 years ago |
 falkTX
|
b730c7a880
|
Do not refresh canvas except on error, fixing on quit crash
Signed-off-by: falkTX <falktx@falktx.com>
|
3 years ago |
|
falkTX
|
336aff24fd
|
Really fix split/join
Signed-off-by: falkTX <falktx@falktx.com>
|
3 years ago |
|
falkTX
|
3e50d8b2bd
|
Fix canvas split/join action
|
4 years ago |
|
falkTX
|
9994ecf44e
|
splitted is not a word
|
4 years ago |
|
falkTX
|
92ba944c10
|
Fix Qt version checks, allow canvas eyecandy for >= qt5.12
|
4 years ago |
|
falkTX
|
35babc07ab
|
patchcanvas: clear rubberband on right-click
Signed-off-by: falkTX <falktx@falktx.com>
|
4 years ago |
|
falkTX
|
b553ff4ebd
|
patchcanvas: stop storing keyboard modifier state, cleanup
Signed-off-by: falkTX <falktx@falktx.com>
|
4 years ago |
|
falkTX
|
eb78e41ed9
|
Allow to use canvas cut operations without prior window focus
Fixes #1176
Signed-off-by: falkTX <falktx@falktx.com>
|
4 years ago |
|
falkTX
|
3f6d9127db
|
canvas: Only "drop" connection drag for mouse release of left button
Fixes #1206
Signed-off-by: falkTX <falktx@falktx.com>
|
4 years ago |
|
falkTX
|
6084697290
|
Fix warnings, print error code if win32 process start fails
Signed-off-by: falkTX <falktx@falktx.com>
|
4 years ago |
|
falkTX
|
e139c4438e
|
patchcanvas: check validity of a few object's parentItems
Signed-off-by: falkTX <falktx@falktx.com>
|
4 years ago |
|
falkTX
|
d3ff7a3400
|
Remove incomplete, unused patchcanvas c++ stuff
Signed-off-by: falkTX <falktx@falktx.com>
|
4 years ago |
|
falkTX
|
d707051665
|
Clear canvas selection when deleting plugin, fixing assertions
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
bac54233ef
|
Add some safeties around invalid connection-id
Need to investigate this more deeply later on
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
4db6bf43c5
|
Prevent visibility change events from messing with canvas pos
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
eb12242976
|
Fix frontend a bit for late messages just before closing
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
f026a7ef27
|
Split/Join groups automatically based on host messages
Fixes #1177
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
9c710e50b3
|
Rename cursors; Cleanup CanvasPreviewFrame class
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
ed1e66bc97
|
Improve performance of inline display rendering
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
de999bf479
|
patchcanvas: Fix some groupos with inline display becoming too small
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
a1141bfea9
|
patchcanvas: Fix ports text width calculation
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
1c675e7bb5
|
Tweak code for canvas group positions
See #1139
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
7ede965819
|
Some attention to inline display
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
0f53835c6d
|
Protect jack metadata usage with a mutex; other position fixes
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
62b91cbe9a
|
Make canvas ports and groups ignore middle mouse clicks
Fixes #1085
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
43a4087d29
|
Fix canvas groups getting stuck out of screen with last commits
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
c178105a15
|
First go at backend-side canvas positions; Safer jack callbacks
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
4a1c2630e1
|
Disable patchcanvas basic eye-candy (box shadow) causes crashes
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
c986c86860
|
Add "Find plugin in patchbay" right-click option
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
0f10d81c59
|
Use PORT_TYPE_PARAMETER for CV ports (brown color)
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
991b184ddb
|
Fix for unconventional mouse releases while line is dragging
Closes #880
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
9a1874745e
|
Forgot a destructor; Make some functions inline
|
5 years ago |
|
falkTX
|
1e72ee7ff5
|
Fixup c++ frontend for strict warnings, actually works..
|
5 years ago |
|
falkTX
|
475603b35c
|
Move c++ code to main frontend folder
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
3cfd7d09fd
|
Use QSafeSettings in a few more places
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
 luz.paz
|
04b1890c3e
|
Fix source comment and user facing typos
Found via `codepell` (v1.17.0.dev0)
```
codespell -q 3 -L iff,iif,inport,sord,sinc,te,uint -S ./source/includes,./source/modules,./source/native-plugins,./data/windows
```
|
5 years ago |
|
falkTX
|
8f0adcdec2
|
A few more windows build preparations, all WIP
|
5 years ago |
|
falkTX
|
ba7f9bba86
|
Convert python static lists into tuples
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
b730f6c2b1
|
Fix dragging canvas box by its icon
Signed-off-by: falkTX <falktx@falktx.com>
|
5 years ago |
|
falkTX
|
97ccc800d6
|
Horizontally align inline displays
Signed-off-by: falkTX <falktx@falktx.com>
|
6 years ago |
|
falkTX
|
7717aa0e47
|
Fixes and caching for inline displays
Signed-off-by: falkTX <falktx@falktx.com>
|
6 years ago |
|
falkTX
|
a0f7944e39
|
Add experimental setting for inline displays, disabled by default
Signed-off-by: falkTX <falktx@falktx.com>
|
6 years ago |
|
falkTX
|
24c12d6adb
|
Fix compatibility with Qt < 5.6
Signed-off-by: falkTX <falktx@falktx.com>
|
6 years ago |
|
falkTX
|
84fdf404d4
|
More fixes for high-dpi, import a few theme fixes
Signed-off-by: falkTX <falktx@falktx.com>
|
6 years ago |
|
falkTX
|
be7137db07
|
Scale inline displays on zoom
Signed-off-by: falkTX <falktx@falktx.com>
|
6 years ago |
|
falkTX
|
0c197e12b1
|
Make main carla client selectable on canvas in jack mode
And remove a print, for now
Signed-off-by: falkTX <falktx@falktx.com>
|
6 years ago |
|
falkTX
|
b4e05d4d1b
|
Mapping between plugin id and canvas group id; Cleanup
Signed-off-by: falkTX <falktx@falktx.com>
|
6 years ago |
|
falkTX
|
0161d0bde6
|
Trigger initial canvas item update when inlinedisplay is turned on
Signed-off-by: falkTX <falktx@falktx.com>
|
6 years ago |
|
falkTX
|
b7922f3dd5
|
Experimental inline display inside canvas
Signed-off-by: falkTX <falktx@falktx.com>
|
6 years ago |
