Browse Source

fix some missing imports and errors seen with pylint

pull/935/head
houston 6 years ago
parent
commit
bdbdfa92ae
4 changed files with 17 additions and 19 deletions
  1. +5
    -15
      source/frontend/patchcanvas/canvasbezierlinemov.py
  2. +4
    -2
      source/frontend/patchcanvas/canvaslinemov.py
  3. +1
    -1
      source/frontend/patchcanvas/canvasport.py
  4. +7
    -1
      source/frontend/patchcanvas/utils.py

+ 5
- 15
source/frontend/patchcanvas/canvasbezierlinemov.py View File

@@ -78,12 +78,6 @@ class CanvasBezierLineMov(QGraphicsPathItem):
pen.setWidthF(pen.widthF() + 0.00001)
self.setPen(pen)
def setPortPosInPortGroupTo(self, port_posinportgrp_to):
self.m_port_posinportgrp_to = port_posinportgrp_to
def setPortGroupLenghtTo(self, portgrp_lenght):
self.m_portgrp_lenght_to = portgrp_lenght
def isReadyToDisc(self):
return self.m_ready_to_disc
@@ -93,12 +87,6 @@ class CanvasBezierLineMov(QGraphicsPathItem):
def toggleReadyToDisc(self):
self.m_ready_to_disc = not bool(self.m_ready_to_disc)
def setPortPosInPortGroupTo(self, port_posinportgrp_to):
self.m_port_posinportgrp_to = port_posinportgrp_to
def setPortGroupLenghtTo(self, portgrp_lenght):
self.m_portgrp_lenght_to = portgrp_lenght
def setDestinationPortGroupPosition(self, port_pos, portgrp_len):
self.m_port_posinportgrp_to = port_pos
self.m_portgrp_lenght_to = portgrp_len
@@ -114,7 +102,8 @@ class CanvasBezierLineMov(QGraphicsPathItem):
elif self.m_port_type == PORT_TYPE_PARAMETER:
pen = QPen(canvas.theme.line_parameter, 2, Qt.DotLine)
else:
qWarning("PatchCanvas::CanvasBezierLineMov(%s, %s, %s) - invalid port type" % (port_mode2str(port_mode), port_type2str(port_type), parent))
qWarning("PatchCanvas::CanvasBezierLineMov(%s, %s, %s) - invalid port type"
% (port_mode2str(self.m_port_mode), port_type2str(self.m_port_type)))
pen = QPen(Qt.black)
else:
if self.m_port_type == PORT_TYPE_AUDIO_JACK:
@@ -123,10 +112,11 @@ class CanvasBezierLineMov(QGraphicsPathItem):
pen = QPen(canvas.theme.line_midi_jack, 2)
elif self.m_port_type == PORT_TYPE_MIDI_ALSA:
pen = QPen(canvas.theme.line_midi_alsa, 2)
elif self.m_port_type == PORT_TYPE_MIDI_PARAMETER:
elif self.m_port_type == PORT_TYPE_PARAMETER:
pen = QPen(canvas.theme.line_parameter, 2)
else:
qWarning("PatchCanvas::CanvasBezierLineMov(%s, %s, %s) - invalid port type" % (port_mode2str(port_mode), port_type2str(port_type), parent))
qWarning("PatchCanvas::CanvasBezierLineMov(%s, %s, %s) - invalid port type"
% (port_mode2str(self.m_port_mode), port_type2str(self.m_port_type)))
pen = QPen(Qt.black)
self.setPen(pen)


+ 4
- 2
source/frontend/patchcanvas/canvaslinemov.py View File

@@ -102,7 +102,8 @@ class CanvasLineMov(QGraphicsLineItem):
elif self.m_port_type == PORT_TYPE_PARAMETER:
pen = QPen(canvas.theme.line_parameter, 2, Qt.DotLine)
else:
qWarning("PatchCanvas::CanvasBezierLineMov(%s, %s, %s) - invalid port type" % (port_mode2str(port_mode), port_type2str(port_type), parent))
qWarning("PatchCanvas::CanvasBezierLineMov(%s, %s) - invalid port type"
% (port_mode2str(self.m_port_mode), port_type2str(self.m_port_type)))
pen = QPen(Qt.black)
else:
if self.m_port_type == PORT_TYPE_AUDIO_JACK:
@@ -114,7 +115,8 @@ class CanvasLineMov(QGraphicsLineItem):
elif self.m_port_type == PORT_TYPE_PARAMETER:
pen = QPen(canvas.theme.line_parameter, 2)
else:
qWarning("PatchCanvas::CanvasBezierLineMov(%s, %s, %s) - invalid port type" % (port_mode2str(port_mode), port_type2str(port_type), parent))
qWarning("PatchCanvas::CanvasBezierLineMov(%s, %s) - invalid port type"
% (port_mode2str(self.m_port_mode), port_type2str(self.m_port_type)))
pen = QPen(Qt.black)
self.setPen(pen)


+ 1
- 1
source/frontend/patchcanvas/canvasport.py View File

@@ -21,7 +21,7 @@

from math import floor

from PyQt5.QtCore import qCritical, Qt, QLineF, QPointF, QRectF, QTimer
from PyQt5.QtCore import qCritical, Qt, QLineF, QPointF, QRectF, QTimer, QSizeF
from PyQt5.QtGui import QCursor, QFont, QFontMetrics, QPainter, QPainterPath, QPen, QPolygonF
from PyQt5.QtWidgets import QGraphicsItem, QMenu



+ 7
- 1
source/frontend/patchcanvas/utils.py View File

@@ -156,7 +156,13 @@ def CanvasGetPortGroupFullName(group_id, portgrp_id):
for portgrp in canvas.portgrp_list:
if (portgrp.group_id == group_id
and portgrp.portgrp_id == portgrp_id):
group_name = CanvasGetGroupName(portgrp.group_id)
group_name = ""
for group in canvas.group_list:
if group.group_id == group_id:
group_name = group.name
break
else:
return ""
endofname = ''
for port_id in portgrp.port_id_list:


Loading…
Cancel
Save