Include needed headers directly in water cpp files

source/modules/water/containers/ArrayAllocationBase.h

@@ -28,6 +28,8 @@
 
 #include "../memory/HeapBlock.h"
 
+#include "CarlaUtils.hpp"
+
 namespace water {
 
 //==============================================================================

source/modules/water/files/File.cpp

@@ -34,6 +34,18 @@
 
 #include "CarlaJuceUtils.hpp"
 
+#ifndef CARLA_OS_WIN
+# include <dlfcn.h>
+# include <fcntl.h>
+# include <pwd.h>
+# include <sys/stat.h>
+# ifdef CARLA_OS_MAC
+# else
+#  include <dirent.h>
+#  include <fnmatch.h>
+# endif
+#endif
+
 namespace water {
 
 File::File (const String& fullPathName)

source/modules/water/maths/MathsFunctions.h

@@ -28,6 +28,8 @@
 
 #include "../water.h"
 
+#include "CarlaUtils.hpp"
+
 #include <algorithm>
 
 namespace water {

source/modules/water/memory/Memory.h

@@ -28,6 +28,8 @@
 
 #include "../water.h"
 
+#include <cstring>
+
 namespace water {
 
 //==============================================================================

source/modules/water/midi/MidiBuffer.cpp

@@ -26,6 +26,8 @@
 #include "MidiBuffer.h"
 #include "MidiMessage.h"
 
+#include "CarlaUtils.hpp"
+
 namespace water {
 
 namespace MidiBufferHelpers

source/modules/water/misc/Time.cpp

@@ -25,6 +25,9 @@
 
 #include "Time.h"
 
+#include <ctime>
+#include <sys/time.h>
+
 namespace water {
 
 namespace TimeHelpers

source/modules/water/processors/AudioProcessor.h

@@ -29,6 +29,8 @@
 #include "../text/String.h"
 #include "../buffers/AudioSampleBuffer.h"
 
+#include "CarlaMutex.hpp"
+
 namespace water {
 
 //==============================================================================

source/modules/water/text/CharPointer_UTF8.h

@@ -29,6 +29,8 @@
 #include "CharacterFunctions.h"
 #include "../memory/Atomic.h"
 
+#include "CarlaUtils.hpp"
+
 namespace water {
 
 //==============================================================================

source/modules/water/text/CharacterFunctions.cpp

@@ -25,6 +25,8 @@
 
 #include "CharacterFunctions.h"
 
+#include <locale>
+
 namespace water {
 
 //==============================================================================

source/modules/water/text/String.cpp

@@ -31,6 +31,9 @@
 
 #include "CarlaJuceUtils.hpp"
 
+#include <locale>
+#include <iostream>
+
 namespace water {
 
 NewLine newLine;

source/modules/water/text/StringPool.h

@@ -28,6 +28,8 @@
 
 #include "../containers/Array.h"
 
+#include "CarlaMutex.hpp"
+
 namespace water {
 
 //==============================================================================

source/modules/water/threads/ChildProcess.cpp

@@ -28,6 +28,11 @@
 #include "../misc/Time.h"
 #include "../streams/MemoryOutputStream.h"
 
+#ifndef CARLA_OS_WIN
+# include <signal.h>
+# include <sys/wait.h>
+#endif
+
 #define JUCE_USE_VFORK 1
 
 namespace water {

source/modules/water/water.cpp

@@ -16,34 +16,6 @@
  * For a full copy of the GNU General Public License see the doc/GPL.txt file.
  */
 
-#include "water.h"
-
-#include "CarlaMutex.hpp"
-
-#include <locale>
-#include <ctime>
-#include <cctype>
-#include <cstdarg>
-#include <iostream>
-#include <sys/time.h>
-
-#ifdef CARLA_OS_WIN
- #include <mmsystem.h>
- #include <shlobj.h>
-#else
- #include <dlfcn.h>
- #include <fcntl.h>
- #include <pwd.h>
- #include <signal.h>
- #include <sys/stat.h>
- #include <sys/wait.h>
- #ifdef CARLA_OS_MAC
- #else
-  #include <dirent.h>
-  #include <fnmatch.h>
- #endif
-#endif
-
 #include "misc/Result.h"
 
 //==============================================================================
@@ -79,7 +51,6 @@ void* Process::getCurrentModuleInstanceHandle() noexcept
 
     return currentModuleHandle;
 }
-
 #else
 static Result getResultForErrno()
 {
@@ -91,7 +62,7 @@ static void* fdToVoidPointer (int fd) noexcept  { return (void*) (pointer_sized_
 
 static int64 juce_fileSetPosition (void* handle, int64 pos)
 {
-    if (handle != 0 && lseek (getFD (handle), pos, SEEK_SET) == pos)
+    if (handle != nullptr && lseek (getFD (handle), pos, SEEK_SET) == pos)
         return pos;
 
     return -1;