Multi-program support for soundfonts; cleanup; add GPL.txt file

doc/GPL.txt

@@ -0,0 +1,280 @@
+                    GNU GENERAL PUBLIC LICENSE
+                       Version 2, June 1991
+
+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
+ 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+                            Preamble
+
+  The licenses for most software are designed to take away your
+freedom to share and change it.  By contrast, the GNU General Public
+License is intended to guarantee your freedom to share and change free
+software--to make sure the software is free for all its users.  This
+General Public License applies to most of the Free Software
+Foundation's software and to any other program whose authors commit to
+using it.  (Some other Free Software Foundation software is covered by
+the GNU Lesser General Public License instead.)  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+this service if you wish), that you receive source code or can get it
+if you want it, that you can change the software or use pieces of it
+in new free programs; and that you know you can do these things.
+
+  To protect your rights, we need to make restrictions that forbid
+anyone to deny you these rights or to ask you to surrender the rights.
+These restrictions translate to certain responsibilities for you if you
+distribute copies of the software, or if you modify it.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must give the recipients all the rights that
+you have.  You must make sure that they, too, receive or can get the
+source code.  And you must show them these terms so they know their
+rights.
+
+  We protect your rights with two steps: (1) copyright the software, and
+(2) offer you this license which gives you legal permission to copy,
+distribute and/or modify the software.
+
+  Also, for each author's protection and ours, we want to make certain
+that everyone understands that there is no warranty for this free
+software.  If the software is modified by someone else and passed on, we
+want its recipients to know that what they have is not the original, so
+that any problems introduced by others will not reflect on the original
+authors' reputations.
+
+  Finally, any free program is threatened constantly by software
+patents.  We wish to avoid the danger that redistributors of a free
+program will individually obtain patent licenses, in effect making the
+program proprietary.  To prevent this, we have made it clear that any
+patent must be licensed for everyone's free use or not licensed at all.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.
+
+                    GNU GENERAL PUBLIC LICENSE
+   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+  0. This License applies to any program or other work which contains
+a notice placed by the copyright holder saying it may be distributed
+under the terms of this General Public License.  The "Program", below,
+refers to any such program or work, and a "work based on the Program"
+means either the Program or any derivative work under copyright law:
+that is to say, a work containing the Program or a portion of it,
+either verbatim or with modifications and/or translated into another
+language.  (Hereinafter, translation is included without limitation in
+the term "modification".)  Each licensee is addressed as "you".
+
+Activities other than copying, distribution and modification are not
+covered by this License; they are outside its scope.  The act of
+running the Program is not restricted, and the output from the Program
+is covered only if its contents constitute a work based on the
+Program (independent of having been made by running the Program).
+Whether that is true depends on what the Program does.
+
+  1. You may copy and distribute verbatim copies of the Program's
+source code as you receive it, in any medium, provided that you
+conspicuously and appropriately publish on each copy an appropriate
+copyright notice and disclaimer of warranty; keep intact all the
+notices that refer to this License and to the absence of any warranty;
+and give any other recipients of the Program a copy of this License
+along with the Program.
+
+You may charge a fee for the physical act of transferring a copy, and
+you may at your option offer warranty protection in exchange for a fee.
+
+  2. You may modify your copy or copies of the Program or any portion
+of it, thus forming a work based on the Program, and copy and
+distribute such modifications or work under the terms of Section 1
+above, provided that you also meet all of these conditions:
+
+    a) You must cause the modified files to carry prominent notices
+    stating that you changed the files and the date of any change.
+
+    b) You must cause any work that you distribute or publish, that in
+    whole or in part contains or is derived from the Program or any
+    part thereof, to be licensed as a whole at no charge to all third
+    parties under the terms of this License.
+
+    c) If the modified program normally reads commands interactively
+    when run, you must cause it, when started running for such
+    interactive use in the most ordinary way, to print or display an
+    announcement including an appropriate copyright notice and a
+    notice that there is no warranty (or else, saying that you provide
+    a warranty) and that users may redistribute the program under
+    these conditions, and telling the user how to view a copy of this
+    License.  (Exception: if the Program itself is interactive but
+    does not normally print such an announcement, your work based on
+    the Program is not required to print an announcement.)
+
+These requirements apply to the modified work as a whole.  If
+identifiable sections of that work are not derived from the Program,
+and can be reasonably considered independent and separate works in
+themselves, then this License, and its terms, do not apply to those
+sections when you distribute them as separate works.  But when you
+distribute the same sections as part of a whole which is a work based
+on the Program, the distribution of the whole must be on the terms of
+this License, whose permissions for other licensees extend to the
+entire whole, and thus to each and every part regardless of who wrote it.
+
+Thus, it is not the intent of this section to claim rights or contest
+your rights to work written entirely by you; rather, the intent is to
+exercise the right to control the distribution of derivative or
+collective works based on the Program.
+
+In addition, mere aggregation of another work not based on the Program
+with the Program (or with a work based on the Program) on a volume of
+a storage or distribution medium does not bring the other work under
+the scope of this License.
+
+  3. You may copy and distribute the Program (or a work based on it,
+under Section 2) in object code or executable form under the terms of
+Sections 1 and 2 above provided that you also do one of the following:
+
+    a) Accompany it with the complete corresponding machine-readable
+    source code, which must be distributed under the terms of Sections
+    1 and 2 above on a medium customarily used for software interchange; or,
+
+    b) Accompany it with a written offer, valid for at least three
+    years, to give any third party, for a charge no more than your
+    cost of physically performing source distribution, a complete
+    machine-readable copy of the corresponding source code, to be
+    distributed under the terms of Sections 1 and 2 above on a medium
+    customarily used for software interchange; or,
+
+    c) Accompany it with the information you received as to the offer
+    to distribute corresponding source code.  (This alternative is
+    allowed only for noncommercial distribution and only if you
+    received the program in object code or executable form with such
+    an offer, in accord with Subsection b above.)
+
+The source code for a work means the preferred form of the work for
+making modifications to it.  For an executable work, complete source
+code means all the source code for all modules it contains, plus any
+associated interface definition files, plus the scripts used to
+control compilation and installation of the executable.  However, as a
+special exception, the source code distributed need not include
+anything that is normally distributed (in either source or binary
+form) with the major components (compiler, kernel, and so on) of the
+operating system on which the executable runs, unless that component
+itself accompanies the executable.
+
+If distribution of executable or object code is made by offering
+access to copy from a designated place, then offering equivalent
+access to copy the source code from the same place counts as
+distribution of the source code, even though third parties are not
+compelled to copy the source along with the object code.
+
+  4. You may not copy, modify, sublicense, or distribute the Program
+except as expressly provided under this License.  Any attempt
+otherwise to copy, modify, sublicense or distribute the Program is
+void, and will automatically terminate your rights under this License.
+However, parties who have received copies, or rights, from you under
+this License will not have their licenses terminated so long as such
+parties remain in full compliance.
+
+  5. You are not required to accept this License, since you have not
+signed it.  However, nothing else grants you permission to modify or
+distribute the Program or its derivative works.  These actions are
+prohibited by law if you do not accept this License.  Therefore, by
+modifying or distributing the Program (or any work based on the
+Program), you indicate your acceptance of this License to do so, and
+all its terms and conditions for copying, distributing or modifying
+the Program or works based on it.
+
+  6. Each time you redistribute the Program (or any work based on the
+Program), the recipient automatically receives a license from the
+original licensor to copy, distribute or modify the Program subject to
+these terms and conditions.  You may not impose any further
+restrictions on the recipients' exercise of the rights granted herein.
+You are not responsible for enforcing compliance by third parties to
+this License.
+
+  7. If, as a consequence of a court judgment or allegation of patent
+infringement or for any other reason (not limited to patent issues),
+conditions are imposed on you (whether by court order, agreement or
+otherwise) that contradict the conditions of this License, they do not
+excuse you from the conditions of this License.  If you cannot
+distribute so as to satisfy simultaneously your obligations under this
+License and any other pertinent obligations, then as a consequence you
+may not distribute the Program at all.  For example, if a patent
+license would not permit royalty-free redistribution of the Program by
+all those who receive copies directly or indirectly through you, then
+the only way you could satisfy both it and this License would be to
+refrain entirely from distribution of the Program.
+
+If any portion of this section is held invalid or unenforceable under
+any particular circumstance, the balance of the section is intended to
+apply and the section as a whole is intended to apply in other
+circumstances.
+
+It is not the purpose of this section to induce you to infringe any
+patents or other property right claims or to contest validity of any
+such claims; this section has the sole purpose of protecting the
+integrity of the free software distribution system, which is
+implemented by public license practices.  Many people have made
+generous contributions to the wide range of software distributed
+through that system in reliance on consistent application of that
+system; it is up to the author/donor to decide if he or she is willing
+to distribute software through any other system and a licensee cannot
+impose that choice.
+
+This section is intended to make thoroughly clear what is believed to
+be a consequence of the rest of this License.
+
+  8. If the distribution and/or use of the Program is restricted in
+certain countries either by patents or by copyrighted interfaces, the
+original copyright holder who places the Program under this License
+may add an explicit geographical distribution limitation excluding
+those countries, so that distribution is permitted only in or among
+countries not thus excluded.  In such case, this License incorporates
+the limitation as if written in the body of this License.
+
+  9. The Free Software Foundation may publish revised and/or new versions
+of the General Public License from time to time.  Such new versions will
+be similar in spirit to the present version, but may differ in detail to
+address new problems or concerns.
+
+Each version is given a distinguishing version number.  If the Program
+specifies a version number of this License which applies to it and "any
+later version", you have the option of following the terms and conditions
+either of that version or of any later version published by the Free
+Software Foundation.  If the Program does not specify a version number of
+this License, you may choose any version ever published by the Free Software
+Foundation.
+
+  10. If you wish to incorporate parts of the Program into other free
+programs whose distribution conditions are different, write to the author
+to ask for permission.  For software which is copyrighted by the Free
+Software Foundation, write to the Free Software Foundation; we sometimes
+make exceptions for this.  Our decision will be guided by the two goals
+of preserving the free status of all derivatives of our free software and
+of promoting the sharing and reuse of software generally.
+
+                            NO WARRANTY
+
+  11. BECAUSE THE PROGRAM IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
+FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW.  EXCEPT WHEN
+OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
+PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED
+OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.  THE ENTIRE RISK AS
+TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU.  SHOULD THE
+PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING,
+REPAIR OR CORRECTION.
+
+  12. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
+WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
+REDISTRIBUTE THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES,
+INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING
+OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED
+TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY
+YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER
+PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGES.
+
+                     END OF TERMS AND CONDITIONS

source/backend/CarlaPlugin.hpp

@@ -523,7 +523,7 @@ public:
      * \param sendOsc Send message change over OSC
      * \param sendCallback Send message change to registered callback
      */
-    void setCtrlChannel(const int8_t channel, const bool sendOsc, const bool sendCallback);
+    virtual void setCtrlChannel(const int8_t channel, const bool sendOsc, const bool sendCallback);
 
     // -------------------------------------------------------------------
     // Set data (plugin-specific stuff)

source/backend/plugin/CarlaPlugin.cpp

@@ -804,7 +804,7 @@ void CarlaPlugin::loadSaveState(const SaveState& saveState)
     // ---------------------------------------------------------------------
     // Part 3 - set midi program
 
-    if (saveState.currentMidiBank >= 0 && saveState.currentMidiProgram >= 0)
+    if (saveState.currentMidiBank >= 0 && saveState.currentMidiProgram >= 0 && type() != PLUGIN_SF2)
         setMidiProgramById(saveState.currentMidiBank, saveState.currentMidiProgram, true, true, true);
 
     // ---------------------------------------------------------------------

source/backend/plugin/FluidSynthPlugin.cpp

@@ -21,6 +21,8 @@
 
 #include <fluidsynth.h>
 
+#include <QtCore/QStringList>
+
 #define FLUIDSYNTH_VERSION_NEW_API (FLUIDSYNTH_VERSION_MAJOR >= 1 && FLUIDSYNTH_VERSION_MINOR >= 1 && FLUIDSYNTH_VERSION_MICRO >= 4)
 
 CARLA_BACKEND_START_NAMESPACE
@@ -41,7 +43,8 @@ public:
           fSynth(nullptr),
           fSynthId(-1),
           fAudio16Buffers(nullptr),
-          fParamBuffers{0.0f}
+          fParamBuffers{0.0f},
+          fCurMidiProgs{0}
     {
         carla_debug("FluidSynthPlugin::FluidSynthPlugin(%p, %i, %s)", engine, id,  bool2str(use16Outs));
 
@@ -71,6 +74,7 @@ public:
         fluid_synth_set_chorus(fSynth, FLUID_CHORUS_DEFAULT_N, FLUID_CHORUS_DEFAULT_LEVEL, FLUID_CHORUS_DEFAULT_SPEED, FLUID_CHORUS_DEFAULT_DEPTH, FLUID_CHORUS_DEFAULT_TYPE);
 
         fluid_synth_set_polyphony(fSynth, FLUID_DEFAULT_POLYPHONY);
+        fluid_synth_set_gain(fSynth, 1.0f);
 
         for (int i=0; i < MAX_MIDI_CHANNELS; ++i)
             fluid_synth_set_interp_method(fSynth, i, FLUID_INTERP_DEFAULT);
@@ -326,12 +330,29 @@ public:
     // -------------------------------------------------------------------
     // Set data (state)
 
-    // nothing
+    void prepareForSave() override
+    {
+        CARLA_ASSERT(fSynth != nullptr);
+
+        char strBuf[STR_MAX+1];
+        std::snprintf(strBuf, STR_MAX, "%i:%i:%i:%i:%i:%i:%i:%i:%i:%i:%i:%i:%i:%i:%i:%i", fCurMidiProgs[0],  fCurMidiProgs[1],  fCurMidiProgs[2],  fCurMidiProgs[3],
+                                                                                          fCurMidiProgs[4],  fCurMidiProgs[5],  fCurMidiProgs[6],  fCurMidiProgs[7],
+                                                                                          fCurMidiProgs[8],  fCurMidiProgs[9],  fCurMidiProgs[10], fCurMidiProgs[11],
+                                                                                          fCurMidiProgs[12], fCurMidiProgs[13], fCurMidiProgs[14], fCurMidiProgs[15]);
+
+        CarlaPlugin::setCustomData(CUSTOM_DATA_STRING, "midiPrograms", strBuf, false);
+    }
 
     // -------------------------------------------------------------------
     // Set data (internal stuff)
 
-    // nothing
+    void setCtrlChannel(const int8_t channel, const bool sendOsc, const bool sendCallback) override
+    {
+        if (channel < MAX_MIDI_CHANNELS)
+            kData->midiprog.current = fCurMidiProgs[channel];
+
+        CarlaPlugin::setCtrlChannel(channel, sendOsc, sendCallback);
+    }
 
     // -------------------------------------------------------------------
     // Set data (plugin-specific stuff)
@@ -388,6 +409,58 @@ public:
         CarlaPlugin::setParameterValue(parameterId, value, sendGui, sendOsc, sendCallback);
     }
 
+    void setCustomData(const char* const type, const char* const key, const char* const value, const bool sendGui) override
+    {
+        CARLA_ASSERT(fSynth != nullptr);
+        CARLA_ASSERT(type != nullptr);
+        CARLA_ASSERT(key != nullptr);
+        CARLA_ASSERT(value != nullptr);
+        carla_debug("DssiPlugin::setCustomData(%s, %s, %s, %s)", type, key, value, bool2str(sendGui));
+
+        if (type == nullptr)
+            return carla_stderr2("DssiPlugin::setCustomData(\"%s\", \"%s\", \"%s\", %s) - type is invalid", type, key, value, bool2str(sendGui));
+
+        if (std::strcmp(type, CUSTOM_DATA_STRING) != 0)
+            return carla_stderr2("DssiPlugin::setCustomData(\"%s\", \"%s\", \"%s\", %s) - type is not string", type, key, value, bool2str(sendGui));
+
+        if (key == nullptr)
+            return carla_stderr2("DssiPlugin::setCustomData(\"%s\", \"%s\", \"%s\", %s) - key is null", type, key, value, bool2str(sendGui));
+
+        if (std::strcmp(key, "midiPrograms") != 0)
+            return carla_stderr2("DssiPlugin::setCustomData(\"%s\", \"%s\", \"%s\", %s) - type is not string", type, key, value, bool2str(sendGui));
+
+        if (value == nullptr)
+            return carla_stderr2("DssiPlugin::setCustomData(\"%s\", \"%s\", \"%s\", %s) - value is null", type, key, value, bool2str(sendGui));
+
+        QStringList midiProgramList(QString(value).split(":", QString::SkipEmptyParts));
+
+        if (midiProgramList.count() == MAX_MIDI_CHANNELS)
+        {
+            uint i = 0;
+            foreach (const QString& midiProg, midiProgramList)
+            {
+                bool ok;
+                uint index = midiProg.toUInt(&ok);
+
+                if (ok && index < kData->midiprog.count)
+                {
+                    const uint32_t bank    = kData->midiprog.data[index].bank;
+                    const uint32_t program = kData->midiprog.data[index].program;
+
+                    fluid_synth_program_select(fSynth, i, fSynthId, bank, program);
+                    fCurMidiProgs[i] = index;
+
+                    if (kData->ctrlChannel == static_cast<int32_t>(i))
+                        kData->engine->callback(CALLBACK_MIDI_PROGRAM_CHANGED, fId, index, 0, 0.0f, nullptr);
+                }
+
+                ++i;
+            }
+        }
+
+        CarlaPlugin::setCustomData(type, key, value, sendGui);
+    }
+
     void setMidiProgram(int32_t index, const bool sendGui, const bool sendOsc, const bool sendCallback) override
     {
         CARLA_ASSERT(fSynth != nullptr);
@@ -408,6 +481,7 @@ public:
 
             //const ScopedSingleProcessLocker spl(this, (sendGui || sendOsc || sendCallback));
             fluid_synth_program_select(fSynth, kData->ctrlChannel, fSynthId, bank, program);
+            fCurMidiProgs[kData->ctrlChannel] = index;
         }
 
         CarlaPlugin::setMidiProgram(index, sendGui, sendOsc, sendCallback);
@@ -816,7 +890,9 @@ public:
         uint32_t count = 0;
         fluid_sfont_t* f_sfont;
         fluid_preset_t f_preset;
+
         bool hasDrums = false;
+        uint32_t drumIndex, drumProg;
 
         f_sfont = fluid_synth_get_sfont_by_id(fSynth, fSynthId);
 
@@ -844,8 +920,12 @@ public:
             kData->midiprog.data[i].program = f_preset.get_num(&f_preset);
             kData->midiprog.data[i].name    = carla_strdup(f_preset.get_name(&f_preset));
 
-            if (kData->midiprog.data[i].bank == 128)
-                hasDrums = true;
+            if (kData->midiprog.data[i].bank == 128 && ! hasDrums)
+            {
+                hasDrums  = true;
+                drumIndex = i;
+                drumProg  = kData->midiprog.data[i].program;
+            }
 
             ++i;
         }
@@ -868,27 +948,33 @@ public:
             fluid_synth_program_reset(fSynth);
 
             // select first program, or 128 for ch10
-            for (i=0; i < 16 && i != 9; ++i)
+            for (i=0; i < MAX_MIDI_CHANNELS && i != 9; ++i)
             {
-                fluid_synth_program_select(fSynth, i, fSynthId, kData->midiprog.data[0].bank, kData->midiprog.data[0].program);
 #ifdef FLUIDSYNTH_VERSION_NEW_API
                 fluid_synth_set_channel_type(fSynth, i, CHANNEL_TYPE_MELODIC);
 #endif
+                fluid_synth_program_select(fSynth, i, fSynthId, kData->midiprog.data[0].bank, kData->midiprog.data[0].program);
+
+                fCurMidiProgs[i] = 0;
             }
 
             if (hasDrums)
             {
-                fluid_synth_program_select(fSynth, 9, fSynthId, 128, 0);
 #ifdef FLUIDSYNTH_VERSION_NEW_API
                 fluid_synth_set_channel_type(fSynth, 9, CHANNEL_TYPE_DRUM);
 #endif
+                fluid_synth_program_select(fSynth, 9, fSynthId, 128, drumProg);
+
+                fCurMidiProgs[9] = drumIndex;
             }
             else
             {
-                fluid_synth_program_select(fSynth, 9, fSynthId, kData->midiprog.data[0].bank, kData->midiprog.data[0].program);
 #ifdef FLUIDSYNTH_VERSION_NEW_API
                 fluid_synth_set_channel_type(fSynth, 9, CHANNEL_TYPE_MELODIC);
 #endif
+                fluid_synth_program_select(fSynth, 9, fSynthId, kData->midiprog.data[0].bank, kData->midiprog.data[0].program);
+
+                fCurMidiProgs[9] = 0;
             }
 
             setMidiProgram(0, false, false, false);
@@ -1123,6 +1209,7 @@ public:
                                 if (kData->midiprog.data[k].bank == bankId && kData->midiprog.data[k].program == progId)
                                 {
                                     fluid_synth_program_select(fSynth, event.channel, fSynthId, bankId, progId);
+                                    fCurMidiProgs[event.channel] = k;
 
                                     if (event.channel == kData->ctrlChannel)
                                         postponeRtEvent(kPluginPostRtEventMidiProgramChange, k, 0, 0.0f);
@@ -1535,6 +1622,8 @@ private:
     float** fAudio16Buffers;
     float   fParamBuffers[FluidSynthParametersMax];
 
+    int32_t fCurMidiProgs[MAX_MIDI_CHANNELS];
+
     CARLA_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(FluidSynthPlugin)
 };
 

source/carla.py

@@ -883,7 +883,7 @@ class CarlaMainW(QMainWindow):
             if pwidget is None:
                 break
 
-            if pwidget.fPluginInfo["hints"] & PLUGIN_CAN_VOLUME:
+            if pwidget.fPluginInfo['hints'] & PLUGIN_CAN_VOLUME:
                 pwidget.ui.edit_dialog.setParameterValue(PARAMETER_VOLUME, 1.0)
                 Carla.host.set_volume(i, 1.0)
 
@@ -898,7 +898,7 @@ class CarlaMainW(QMainWindow):
             if pwidget is None:
                 break
 
-            if pwidget.fPluginInfo["hints"] & PLUGIN_CAN_DRYWET:
+            if pwidget.fPluginInfo['hints'] & PLUGIN_CAN_DRYWET:
                 pwidget.ui.edit_dialog.setParameterValue(PARAMETER_DRYWET, 1.0)
                 Carla.host.set_drywet(i, 1.0)
 
@@ -913,7 +913,7 @@ class CarlaMainW(QMainWindow):
             if pwidget is None:
                 break
 
-            if pwidget.fPluginInfo["hints"] & PLUGIN_CAN_BALANCE:
+            if pwidget.fPluginInfo['hints'] & PLUGIN_CAN_BALANCE:
                 pwidget.ui.edit_dialog.setParameterValue(PARAMETER_BALANCE_LEFT, -1.0)
                 pwidget.ui.edit_dialog.setParameterValue(PARAMETER_BALANCE_RIGHT, 1.0)
                 Carla.host.set_balance_left(i, -1.0)
@@ -943,7 +943,7 @@ class CarlaMainW(QMainWindow):
             if pwidget is None:
                 break
 
-            if pwidget.fPluginInfo["hints"] & PLUGIN_CAN_VOLUME:
+            if pwidget.fPluginInfo['hints'] & PLUGIN_CAN_VOLUME:
                 pwidget.ui.edit_dialog.setParameterValue(PARAMETER_VOLUME, 0.0)
                 Carla.host.set_volume(i, 0.0)
 
@@ -958,7 +958,7 @@ class CarlaMainW(QMainWindow):
             if pwidget is None:
                 break
 
-            if pwidget.fPluginInfo["hints"] & PLUGIN_CAN_DRYWET:
+            if pwidget.fPluginInfo['hints'] & PLUGIN_CAN_DRYWET:
                 pwidget.ui.edit_dialog.setParameterValue(PARAMETER_DRYWET, 0.0)
                 Carla.host.set_drywet(i, 0.0)
 

source/carla_shared.py

@@ -1590,6 +1590,7 @@ class PluginEdit(QDialog):
                 self.ui.sb_ctrl_channel.setValue(self.fControlChannel+1)
                 self.ui.sb_ctrl_channel.blockSignals(False)
                 self.ui.keyboard.allNotesOff()
+                self._updateCtrlMidiProgram()
 
             elif index >= 0:
                 for paramType, paramId, paramWidget in self.fParameterList:
@@ -1719,11 +1720,7 @@ class PluginEdit(QDialog):
         self.fControlChannel = value-1
         Carla.host.set_ctrl_channel(self.fPluginId, self.fControlChannel)
         self.ui.keyboard.allNotesOff()
-
-        mpIndex = Carla.host.get_current_midi_program_index()
-
-        if self.ui.cb_midi_programs.currentIndex() != mpIndex:
-            self.setMidiProgram(mpIndex)
+        self._updateCtrlMidiProgram()
 
     @pyqtSlot(int, float)
     def slot_parameterValueChanged(self, parameterId, value):
@@ -1902,6 +1899,21 @@ class PluginEdit(QDialog):
 
             self.fTabIconTimers.append(ICON_STATE_NULL)
 
+    def _updateCtrlMidiProgram(self):
+        if self.fPluginInfo['type'] != PLUGIN_SF2:
+            return
+
+        if self.fControlChannel == -1:
+            self.ui.cb_midi_programs.setEnabled(False)
+            return
+
+        self.ui.cb_midi_programs.setEnabled(True)
+
+        mpIndex = Carla.host.get_current_midi_program_index(self.fPluginId)
+
+        if self.ui.cb_midi_programs.currentIndex() != mpIndex:
+            self.setMidiProgram(mpIndex)
+
     def showEvent(self, event):
         if not self.fScrollAreaSetup:
             self.fScrollAreaSetup = True
@@ -2071,7 +2083,7 @@ class PluginWidget(QFrame):
         self.ui.b_edit.setChecked(False)
 
     def recheckPluginHints(self, hints):
-        self.fPluginInfo["hints"] = hints
+        self.fPluginInfo['hints'] = hints
         self.ui.b_gui.setEnabled(hints & PLUGIN_HAS_GUI)
 
     def setActive(self, active, sendGui=False, sendCallback=True):
@@ -2213,7 +2225,7 @@ class PluginWidget(QFrame):
 
             if Carla.host.rename_plugin(self.fPluginId, newName):
                 self.fPluginInfo['name'] = newName
-                self.ui.edit_dialog.fPluginInfo["name"] = newName
+                self.ui.edit_dialog.fPluginInfo['name'] = newName
                 self.ui.edit_dialog.reloadInfo()
                 self.ui.label_name.setText(newName)
             else: