diff --git a/source/backend/plugin/CarlaPlugin.cpp b/source/backend/plugin/CarlaPlugin.cpp index acdfa0124..a4b8fd542 100644 --- a/source/backend/plugin/CarlaPlugin.cpp +++ b/source/backend/plugin/CarlaPlugin.cpp @@ -1070,7 +1070,7 @@ void CarlaPlugin::setDryWet(const float value, const bool sendOsc, const bool se { CARLA_ASSERT(value >= 0.0f && value <= 1.0f); - const float fixedValue = carla_fixValue(0.0f, 1.0f, value); + const float fixedValue(carla_fixValue(0.0f, 1.0f, value)); if (kData->postProc.dryWet == fixedValue) return; @@ -1097,7 +1097,7 @@ void CarlaPlugin::setVolume(const float value, const bool sendOsc, const bool se { CARLA_ASSERT(value >= 0.0f && value <= 1.27f); - const float fixedValue = carla_fixValue(0.0f, 1.27f, value); + const float fixedValue(carla_fixValue(0.0f, 1.27f, value)); if (kData->postProc.volume == fixedValue) return; @@ -1124,7 +1124,7 @@ void CarlaPlugin::setBalanceLeft(const float value, const bool sendOsc, const bo { CARLA_ASSERT(value >= -1.0f && value <= 1.0f); - const float fixedValue = carla_fixValue(-1.0f, 1.0f, value); + const float fixedValue(carla_fixValue(-1.0f, 1.0f, value)); if (kData->postProc.balanceLeft == fixedValue) return; @@ -1151,7 +1151,7 @@ void CarlaPlugin::setBalanceRight(const float value, const bool sendOsc, const b { CARLA_ASSERT(value >= -1.0f && value <= 1.0f); - const float fixedValue = carla_fixValue(-1.0f, 1.0f, value); + const float fixedValue(carla_fixValue(-1.0f, 1.0f, value)); if (kData->postProc.balanceRight == fixedValue) return; @@ -1178,7 +1178,7 @@ void CarlaPlugin::setPanning(const float value, const bool sendOsc, const bool s { CARLA_ASSERT(value >= -1.0f && value <= 1.0f); - const float fixedValue = carla_fixValue(-1.0f, 1.0f, value); + const float fixedValue(carla_fixValue(-1.0f, 1.0f, value)); if (kData->postProc.panning == fixedValue) return; diff --git a/source/backend/plugin/CarlaPlugin.pro b/source/backend/plugin/CarlaPlugin.pro index acc9b312c..43b2ef8e7 100644 --- a/source/backend/plugin/CarlaPlugin.pro +++ b/source/backend/plugin/CarlaPlugin.pro @@ -12,7 +12,7 @@ CONFIG = debug CONFIG += link_pkgconfig qt shared warn_on DEFINES = DEBUG -DEFINES += QTCREATOR_TEST +DEFINES += QTCREATOR_TEST MOC_PARSING # Shared DEFINES += WANT_NATIVE diff --git a/source/backend/plugin/LadspaPlugin.cpp b/source/backend/plugin/LadspaPlugin.cpp index 95aa83288..8529bc488 100644 --- a/source/backend/plugin/LadspaPlugin.cpp +++ b/source/backend/plugin/LadspaPlugin.cpp @@ -373,7 +373,7 @@ public: { CARLA_ASSERT(parameterId < kData->param.count); - const float fixedValue = kData->param.fixValue(parameterId, value); + const float fixedValue(kData->param.fixValue(parameterId, value)); fParamBuffers[parameterId] = fixedValue; CarlaPlugin::setParameterValue(parameterId, fixedValue, sendGui, sendOsc, sendCallback); diff --git a/source/backend/plugin/Lv2Plugin.cpp b/source/backend/plugin/Lv2Plugin.cpp index 86a58607d..2f541b7f1 100644 --- a/source/backend/plugin/Lv2Plugin.cpp +++ b/source/backend/plugin/Lv2Plugin.cpp @@ -573,8 +573,6 @@ public: unsigned int availableOptions() override { - CARLA_ASSERT(fRdfDescriptor != nullptr); - unsigned int options = 0x0; options |= PLUGIN_OPTION_MAP_PROGRAM_CHANGES; @@ -1596,7 +1594,7 @@ public: j = iCtrl++; kData->param.data[j].index = j; kData->param.data[j].rindex = i; - kData->param.data[j].hints = 0; + kData->param.data[j].hints = 0x0; kData->param.data[j].midiChannel = 0; kData->param.data[j].midiCC = -1; @@ -1628,7 +1626,7 @@ public: if (max - min == 0.0f) { - carla_stderr("Broken plugin parameter: max - min == 0"); + carla_stderr2("WARNING - Broken plugin parameter '%s': max - min == 0.0f", fRdfDescriptor->Ports[i].Name); max = min + 0.1f; } @@ -1764,7 +1762,7 @@ public: else { kData->param.data[j].type = PARAMETER_UNKNOWN; - carla_stderr("WARNING - Got a broken Port (Control, but not input or output)"); + carla_stderr2("WARNING - Got a broken Port (Control, but not input or output)"); } // extra parameter hints @@ -2664,6 +2662,9 @@ public: for (i=0; i < kData->audioOut.count; ++i) carla_zeroFloat(fAudioOutBuffers[i], frames); + // -------------------------------------------------------------------------------------------------------- + // Run plugin + fDescriptor->run(fHandle, frames); if (fHandle2 != nullptr) diff --git a/source/backend/plugin/VstPlugin.cpp b/source/backend/plugin/VstPlugin.cpp index 9f2ab493a..5e2b8375e 100644 --- a/source/backend/plugin/VstPlugin.cpp +++ b/source/backend/plugin/VstPlugin.cpp @@ -1767,7 +1767,7 @@ protected: else if (fIsProcessing) { // Called from engine - const float fixedValue = kData->param.fixValue(index, opt); + const float fixedValue(kData->param.fixValue(index, opt)); if (kData->engine->isOffline()) {