Force fixed-size buffers if a plugin has midi-out(s)

source/backend/plugin/Lv2Plugin.cpp

@@ -659,7 +659,7 @@ public:
 
         options |= PLUGIN_OPTION_MAP_PROGRAM_CHANGES;
 
-        if (! needsFixedBuffer())
+        if (midiInCount() == 0 || ! needsFixedBuffer())
             options |= PLUGIN_OPTION_FIXED_BUFFER;
 
         if (kData->engine->getProccessMode() != PROCESS_MODE_CONTINUOUS_RACK)
@@ -4169,7 +4169,7 @@ public:
 
             fOptions |= PLUGIN_OPTION_MAP_PROGRAM_CHANGES;
 
-            if (needsFixedBuffer())
+            if (midiInCount() > 0 || needsFixedBuffer())
                 fOptions |= PLUGIN_OPTION_FIXED_BUFFER;
 
             if (kData->engine->getOptions().forceStereo)
@@ -4189,7 +4189,7 @@ public:
             fOptions = kData->loadSettings(fOptions, availableOptions());
 
             // ignore settings, we need this anyway
-            if (needsFixedBuffer())
+            if (midiInCount() > 0 || needsFixedBuffer())
                 fOptions |= PLUGIN_OPTION_FIXED_BUFFER;
         }
 

source/backend/plugin/NativePlugin.cpp

@@ -289,9 +289,11 @@ public:
 
         unsigned int options = 0x0;
 
-        options |= PLUGIN_OPTION_FIXED_BUFFER;
         options |= PLUGIN_OPTION_MAP_PROGRAM_CHANGES;
 
+        if (midiInCount() == 0)
+            options |= PLUGIN_OPTION_FIXED_BUFFER;
+
         if (kData->engine->getProccessMode() != PROCESS_MODE_CONTINUOUS_RACK)
         {
             if (fOptions & PLUGIN_OPTION_FORCE_STEREO)
@@ -2137,9 +2139,11 @@ public:
             // set default options
             fOptions = 0x0;
 
-            fOptions |= PLUGIN_OPTION_FIXED_BUFFER;
             fOptions |= PLUGIN_OPTION_MAP_PROGRAM_CHANGES;
 
+            if (midiInCount() > 0)
+                fOptions |= PLUGIN_OPTION_FIXED_BUFFER;
+
             if (kData->engine->getOptions().forceStereo)
                 fOptions |= PLUGIN_OPTION_FORCE_STEREO;
 
@@ -2155,6 +2159,10 @@ public:
             kData->idStr  = "Native/";
             kData->idStr += label;
             fOptions = kData->loadSettings(fOptions, availableOptions());
+
+            // ignore settings, we need this anyway
+            if (midiInCount() > 0)
+                fOptions |= PLUGIN_OPTION_FIXED_BUFFER;
         }
 
         return true;

source/backend/plugin/VstPlugin.cpp

@@ -192,9 +192,11 @@ public:
 
         unsigned int options = 0x0;
 
-        options |= PLUGIN_OPTION_FIXED_BUFFER;
         options |= PLUGIN_OPTION_MAP_PROGRAM_CHANGES;
 
+        if (midiInCount() == 0)
+            options |= PLUGIN_OPTION_FIXED_BUFFER;
+
         if (fEffect->flags & effFlagsProgramChunks)
             options |= PLUGIN_OPTION_USE_CHUNKS;
 
@@ -2291,6 +2293,9 @@ public:
 
             fOptions |= PLUGIN_OPTION_MAP_PROGRAM_CHANGES;
 
+            if (midiInCount() > 0)
+                fOptions |= PLUGIN_OPTION_FIXED_BUFFER;
+
             if (fEffect->flags & effFlagsProgramChunks)
                 fOptions |= PLUGIN_OPTION_USE_CHUNKS;
 
@@ -2308,6 +2313,10 @@ public:
             kData->idStr += "/";
             kData->idStr += CarlaString(uniqueId());
             fOptions = kData->loadSettings(fOptions, availableOptions());
+
+            // ignore settings, we need this anyway
+            if (midiInCount() > 0)
+                fOptions |= PLUGIN_OPTION_FIXED_BUFFER;
         }
 
         return true;