From c01646de9f11bba2f71adc2000e99492d29e8762 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A1s=20Szab=C3=B3?=
 <34127628+firolightfog@users.noreply.github.com>
Date: Tue, 13 Jan 2026 17:13:57 +0100
Subject: [PATCH] Fix build workflow for VCV Rack plugin

Updated the GitHub Actions workflow to improve the build process for VCV Rack plugins. Changes include fixing the build command and ensuring proper verification of premake versions.
---
 .github/workflows/build.yml | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 2351527..b0b01c1 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -1,5 +1,4 @@
 name: Build VCV Rack Plugin
-# on: [push, pull_request]
 on:
   push:
     paths:
@@ -42,6 +41,9 @@ jobs:
     container:
       image: ghcr.io/qno/rack-plugin-toolchain-win-linux
       options: --user root
+    # This ensures /usr/local/bin is at the front of PATH for all steps in this job
+    env:
+      PATH: /usr/local/bin:$PATH
     strategy:
       matrix:
         platform: [win, lin]
@@ -55,7 +57,6 @@ jobs:
           path: plugin.json
           key: ${{ github.sha }}-${{ github.run_id }}
 
-      # ▼▼▼ REPLACED STEP: Download premake binaries directly ▼▼▼
       - name: Download and setup premake
         run: |
           # Download premake5 (used for Windows cross-compilation in this container)
@@ -63,24 +64,24 @@ jobs:
           tar -xzf premake-5.0.0-beta2-linux.tar.gz
           chmod +x premake5
           mv premake5 /usr/local/bin/
-          
+
           # Also download premake4 (referenced in the Makefile for Linux target)
           wget -q https://github.com/premake/premake-4.x/releases/download/v4.4-beta5/premake-4.4-beta5-linux.tar.gz
           tar -xzf premake-4.4-beta5-linux.tar.gz
           chmod +x premake4
           mv premake4 /usr/local/bin/
-          
-          # Verify both are available
+
+          # Verify both are available using absolute paths
           echo "Premake versions available:"
-          premake5 --version
-          premake4 --version
-      # ▲▲▲ REPLACED STEP ▲▲▲
-               
+          /usr/local/bin/premake5 --version
+          /usr/local/bin/premake4 --version
+
       - name: Build plugin
         run: |
           export PLUGIN_DIR=$GITHUB_WORKSPACE
           pushd ${{ env.rack-plugin-toolchain-dir }}
-          make plugin-build-${{ matrix.platform }}-64
+          # Fixed: Added the missing 'x' before 64. The command must be plugin-build-win-x64/lin-x64.
+          make plugin-build-${{ matrix.platform }}-x64
       - name: Upload artifact
         uses: actions/upload-artifact@v4
         with:
@@ -88,7 +89,7 @@ jobs:
           name: ${{ matrix.platform }}
 
   build-mac:
-    if: false # <-- Add this line to disable the job
+    if: false # <-- Mac jobs are disabled to focus on Windows/Linux first
     name: mac
     needs: modify-plugin-version
     runs-on: macos-latest