From 96cc4cbc78e13c088ca2978541885bd79a5622a8 Mon Sep 17 00:00:00 2001 From: Andrew Belt Date: Tue, 29 Oct 2019 08:46:00 -0400 Subject: [PATCH] Update TODO list for PythonEngine. --- Makefile | 2 +- src/PythonEngine.cpp | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 48238bd..d4224db 100644 --- a/Makefile +++ b/Makefile @@ -16,7 +16,7 @@ include $(RACK_DIR)/arch.mk DUKTAPE ?= 0 QUICKJS ?= 1 LUAJIT ?= 1 -PYTHON ?= 0 +PYTHON ?= 1 # Entropia File System Watcher efsw := dep/lib/libefsw-static-release.a diff --git a/src/PythonEngine.cpp b/src/PythonEngine.cpp index 12f3a7c..edcb0ec 100644 --- a/src/PythonEngine.cpp +++ b/src/PythonEngine.cpp @@ -11,9 +11,12 @@ extern "C" { /* TODO: +- Fix Numpy loading on Linux. + - "undefined symbol: PyExc_RecursionError" + - This worked in Python 3.7, but because some other crash (regarding GIL interpreter objects, I forgot) was fixed on Python's issue tracker in the last month, I switched to Python 3.8 to solve that problem. +- Test build and running on Windows/Mac. (Has not been attempted.) - Allow multiple instances with GIL. - Fix destructors. -- Add config object. */