From dd402b8e43b6abfdb949558246e11b8a8d69e8ed Mon Sep 17 00:00:00 2001
From: Andrew Belt <andrewpbelt@gmail.com>
Date: Thu, 15 Mar 2018 23:42:05 -0400
Subject: [PATCH] Made modules and wires global

---
 include/engine.hpp |  5 +++++
 src/engine.cpp     | 48 ++++++++++++++++++++++------------------------
 2 files changed, 28 insertions(+), 25 deletions(-)

diff --git a/include/engine.hpp b/include/engine.hpp
index 5806c271..ff36614f 100644
--- a/include/engine.hpp
+++ b/include/engine.hpp
@@ -121,6 +121,11 @@ float engineGetSampleRate();
 float engineGetSampleTime();
 
 extern bool gPaused;
+/** If plugins begin using this in harmful ways, I will remove it and break your API.
+To avoid spoiling the fun for everyone, make sure your plugins demonstrate good behavior by not being "surprising" to the user. Your plugin needs to have a clear purpose for manipulating other modules and wires and must be done with a good UX.
+*/
+extern std::vector<Module*> gModules;
+extern std::vector<Wire*> gWires;
 
 
 } // namespace rack
diff --git a/src/engine.cpp b/src/engine.cpp
index 2cb94374..49b5c067 100644
--- a/src/engine.cpp
+++ b/src/engine.cpp
@@ -14,20 +14,18 @@
 
 namespace rack {
 
-float sampleRate;
-float sampleTime;
 bool gPaused = false;
-
+std::vector<Module*> gModules;
+std::vector<Wire*> gWires;
 
 static bool running = false;
+static float sampleRate;
+static float sampleTime;
 
 static std::mutex mutex;
 static std::thread thread;
 static VIPMutex vipMutex;
 
-static std::vector<Module*> modules;
-static std::vector<Wire*> wires;
-
 // Parameter interpolation
 static Module *smoothModule = NULL;
 static int smoothParamId;
@@ -65,8 +63,8 @@ void engineInit() {
 
 void engineDestroy() {
 	// Make sure there are no wires or modules in the rack on destruction. This suggests that a module failed to remove itself before the WINDOW was destroyed.
-	assert(wires.empty());
-	assert(modules.empty());
+	assert(gWires.empty());
+	assert(gModules.empty());
 }
 
 static void engineStep() {
@@ -87,7 +85,7 @@ static void engineStep() {
 	}
 
 	// Step modules
-	for (Module *module : modules) {
+	for (Module *module : gModules) {
 		module->step();
 
 		// TODO skip this step when plug lights are disabled
@@ -109,7 +107,7 @@ static void engineStep() {
 	}
 
 	// Step cables by moving their output values to inputs
-	for (Wire *wire : wires) {
+	for (Wire *wire : gWires) {
 		wire->step();
 	}
 }
@@ -168,9 +166,9 @@ void engineAddModule(Module *module) {
 	VIPLock vipLock(vipMutex);
 	std::lock_guard<std::mutex> lock(mutex);
 	// Check that the module is not already added
-	auto it = std::find(modules.begin(), modules.end(), module);
-	assert(it == modules.end());
-	modules.push_back(module);
+	auto it = std::find(gModules.begin(), gModules.end(), module);
+	assert(it == gModules.end());
+	gModules.push_back(module);
 }
 
 void engineRemoveModule(Module *module) {
@@ -182,20 +180,20 @@ void engineRemoveModule(Module *module) {
 		smoothModule = NULL;
 	}
 	// Check that all wires are disconnected
-	for (Wire *wire : wires) {
+	for (Wire *wire : gWires) {
 		assert(wire->outputModule != module);
 		assert(wire->inputModule != module);
 	}
 	// Check that the module actually exists
-	auto it = std::find(modules.begin(), modules.end(), module);
-	assert(it != modules.end());
+	auto it = std::find(gModules.begin(), gModules.end(), module);
+	assert(it != gModules.end());
 	// Remove it
-	modules.erase(it);
+	gModules.erase(it);
 }
 
 static void updateActive() {
 	// Set everything to inactive
-	for (Module *module : modules) {
+	for (Module *module : gModules) {
 		for (Input &input : module->inputs) {
 			input.active = false;
 		}
@@ -204,7 +202,7 @@ static void updateActive() {
 		}
 	}
 	// Set inputs/outputs to active
-	for (Wire *wire : wires) {
+	for (Wire *wire : gWires) {
 		wire->outputModule->outputs[wire->outputId].active = true;
 		wire->inputModule->inputs[wire->inputId].active = true;
 	}
@@ -218,12 +216,12 @@ void engineAddWire(Wire *wire) {
 	assert(wire->outputModule);
 	assert(wire->inputModule);
 	// Check that the wire is not already added, and that the input is not already used by another cable
-	for (Wire *wire2 : wires) {
+	for (Wire *wire2 : gWires) {
 		assert(wire2 != wire);
 		assert(!(wire2->inputModule == wire->inputModule && wire2->inputId == wire->inputId));
 	}
 	// Add the wire
-	wires.push_back(wire);
+	gWires.push_back(wire);
 	updateActive();
 }
 
@@ -232,12 +230,12 @@ void engineRemoveWire(Wire *wire) {
 	VIPLock vipLock(vipMutex);
 	std::lock_guard<std::mutex> lock(mutex);
 	// Check that the wire is already added
-	auto it = std::find(wires.begin(), wires.end(), wire);
-	assert(it != wires.end());
+	auto it = std::find(gWires.begin(), gWires.end(), wire);
+	assert(it != gWires.end());
 	// Set input to 0V
 	wire->inputModule->inputs[wire->inputId].value = 0.0;
 	// Remove the wire
-	wires.erase(it);
+	gWires.erase(it);
 	updateActive();
 }
 
@@ -263,7 +261,7 @@ void engineSetSampleRate(float newSampleRate) {
 	sampleRate = newSampleRate;
 	sampleTime = 1.0 / sampleRate;
 	// onSampleRateChange
-	for (Module *module : modules) {
+	for (Module *module : gModules) {
 		module->onSampleRateChange();
 	}
 }