Define ARCH_* macros in arch.hpp instead of on the command line.

compile.mk

@@ -28,20 +28,16 @@ endif
 
 # Architecture-independent flags
 ifdef ARCH_X64
-	FLAGS += -DARCH_X64
 	FLAGS += -march=nehalem
 endif
 ifdef ARCH_ARM64
-	FLAGS += -DARCH_ARM64
 	FLAGS += -march=armv8-a+fp+simd
 endif
 
 ifdef ARCH_LIN
-	FLAGS += -DARCH_LIN
 	CXXFLAGS += -Wsuggest-override
 endif
 ifdef ARCH_MAC
-	FLAGS += -DARCH_MAC
 	CXXFLAGS += -stdlib=libc++
 	LDFLAGS += -stdlib=libc++
 	MAC_SDK_FLAGS := -mmacosx-version-min=10.9
@@ -49,7 +45,6 @@ ifdef ARCH_MAC
 	LDFLAGS += $(MAC_SDK_FLAGS)
 endif
 ifdef ARCH_WIN
-	FLAGS += -DARCH_WIN
 	FLAGS += -D_USE_MATH_DEFINES
 	FLAGS += -municode
 	CXXFLAGS += -Wsuggest-override

include/arch.hpp

@@ -0,0 +1,20 @@
+#pragma once
+
+// Check CPU
+#if defined __x86_64__
+	#define ARCH_X64 1
+#endif
+#if defined __aarch64__
+	#define ARCH_ARM64 1
+#endif
+
+// Check OS
+#if defined _WIN32
+	#define ARCH_WIN 1
+#endif
+#if defined __APPLE__
+	#define ARCH_MAC 1
+#endif
+#if defined __linux__
+	#define ARCH_LIN 1
+#endif

include/common.hpp

@@ -15,6 +15,8 @@
 #include <string>
 #include <stdexcept>
 
+#include <arch.hpp>
+
 
 /** Attribute for deprecated functions and symbols.
 E.g.

include/simd/Vector.hpp

@@ -1,6 +1,7 @@
 #pragma once
 #include <cstring>
 #include "common.hpp"
+#include <common.hpp>
 
 
 namespace rack {

include/simd/functions.hpp

@@ -1,7 +1,6 @@
 #pragma once
 #include <simd/Vector.hpp>
 #include <simd/sse_mathfun_extension.h>
-#include <common.hpp>
 #include <math.hpp>
 
 

src/asset.cpp

@@ -1,3 +1,5 @@
+#include <arch.hpp>
+
 #if defined ARCH_MAC
 	#include <CoreFoundation/CoreFoundation.h>
 	#include <CoreServices/CoreServices.h>

src/plugin.cpp

@@ -1,3 +1,5 @@
+#include <arch.hpp>
+
 #include <thread>
 #include <map>
 #include <stdexcept>
@@ -99,7 +101,7 @@ static InitCallback loadPluginCallback(Plugin* plugin) {
 	libraryExt = "so";
 #elif defined ARCH_WIN
 	libraryExt = "dll";
-#elif ARCH_MAC
+#elif defined ARCH_MAC
 	libraryExt = "dylib";
 #endif
 

src/string.cpp

@@ -1,3 +1,5 @@
+#include <arch.hpp>
+
 #include <ctime>
 #include <cctype> // for tolower and toupper
 #include <algorithm> // for transform and equal

src/system.cpp

@@ -1,3 +1,5 @@
+#include <arch.hpp>
+
 #include <thread>
 #include <regex>
 #include <chrono>
@@ -701,7 +703,7 @@ std::string getStackTrace() {
 			// If regex fails, just use the raw line
 			s += line;
 		}
-#elif ARCH_MAC
+#elif defined ARCH_MAC
 		// Parse line, e.g.
 		// 1   Rack                                0x0000000002ddc3eb _mangled_symbol + 27
 		std::regex r(R"((\d+)\s+(.+?)\s+(.+?) (.*?) \+ (.+?))");

src/window/Window.cpp

@@ -1,3 +1,5 @@
+#include <arch.hpp>
+
 #include <map>
 #include <queue>
 #include <thread>