From e9086941210e0b41cb0bcdaab8afac2c6da60155 Mon Sep 17 00:00:00 2001 From: Andrew Belt Date: Fri, 24 Sep 2021 04:22:46 -0400 Subject: [PATCH 1/4] Add port labels and bypass routes to VCAs. --- src/VCA.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/VCA.cpp b/src/VCA.cpp index 8de9565..5ef6ad6 100644 --- a/src/VCA.cpp +++ b/src/VCA.cpp @@ -34,6 +34,8 @@ struct VCA : Module { configInput(IN2_INPUT, "Channel 2"); configOutput(OUT1_OUTPUT, "Channel 1"); configOutput(OUT2_OUTPUT, "Channel 2"); + configBypass(IN1_INPUT, OUT1_OUTPUT); + configBypass(IN2_INPUT, OUT2_OUTPUT); } void processChannel(Input& in, Param& level, Input& lin, Input& exp, Output& out) { @@ -159,6 +161,10 @@ struct VCA_1 : Module { config(NUM_PARAMS, NUM_INPUTS, NUM_OUTPUTS, NUM_LIGHTS); configParam(LEVEL_PARAM, 0.0, 1.0, 1.0, "Level", "%", 0, 100); configSwitch(EXP_PARAM, 0.0, 1.0, 1.0, "Response mode", {"Exponential", "Linear"}); + configInput(CV_INPUT, "CV"); + configInput(IN_INPUT, "Channel"); + configOutput(OUT_OUTPUT, "Channel"); + configBypass(IN_INPUT, OUT_OUTPUT); } void process(const ProcessArgs& args) override { From a7be64dae25b12690531d965da9f8684e4226e38 Mon Sep 17 00:00:00 2001 From: Andrew Belt Date: Fri, 24 Sep 2021 04:23:00 -0400 Subject: [PATCH 2/4] Add presets dir to Makefile in case it is added later. --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9a14fb2..b339e62 100644 --- a/Makefile +++ b/Makefile @@ -2,6 +2,8 @@ RACK_DIR ?= ../.. FLAGS += -Idep/include SOURCES += $(wildcard src/*.cpp) -DISTRIBUTABLES += $(wildcard LICENSE*) res +DISTRIBUTABLES += res +DISTRIBUTABLES += $(wildcard LICENSE*) +DISTRIBUTABLES += $(wildcard presets) include $(RACK_DIR)/plugin.mk From 39f94eaebb2164d0feec0c2dabace4fd2d815ab6 Mon Sep 17 00:00:00 2001 From: Andrew Belt Date: Fri, 24 Sep 2021 04:26:18 -0400 Subject: [PATCH 3/4] Use nvgGlobalTint() instead of nvgGlobalAlpha() for un-tinting lights. --- src/Scope.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Scope.cpp b/src/Scope.cpp index 0658e20..e5df0f7 100644 --- a/src/Scope.cpp +++ b/src/Scope.cpp @@ -302,7 +302,7 @@ struct ScopeDisplay : TransparentWidget { return; // Disable tinting when rack brightness is decreased - nvgGlobalAlpha(args.vg, 1.0); + nvgGlobalTint(args.vg, color::WHITE); float gainX = std::pow(2.f, std::round(module->params[Scope::X_SCALE_PARAM].getValue())) / 10.f; float gainY = std::pow(2.f, std::round(module->params[Scope::Y_SCALE_PARAM].getValue())) / 10.f; From 1d9c4b7e564c91d132d06c88d4580f8251d80418 Mon Sep 17 00:00:00 2001 From: Andrew Belt Date: Sat, 25 Sep 2021 10:33:04 -0400 Subject: [PATCH 4/4] Update email in plugin.json. --- plugin.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin.json b/plugin.json index 9163251..d22bc90 100644 --- a/plugin.json +++ b/plugin.json @@ -5,7 +5,7 @@ "name": "Fundamental", "brand": "VCV", "author": "VCV", - "authorEmail": "contact@vcvrack.com", + "authorEmail": "support@vcvrack.com", "pluginUrl": "https://vcvrack.com/Fundamental.html", "authorUrl": "https://vcvrack.com/", "manualUrl": "https://vcvrack.com/Fundamental.html#manual",