Browse Source

Addressing review comments

* fixing behavior of red light in reverb VU meter
* removed more unnecessary casts to float_4
tags/v1.1.0^2
hemmer 2 years ago
parent
commit
cf6e6d9a34
4 changed files with 4 additions and 5 deletions
  1. +1
    -1
      src/ABC.cpp
  2. +1
    -1
      src/EvenVCO.cpp
  3. +1
    -1
      src/PulseGenerator_4.hpp
  4. +1
    -2
      src/SpringReverb.cpp

+ 1
- 1
src/ABC.cpp View File

@@ -93,7 +93,7 @@ struct ABC : Module {
}
else {
for (int c = 0; c < activeEngines; c += 4)
inC[c / 4] = float_4(10.f * mult_C);
inC[c / 4] = 10.f * mult_C;
}

for (int c = 0; c < activeEngines; c += 4)


+ 1
- 1
src/EvenVCO.cpp View File

@@ -102,7 +102,7 @@ struct EvenVCO : Module {
pw[c / 4] = rescale(clamp(pw[c / 4], -1.0f, 1.0f), -1.0f, 1.0f, 0.05f, 1.0f - 0.05f);

// Advance phase
deltaPhase[c / 4] = clamp(freq[c / 4] * args.sampleTime, float_4(1e-6f), float_4(0.5f));
deltaPhase[c / 4] = clamp(freq[c / 4] * args.sampleTime, 1e-6f, 0.5f);
oldPhase[c / 4] = phase[c / 4];
phase[c / 4] += deltaPhase[c / 4];
}


+ 1
- 1
src/PulseGenerator_4.hpp View File

@@ -16,7 +16,7 @@ struct PulseGenerator_4 {

simd::float_4 mask = (remaining > 0.f);

remaining -= ifelse(mask, simd::float_4(deltaTime), 0.f);
remaining -= ifelse(mask, deltaTime, 0.f);
return ifelse(mask, simd::float_4::mask(), 0.f);
}



+ 1
- 2
src/SpringReverb.cpp View File

@@ -46,6 +46,7 @@ struct SpringReverb : Module {
dsp::VuMeter2 lightFilter;
dsp::ClockDivider lightRefreshClock;

const float brightnessIntervals[8] = {17.f, 14.f, 12.f, 9.f, 6.f, 0.f, -6.f, -12.f};

SpringReverb() {
config(NUM_PARAMS, NUM_INPUTS, NUM_OUTPUTS, NUM_LIGHTS);
@@ -135,8 +136,6 @@ struct SpringReverb : Module {

if (lightRefreshClock.process()) {

float brightnessIntervals[8] = {14.f, 14.f, 12.f, 9.f, 6.f, 0.f, -6.f, -12.f};

for (int i = 0; i < 7; i++) {
float brightness = vuFilter.getBrightness(brightnessIntervals[i + 1], brightnessIntervals[i]);
lights[VU1_LIGHTS + i].setBrightness(brightness);


Loading…
Cancel
Save