Yet another attempt to get all the edge-cases right in Button::internalClickCallback

modules/juce_gui_basics/buttons/juce_Button.cpp

@@ -308,10 +308,17 @@ void Button::triggerClick()
 void Button::internalClickCallback (const ModifierKeys& modifiers)
 {
     if (clickTogglesState)
-        setToggleState (radioGroupId != 0 || ! lastToggleState, sendNotification);
+    {
+        const bool shouldBeOn = (radioGroupId != 0 || ! lastToggleState);
+
+        if (shouldBeOn != getToggleState())
+        {
+            setToggleState (shouldBeOn, sendNotification);
+            return;
+        }
+    }
 
-    if (radioGroupId != 0 || ! clickTogglesState)
-        sendClickMessage (modifiers);
+    sendClickMessage (modifiers);
 }
 
 void Button::flashButtonState()