Browse Source

Removed some empty ValueTree::Listener methods that are no longer needed

tags/2021-05-28
ed 6 years ago
parent
commit
c96bf71488
14 changed files with 6 additions and 43 deletions
  1. +0
    -5
      extras/Projucer/Source/Application/Windows/jucer_PIPCreatorWindowComponent.h
  2. +0
    -1
      extras/Projucer/Source/LiveBuildEngine/jucer_CompileEngineClient.cpp
  3. +0
    -2
      extras/Projucer/Source/Project/UI/Sidebar/jucer_ExporterTreeItems.h
  4. +0
    -1
      extras/Projucer/Source/Project/UI/Sidebar/jucer_FileTreeItems.h
  5. +0
    -6
      extras/Projucer/Source/Project/UI/Sidebar/jucer_ProjectTreeItemBase.h
  6. +0
    -3
      extras/Projucer/Source/Project/UI/jucer_HeaderComponent.h
  7. +0
    -1
      extras/Projucer/Source/Project/jucer_Project.cpp
  8. +0
    -1
      extras/Projucer/Source/Project/jucer_Project.h
  9. +0
    -7
      modules/juce_audio_processors/utilities/juce_AudioProcessorValueTreeState.cpp
  10. +0
    -3
      modules/juce_audio_processors/utilities/juce_AudioProcessorValueTreeState.h
  11. +0
    -4
      modules/juce_data_structures/values/juce_CachedValue.h
  12. +6
    -6
      modules/juce_data_structures/values/juce_ValueTree.cpp
  13. +0
    -2
      modules/juce_data_structures/values/juce_ValueTreeSynchroniser.cpp
  14. +0
    -1
      modules/juce_data_structures/values/juce_ValueTreeSynchroniser.h

+ 0
- 5
extras/Projucer/Source/Application/Windows/jucer_PIPCreatorWindowComponent.h View File

@@ -203,11 +203,6 @@ private:
} }
} }
void valueTreeChildAdded (ValueTree&, ValueTree&) override {}
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override {}
void valueTreeChildOrderChanged (ValueTree&, int, int) override {}
void valueTreeParentChanged (ValueTree&) override {}
//============================================================================== //==============================================================================
String getFormattedMetadataString() const noexcept String getFormattedMetadataString() const noexcept
{ {


+ 0
- 1
extras/Projucer/Source/LiveBuildEngine/jucer_CompileEngineClient.cpp View File

@@ -310,7 +310,6 @@ private:
void valueTreeChildAdded (ValueTree&, ValueTree&) override { projectStructureChanged(); } void valueTreeChildAdded (ValueTree&, ValueTree&) override { projectStructureChanged(); }
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override { projectStructureChanged(); } void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override { projectStructureChanged(); }
void valueTreeParentChanged (ValueTree&) override { projectStructureChanged(); } void valueTreeParentChanged (ValueTree&) override { projectStructureChanged(); }
void valueTreeChildOrderChanged (ValueTree&, int, int) override {}
String getGlobalDefs() String getGlobalDefs()
{ {


+ 0
- 2
extras/Projucer/Source/Project/UI/Sidebar/jucer_ExporterTreeItems.h View File

@@ -369,8 +369,6 @@ private:
ValueTree exportersTree; ValueTree exportersTree;
//========================================================================== //==========================================================================
void valueTreePropertyChanged (ValueTree&, const Identifier&) override {}
void valueTreeParentChanged (ValueTree&) override {}
void valueTreeChildAdded (ValueTree& parentTree, ValueTree&) override { refreshIfNeeded (parentTree); } void valueTreeChildAdded (ValueTree& parentTree, ValueTree&) override { refreshIfNeeded (parentTree); }
void valueTreeChildRemoved (ValueTree& parentTree, ValueTree&, int) override { refreshIfNeeded (parentTree); } void valueTreeChildRemoved (ValueTree& parentTree, ValueTree&, int) override { refreshIfNeeded (parentTree); }
void valueTreeChildOrderChanged (ValueTree& parentTree, int, int) override { refreshIfNeeded (parentTree); } void valueTreeChildOrderChanged (ValueTree& parentTree, int, int) override { refreshIfNeeded (parentTree); }


+ 0
- 1
extras/Projucer/Source/Project/UI/Sidebar/jucer_FileTreeItems.h View File

@@ -245,7 +245,6 @@ public:
void valueTreeChildAdded (ValueTree& parentTree, ValueTree&) override { treeChildrenChanged (parentTree); } void valueTreeChildAdded (ValueTree& parentTree, ValueTree&) override { treeChildrenChanged (parentTree); }
void valueTreeChildRemoved (ValueTree& parentTree, ValueTree&, int) override { treeChildrenChanged (parentTree); } void valueTreeChildRemoved (ValueTree& parentTree, ValueTree&, int) override { treeChildrenChanged (parentTree); }
void valueTreeChildOrderChanged (ValueTree& parentTree, int, int) override { treeChildrenChanged (parentTree); } void valueTreeChildOrderChanged (ValueTree& parentTree, int, int) override { treeChildrenChanged (parentTree); }
void valueTreeParentChanged (ValueTree&) override {}
//============================================================================== //==============================================================================
bool mightContainSubItems() override { return item.getNumChildren() > 0; } bool mightContainSubItems() override { return item.getNumChildren() > 0; }


+ 0
- 6
extras/Projucer/Source/Project/UI/Sidebar/jucer_ProjectTreeItemBase.h View File

@@ -66,12 +66,6 @@ struct ProjectTreeItemBase : public JucerTreeViewBase,
refreshSubItems(); refreshSubItems();
} }
void valueTreePropertyChanged (ValueTree&, const Identifier&) override {}
void valueTreeChildAdded (ValueTree&, ValueTree&) override {}
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override {}
void valueTreeChildOrderChanged (ValueTree&, int, int) override {}
void valueTreeParentChanged (ValueTree&) override {}
virtual bool isProjectSettings() const { return false; } virtual bool isProjectSettings() const { return false; }
virtual bool isModulesList() const { return false; } virtual bool isModulesList() const { return false; }


+ 0
- 3
extras/Projucer/Source/Project/UI/jucer_HeaderComponent.h View File

@@ -70,9 +70,6 @@ private:
void timerCallback() override; void timerCallback() override;
//========================================================================== //==========================================================================
void valueTreePropertyChanged (ValueTree&, const Identifier&) override {}
void valueTreeParentChanged (ValueTree&) override {}
void valueTreeChildAdded (ValueTree& parentTree, ValueTree&) override { updateIfNeeded (parentTree); } void valueTreeChildAdded (ValueTree& parentTree, ValueTree&) override { updateIfNeeded (parentTree); }
void valueTreeChildRemoved (ValueTree& parentTree, ValueTree&, int) override { updateIfNeeded (parentTree); } void valueTreeChildRemoved (ValueTree& parentTree, ValueTree&, int) override { updateIfNeeded (parentTree); }
void valueTreeChildOrderChanged (ValueTree& parentTree, int, int) override { updateIfNeeded (parentTree); } void valueTreeChildOrderChanged (ValueTree& parentTree, int, int) override { updateIfNeeded (parentTree); }


+ 0
- 1
extras/Projucer/Source/Project/jucer_Project.cpp View File

@@ -764,7 +764,6 @@ void Project::valueTreePropertyChanged (ValueTree& tree, const Identifier& prope
void Project::valueTreeChildAdded (ValueTree&, ValueTree&) { changed(); } void Project::valueTreeChildAdded (ValueTree&, ValueTree&) { changed(); }
void Project::valueTreeChildRemoved (ValueTree&, ValueTree&, int) { changed(); } void Project::valueTreeChildRemoved (ValueTree&, ValueTree&, int) { changed(); }
void Project::valueTreeChildOrderChanged (ValueTree&, int, int) { changed(); } void Project::valueTreeChildOrderChanged (ValueTree&, int, int) { changed(); }
void Project::valueTreeParentChanged (ValueTree&) {}
//============================================================================== //==============================================================================
bool Project::hasProjectBeenModified() bool Project::hasProjectBeenModified()


+ 0
- 1
extras/Projucer/Source/Project/jucer_Project.h View File

@@ -387,7 +387,6 @@ public:
void valueTreeChildAdded (ValueTree&, ValueTree&) override; void valueTreeChildAdded (ValueTree&, ValueTree&) override;
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override; void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override;
void valueTreeChildOrderChanged (ValueTree&, int, int) override; void valueTreeChildOrderChanged (ValueTree&, int, int) override;
void valueTreeParentChanged (ValueTree&) override;
//============================================================================== //==============================================================================
UndoManager* getUndoManagerFor (const ValueTree&) const { return nullptr; } UndoManager* getUndoManagerFor (const ValueTree&) const { return nullptr; }


+ 0
- 7
modules/juce_audio_processors/utilities/juce_AudioProcessorValueTreeState.cpp View File

@@ -411,19 +411,12 @@ void AudioProcessorValueTreeState::valueTreeChildAdded (ValueTree& parent, Value
setNewState (tree); setNewState (tree);
} }
void AudioProcessorValueTreeState::valueTreeChildRemoved (ValueTree&, ValueTree&, int)
{
}
void AudioProcessorValueTreeState::valueTreeRedirected (ValueTree& v) void AudioProcessorValueTreeState::valueTreeRedirected (ValueTree& v)
{ {
if (v == state) if (v == state)
updateParameterConnectionsToChildTrees(); updateParameterConnectionsToChildTrees();
} }
void AudioProcessorValueTreeState::valueTreeChildOrderChanged (ValueTree&, int, int) {}
void AudioProcessorValueTreeState::valueTreeParentChanged (ValueTree&) {}
bool AudioProcessorValueTreeState::flushParameterValuesToValueTree() bool AudioProcessorValueTreeState::flushParameterValuesToValueTree()
{ {
ScopedLock lock (valueTreeChanging); ScopedLock lock (valueTreeChanging);


+ 0
- 3
modules/juce_audio_processors/utilities/juce_AudioProcessorValueTreeState.h View File

@@ -535,9 +535,6 @@ private:
void valueTreePropertyChanged (ValueTree&, const Identifier&) override; void valueTreePropertyChanged (ValueTree&, const Identifier&) override;
void valueTreeChildAdded (ValueTree&, ValueTree&) override; void valueTreeChildAdded (ValueTree&, ValueTree&) override;
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override;
void valueTreeChildOrderChanged (ValueTree&, int, int) override;
void valueTreeParentChanged (ValueTree&) override;
void valueTreeRedirected (ValueTree&) override; void valueTreeRedirected (ValueTree&) override;
void updateParameterConnectionsToChildTrees(); void updateParameterConnectionsToChildTrees();


+ 0
- 4
modules/juce_data_structures/values/juce_CachedValue.h View File

@@ -197,10 +197,6 @@ private:
Type getTypedValue() const; Type getTypedValue() const;
void valueTreePropertyChanged (ValueTree& changedTree, const Identifier& changedProperty) override; void valueTreePropertyChanged (ValueTree& changedTree, const Identifier& changedProperty) override;
void valueTreeChildAdded (ValueTree&, ValueTree&) override {}
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override {}
void valueTreeChildOrderChanged (ValueTree&, int, int) override {}
void valueTreeParentChanged (ValueTree&) override {}
//============================================================================== //==============================================================================
JUCE_DECLARE_WEAK_REFERENCEABLE (CachedValue) JUCE_DECLARE_WEAK_REFERENCEABLE (CachedValue)


+ 6
- 6
modules/juce_data_structures/values/juce_ValueTree.cpp View File

@@ -1088,12 +1088,12 @@ ValueTree ValueTree::readFromGZIPData (const void* data, size_t numBytes)
return readFromStream (gzipStream); return readFromStream (gzipStream);
} }
void ValueTree::Listener::valueTreePropertyChanged (ValueTree&, const Identifier&) {}
void ValueTree::Listener::valueTreeChildAdded (ValueTree&, ValueTree&) {}
void ValueTree::Listener::valueTreeChildRemoved (ValueTree&, ValueTree&, int) {}
void ValueTree::Listener::valueTreeChildOrderChanged (ValueTree&, int, int) {}
void ValueTree::Listener::valueTreeParentChanged (ValueTree&) {}
void ValueTree::Listener::valueTreeRedirected (ValueTree&) {}
void ValueTree::Listener::valueTreePropertyChanged (ValueTree&, const Identifier&) {}
void ValueTree::Listener::valueTreeChildAdded (ValueTree&, ValueTree&) {}
void ValueTree::Listener::valueTreeChildRemoved (ValueTree&, ValueTree&, int) {}
void ValueTree::Listener::valueTreeChildOrderChanged (ValueTree&, int, int) {}
void ValueTree::Listener::valueTreeParentChanged (ValueTree&) {}
void ValueTree::Listener::valueTreeRedirected (ValueTree&) {}
//============================================================================== //==============================================================================
#if JUCE_UNIT_TESTS #if JUCE_UNIT_TESTS


+ 0
- 2
modules/juce_data_structures/values/juce_ValueTreeSynchroniser.cpp View File

@@ -159,8 +159,6 @@ void ValueTreeSynchroniser::valueTreeChildOrderChanged (ValueTree& parent, int o
stateChanged (m.getData(), m.getDataSize()); stateChanged (m.getData(), m.getDataSize());
} }
void ValueTreeSynchroniser::valueTreeParentChanged (ValueTree&) {} // (No action needed here)
bool ValueTreeSynchroniser::applyChange (ValueTree& root, const void* data, size_t dataSize, UndoManager* undoManager) bool ValueTreeSynchroniser::applyChange (ValueTree& root, const void* data, size_t dataSize, UndoManager* undoManager)
{ {
MemoryInputStream input (data, dataSize, false); MemoryInputStream input (data, dataSize, false);


+ 0
- 1
modules/juce_data_structures/values/juce_ValueTreeSynchroniser.h View File

@@ -91,7 +91,6 @@ private:
void valueTreeChildAdded (ValueTree&, ValueTree&) override; void valueTreeChildAdded (ValueTree&, ValueTree&) override;
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override; void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override;
void valueTreeChildOrderChanged (ValueTree&, int, int) override; void valueTreeChildOrderChanged (ValueTree&, int, int) override;
void valueTreeParentChanged (ValueTree&) override;
JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (ValueTreeSynchroniser) JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (ValueTreeSynchroniser)
}; };


Loading…
Cancel
Save