From c014e1e9a26d98418d861831c166e85b7d82dc14 Mon Sep 17 00:00:00 2001
From: Anthony Nicholls <anthony@juce.com>
Date: Fri, 11 Aug 2023 16:33:37 +0100
Subject: [PATCH] Warnings: Add missing field initialisers warning

---
 extras/Build/CMake/JUCEHelperTargets.cmake                   | 2 ++
 extras/Projucer/Source/ProjectSaving/jucer_ProjectExporter.h | 3 ++-
 modules/juce_core/native/juce_Threads_mac.mm                 | 4 ++--
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/extras/Build/CMake/JUCEHelperTargets.cmake b/extras/Build/CMake/JUCEHelperTargets.cmake
index 16d6ff1dab..6aec8eddae 100644
--- a/extras/Build/CMake/JUCEHelperTargets.cmake
+++ b/extras/Build/CMake/JUCEHelperTargets.cmake
@@ -65,6 +65,7 @@ elseif((CMAKE_CXX_COMPILER_ID STREQUAL "Clang") OR (CMAKE_CXX_COMPILER_ID STREQU
         -Wpedantic
         -Wdeprecated
         -Wfloat-equal
+        -Wmissing-field-initializers
         $<$<OR:$<COMPILE_LANGUAGE:CXX>,$<COMPILE_LANGUAGE:OBJCXX>>:
             -Wzero-as-null-pointer-constant
             -Wunused-private-field
@@ -94,6 +95,7 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
         -Wno-strict-overflow
         -Wshadow
         -Wfloat-equal
+        -Wmissing-field-initializers
         $<$<COMPILE_LANGUAGE:CXX>:
             -Woverloaded-virtual
             -Wreorder
diff --git a/extras/Projucer/Source/ProjectSaving/jucer_ProjectExporter.h b/extras/Projucer/Source/ProjectSaving/jucer_ProjectExporter.h
index 6971a0d9d5..c8d0deefd4 100644
--- a/extras/Projucer/Source/ProjectSaving/jucer_ProjectExporter.h
+++ b/extras/Projucer/Source/ProjectSaving/jucer_ProjectExporter.h
@@ -339,7 +339,8 @@ public:
                     "-Wswitch-enum",
                     "-Wuninitialized",
                     "-Wunreachable-code",
-                    "-Wunused-parameter"
+                    "-Wunused-parameter",
+                    "-Wmissing-field-initializers"
                 };
 
                 result.cpp = {
diff --git a/modules/juce_core/native/juce_Threads_mac.mm b/modules/juce_core/native/juce_Threads_mac.mm
index 1353a14e26..77a7ab9940 100644
--- a/modules/juce_core/native/juce_Threads_mac.mm
+++ b/modules/juce_core/native/juce_Threads_mac.mm
@@ -128,10 +128,10 @@ bool Thread::createNativeThread (Priority priority)
     struct ThreadData
     {
         Thread& thread;
-        std::promise<bool> started;
+        std::promise<bool> started{};
     };
 
-    ThreadData threadData { *this };
+    ThreadData threadData { *this, {} };
 
     threadId = threadHandle = makeThreadHandle (attribute, &threadData, [] (void* userData) -> void*
     {