From b421159be31ecf18f4b1600d3a90e2a34d62aab8 Mon Sep 17 00:00:00 2001 From: ed Date: Mon, 13 Dec 2021 11:49:37 +0000 Subject: [PATCH] Accessibility: Use ignored AccessibilityHandler for slider text boxes to fix keyboard focus/accessible focus sync issue --- modules/juce_gui_basics/lookandfeel/juce_LookAndFeel_V2.cpp | 5 +++++ modules/juce_gui_basics/widgets/juce_Slider.cpp | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/modules/juce_gui_basics/lookandfeel/juce_LookAndFeel_V2.cpp b/modules/juce_gui_basics/lookandfeel/juce_LookAndFeel_V2.cpp index ab2618a989..6295b0a51c 100644 --- a/modules/juce_gui_basics/lookandfeel/juce_LookAndFeel_V2.cpp +++ b/modules/juce_gui_basics/lookandfeel/juce_LookAndFeel_V2.cpp @@ -1598,6 +1598,11 @@ public: SliderLabelComp() : Label ({}, {}) {} void mouseWheelMove (const MouseEvent&, const MouseWheelDetails&) override {} + + std::unique_ptr createAccessibilityHandler() override + { + return createIgnoredAccessibilityHandler (*this); + } }; Label* LookAndFeel_V2::createSliderTextBox (Slider& slider) diff --git a/modules/juce_gui_basics/widgets/juce_Slider.cpp b/modules/juce_gui_basics/widgets/juce_Slider.cpp index 6bf81244e4..18c41641b6 100644 --- a/modules/juce_gui_basics/widgets/juce_Slider.cpp +++ b/modules/juce_gui_basics/widgets/juce_Slider.cpp @@ -567,7 +567,6 @@ public: owner.addAndMakeVisible (valueBox.get()); valueBox->setWantsKeyboardFocus (false); - valueBox->setAccessible (false); valueBox->setText (previousTextBoxContent, dontSendNotification); valueBox->setTooltip (owner.getTooltip()); updateTextBoxEnablement();