From a1337a386317d13acf6843cb69179dce4d8084f7 Mon Sep 17 00:00:00 2001 From: ed Date: Thu, 22 Apr 2021 11:58:14 +0100 Subject: [PATCH] VST3: Workaround incorrect VST3 editor ref-count bug in Adobe Audition Audition incorrectly increments the ref-count of the IPlugView* returned from IEditController::createView() and never fully releases it. This commit reverts e0306d25 for Audition to ensure that an editor is always returned, otherwise Audition displays a blank GUI. --- modules/juce_audio_plugin_client/VST3/juce_VST3_Wrapper.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/juce_audio_plugin_client/VST3/juce_VST3_Wrapper.cpp b/modules/juce_audio_plugin_client/VST3/juce_VST3_Wrapper.cpp index fbc602bf74..bb2ae65355 100644 --- a/modules/juce_audio_plugin_client/VST3/juce_VST3_Wrapper.cpp +++ b/modules/juce_audio_plugin_client/VST3/juce_VST3_Wrapper.cpp @@ -1154,7 +1154,7 @@ public: const auto mayCreateEditor = pluginInstance->hasEditor() && name != nullptr && std::strcmp (name, Vst::ViewType::kEditor) == 0 - && pluginInstance->getActiveEditor() == nullptr; + && (pluginInstance->getActiveEditor() == nullptr || getHostType().isAdobeAudition()); if (mayCreateEditor) return new JuceVST3Editor (*this, *pluginInstance);