Browse Source

Removed a couple of superfluous methods from AudioProcessor.

tags/2021-05-28
jules 11 years ago
parent
commit
95b4198e2c
4 changed files with 6 additions and 38 deletions
  1. +2
    -3
      modules/juce_audio_plugin_client/VST/juce_VST_Wrapper.cpp
  2. +4
    -7
      modules/juce_audio_plugin_client/VST3/juce_VST3_Wrapper.cpp
  3. +0
    -22
      modules/juce_audio_processors/processors/juce_AudioProcessor.cpp
  4. +0
    -6
      modules/juce_audio_processors/processors/juce_AudioProcessor.h

+ 2
- 3
modules/juce_audio_plugin_client/VST/juce_VST_Wrapper.cpp View File

@@ -851,10 +851,9 @@ public:
{
jassert (isPositiveAndBelow (index, filter->getNumParameters()));
float value;
if (filter->valueFromString (index, text, value))
if (AudioProcessorParameter* p = filter->getParameters()[index])
{
filter->setParameter (index, value);
filter->setParameter (index, p->getValueForText (String::fromUTF8 (text)));
return true;
}
}


+ 4
- 7
modules/juce_audio_plugin_client/VST3/juce_VST3_Wrapper.cpp View File

@@ -197,10 +197,8 @@ public:
void toString (Vst::ParamValue value, Vst::String128 result) const override
{
String text;
if (owner.stringFromValue (paramIndex, value, 128, text))
toString128 (result, text);
if (AudioProcessorParameter* p = owner.getParameters()[paramIndex])
toString128 (result, p->getText (value, 128));
else
// remain backward-compatible with old JUCE code
toString128 (result, owner.getParameterText (paramIndex, 128));
@@ -208,10 +206,9 @@ public:
bool fromString (const Vst::TChar* text, Vst::ParamValue& valueNormalized) const override
{
float value;
if (owner.valueFromString (paramIndex, getStringFromVstTChars (text), value))
if (AudioProcessorParameter* p = owner.getParameters()[paramIndex])
{
valueNormalized = value;
valueNormalized = p->getValueForText (getStringFromVstTChars (text));
return true;
}


+ 0
- 22
modules/juce_audio_processors/processors/juce_AudioProcessor.cpp View File

@@ -397,28 +397,6 @@ XmlElement* AudioProcessor::getXmlFromBinary (const void* data, const int sizeIn
return nullptr;
}
bool AudioProcessor::valueFromString (int index, const String& text, float& value) const
{
if (AudioProcessorParameter* p = managedParameters[index])
{
value = p->getValueForText (text);
return true;
}
return false;
}
bool AudioProcessor::stringFromValue (int index, float value, int maxLen, String& result) const
{
if (AudioProcessorParameter* p = managedParameters[index])
{
result = p->getText (value, maxLen);
return true;
}
return false;
}
//==============================================================================
void AudioProcessorListener::audioProcessorParameterChangeGestureBegin (AudioProcessor*, int) {}
void AudioProcessorListener::audioProcessorParameterChangeGestureEnd (AudioProcessor*, int) {}


+ 0
- 6
modules/juce_audio_processors/processors/juce_AudioProcessor.h View File

@@ -663,12 +663,6 @@ public:
/** @internal */
static void JUCE_CALLTYPE setTypeOfNextNewPlugin (WrapperType);
/** @internal */
bool valueFromString (int parameterIndex, const String& text, float& value) const;
/** @internal */
bool stringFromValue (int index, float value, int maxLen, String& result) const;
protected:
/** @internal */
AudioPlayHead* playHead;


Loading…
Cancel
Save