From 920c3f24c8c07069aa4c4a4f8c225cd5102ef57a Mon Sep 17 00:00:00 2001
From: tpoole <thomas.poole@roli.com>
Date: Tue, 26 Sep 2017 11:16:35 +0100
Subject: [PATCH] UnitTestRunner:  Improved logging on Windows

---
 extras/UnitTestRunner/Source/Main.cpp              | 8 ++++----
 modules/juce_core/text/juce_CharacterFunctions.cpp | 5 +++--
 modules/juce_core/text/juce_CharacterFunctions.h   | 2 +-
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/extras/UnitTestRunner/Source/Main.cpp b/extras/UnitTestRunner/Source/Main.cpp
index 52c20bb464..41511a3c7d 100644
--- a/extras/UnitTestRunner/Source/Main.cpp
+++ b/extras/UnitTestRunner/Source/Main.cpp
@@ -32,6 +32,10 @@ class ConsoleLogger : public Logger
     void logMessage (const String& message) override
     {
         std::cout << message << std::endl;
+
+       #if JUCE_WINDOWS
+        Logger::outputDebugString (message);
+       #endif
     }
 };
 
@@ -47,17 +51,13 @@ class ConsoleUnitTestRunner : public UnitTestRunner
 //==============================================================================
 int main()
 {
-   #if ! JUCE_DEBUG
     ConsoleLogger logger;
     Logger::setCurrentLogger (&logger);
-   #endif
 
     ConsoleUnitTestRunner runner;
     runner.runAllTests();
 
-   #if ! JUCE_DEBUG
     Logger::setCurrentLogger (nullptr);
-   #endif
 
     for (int i = 0; i < runner.getNumResults(); ++i)
         if (runner.getResult(i)->failures > 0)
diff --git a/modules/juce_core/text/juce_CharacterFunctions.cpp b/modules/juce_core/text/juce_CharacterFunctions.cpp
index 9c10e8c38f..a933be477c 100644
--- a/modules/juce_core/text/juce_CharacterFunctions.cpp
+++ b/modules/juce_core/text/juce_CharacterFunctions.cpp
@@ -241,12 +241,13 @@ public:
             STRING_DOUBLE_PAIR_COMBOS (2087.3087e+00006),
             STRING_DOUBLE_PAIR_COMBOS (6.0872e-00006),
 
-            // Too many sig figs
+            // Too many sig figs. The parsing routine on MinGW gets the last
+            // significant figure wrong.
             STRING_DOUBLE_PAIR_COMBOS (1.23456789012345678901234567890),
             STRING_DOUBLE_PAIR_COMBOS (1.23456789012345678901234567890e-111)
 
+            // Limits. DBL_MAX may not exist on Linux.
            #if ! JUCE_LINUX
-            // Limits
           , STRING_DOUBLE_PAIR (DBL_MAX),
             STRING_DOUBLE_PAIR (-DBL_MAX),
             STRING_DOUBLE_PAIR (DBL_MIN)
diff --git a/modules/juce_core/text/juce_CharacterFunctions.h b/modules/juce_core/text/juce_CharacterFunctions.h
index 2180d54dff..8acdced644 100644
--- a/modules/juce_core/text/juce_CharacterFunctions.h
+++ b/modules/juce_core/text/juce_CharacterFunctions.h
@@ -188,7 +188,7 @@ public:
         int exponent = 0, decPointIndex = 0, digit = 0;
         int lastDigit = 0, numSignificantDigits = 0;
         bool digitsFound = false;
-        JUCE_CONSTEXPR const int maxSignificantDigits = 15 + 2;
+        JUCE_CONSTEXPR const int maxSignificantDigits = 17 + 1;
 
         for (;;)
         {