From 7c45ad695c9d493b86b969e691dfa63e7e76d52d Mon Sep 17 00:00:00 2001 From: Tom Poole Date: Thu, 4 Apr 2019 18:03:34 +0100 Subject: [PATCH] MacOS: Better support for SystemTrayIconComponent on Mojave --- BREAKING-CHANGES.txt | 27 +++ examples/Assets/juce_icon_template.png | Bin 0 -> 18827 bytes examples/DemoRunner/Source/Main.cpp | 3 +- .../native/juce_mac_MainMenu.mm | 4 + .../misc/juce_SystemTrayIconComponent.h | 17 +- .../native/juce_linux_X11_SystemTrayIcon.cpp | 6 +- .../native/juce_mac_SystemTrayIcon.cpp | 210 ++++++++---------- .../native/juce_win32_SystemTrayIcon.cpp | 6 +- 8 files changed, 146 insertions(+), 127 deletions(-) create mode 100644 examples/Assets/juce_icon_template.png diff --git a/BREAKING-CHANGES.txt b/BREAKING-CHANGES.txt index 40ee99eac6..9d3bde58fc 100644 --- a/BREAKING-CHANGES.txt +++ b/BREAKING-CHANGES.txt @@ -4,6 +4,33 @@ JUCE breaking changes Develop ======= +Change +------ +SystemTrayIconComponent::setIconImage now takes two arguments, rather than one. +The new argument is a template image for use on macOS where all non-transparent +regions will render in a monochrome colour determined dynamically by the +operating system. + +Possible Issues +--------------- +You will now need to provide two images to display a SystemTrayIconComponent +and the SystemTrayIconComponent will have a different appearance on macOS. + +Workaround +---------- +If you are not targeting macOS then you can provide an empty image, `{}`, for +the second argument. If you are targeting macOS then you will likely need to +design a new monochrome icon. + +Rationale +--------- +The introduction of "Dark Mode" in macOS 10.14 means that menu bar icons must +support several different colours and highlight modes to retain the same +appearance as the native Apple icons. Doing this correctly without delegating +the behaviour to the operating system is extremely cumbersome, and the APIs we +were previously using to interact with menu bar items have been deprecated. + + Change ------ The AudioBlock class now differentiates between const and non-const data. diff --git a/examples/Assets/juce_icon_template.png b/examples/Assets/juce_icon_template.png new file mode 100644 index 0000000000000000000000000000000000000000..e2964f1c3435da578d24b3940167d51b05d8914f GIT binary patch literal 18827 zcmdSB`9BoU_dh<1U6vs!yHR9`MD{H^m0gsbNZI$D5!u&Llr51xOUcemS&M9mv5#HW zK^W_Nuh;AQ{(L{*$LBBj_yvzS_uO;OIrrRi?s?vc)zi_Sp<)k)~n-kpHD6OqHznTa%v zgo8asgY4`K>Q8T)B`A$}ShSfKtNGiRYMp9bf_}G3CydWpyR*5phE0%!19AyQO*Ut_ zt{o9$q(q9+l<`8fklTt_`&pBFPtz1}Hfg)lx%0UnE6Jsa@}+hfs9c@1GqWa!W69V4 z71{qPmd@#*3O7Sp(Y4z>6k~V_0g~lQ(h?YP);LJ{?=bt3gz@EMQ*OK#LgtA4o*zzr! zl9|()!_DJ!c<9GaR1kz12SE(yi2H?obvVRE2Qh(~*w$SbS-7upRgnoYOLSaM zZxvpvYxBas4i_Z1eLC%}x&!#Sh*A3sx(oR}4GW(3zWU`h_S5sbsGjQ73u>wb+=cKW z*r-k0@V?+hmG(#Lm!+BHce#-UlkX)l>_Ua zioO00(NksjOi`6ZwI8C%=uFy7?$0UF8fw;z`qf@XvQ|LWKU|lU-oJ2w^hF1qJ|tSV zJ%n}b?mQ%s>{#NzEH{tycJ};mBm9Tf=x57IkQp*zOl^y1wGl+~2Q5?wKCSbGV`+{2 z5|nOtXY3zGhr`g?y_RF;3X)N=w?2j!-F`J*xgh)HiYuM7%9ruX+nA4F&8$0xNQOc! zzJi)Iaa@aO7uspb-1dh3)IEQ6*R*jMB$MAwt+Uwxdy&=r>88?pZ{rojlgGV1Z7sl9 z?9S7$RAezE#h{l|r%QM@UBYGaQTeNtUe^OFY=U3BC$BNjgtgeU&2NokjD8)i8flNE zeS>gRrFdcF{y*pebQ#V`vahC_8l4g8(nM!Fv7_KTu{4dIQWf#- z^RmB(a<|vT$jlVcbV_Eo(R5nctGr&d$4ZGk!c+i z6C>WKiaW(9??_Izbv!HIJ>*;GRy}R(f5K2pcSbqESN0<;_yRL^wOx>H91XBuDF==R zGr!VggvNvK4O|hXgR#7w=J1v*D`sPU zaY1ofruwohv$vCyDvJx7`z?v8`z|orFsLUTTRnr%OA*^W2$JaCM zx->14M&Uyh6)~DDvM}bCbqI?K!Ld8h7v8LH#IegZeH))2q3iq1AuC%4^vR`zFZW&#^lZ zU1wuNlq8zi@l-E5Ufd$nQRCUs^5M1Vnw(mYUUK{1CyhvTE`%&wf0;5KgX}|1pwUHE z9qYVyUl!P*%~$;4Rdg(6?}cf*k~&J==*m0#khf9@ z6}vZ->_M8W4d+^^GQ{X*VP=W=h9Fc=co_MatVfc{7>(2=fB84WB@BtPM6(9DXQ1Q2 zOf+i74!$k^%N6q$d+lhON%%k?r-EINKq9qVsLi#%qJ7`MmknI1Q-88K`_}i{W*;ce z70Fmq2UBM}9F$?BIFY+Ks(_=zRxXLawmK>t#qIA!jbW=F?KwuI+b$QzXfhN*dWtLb zgE*uzS7jvJDls`+L?OHw?#hsBr3PyBs(G#lCSA*`A&ADE9PfsCYN~&ed$zGaf>G8t zx2SQ~{)%r>Tul8KM-WZv&m^K3=8|!FR(>`LO>!oJhx~D={I(6-Z${PqLghYa7A`|s z+38Mm()4OpS(dnjv-cQZf{j`)m&a(P(dk*te}y@%-~CIdBh&fbnbyB|G_SWU)EdE= z2(S3`EpQL&XWO6C9Pydz`Hd>OAksh1Wy@7wCaRBz9iS!#_wBxt5qS5|(b7<R^A(Pd@m{1TWrgiA zSXhBZTW*&ToCThgCutBKe2GSgILd5qjA z@nS+dZ?%WsA0526Zd1zn%1zU*l2&y8?~yrNuA@`inV7BI5(edr%cd@=)8O=V)h&1U zs#sR=L&7vXdzXbmr=Y_DrpO(VA9P#7z}#XzvL(MI=7il~wVuyb_VfeUVNrrT z7NT95h*jrbf1WK?GD_r2lkJR(QN=Q|O7YsmcPZSBj0I~Dj3~zNwc>-{$J5)&?Gin= z*DR9i83|6SJ}*|Umr83Ke0ugm^(xv>>)72)1aG{$eRba#oASkY((02_q@0^*lrNKZ zwm*VETNQ?pxN9TeE8IcLEN@WWK2CyoS`~}E)}KbRB9ArQZeS-dSKSk18WB~F8qU^> zX!h!IL!sY~{|Jfl;_`L(yz|f~Px2K&2X2@H(n>ekZ+boiHhGR=Z5%*({ZvGvqUeJT$7)5N` z=-oK0henxQYxgmUIL>QmpPVS=<)lLfWhTF$&- zSM4S8XRXPpx>iM%N*r2`@=nBMFC70-WG7s#^5&5i5Hf-k#9HEPhjhL*i@Pjd{)^cwcuMa{%P(_9irVy6TriUWq%`Jkw+Vd_$M@sF)xE%imt4ne z*aaXv?bH}WXl9bV=V_7gi4E89m9grcA0dP2h27 z_@mqUh0m8Zs8UyCWGO~d-43;@`P=aqd7*KgfHPT^%F)|_@yh~`RYV=6lJl32`^`k} zI+8vWF{-%7qDkVFhkLNx_v4JmsyL73J-u?UxV^Y7n3)e+@I&IazP}euC`GuOD<~0^ z;v7Ll?D1nu7~8|y!1W8}nbz_bMd$!|{6`G2VEj%^($!yrHOz*|hYYGLZVc{BXMEf2 zm@KN%+1~~1zs;+KjUdC4u6g5pYs=QljR%3|FS19GFS{=eUBK^JILn<1u#rsWTC-nl zi>5*aYKTar=o-6G|Fd3h2BgVf^^tSVGG~mae^AcK>%4$!*!pbr%!I>pzCD%G7g{NNKKdQd%`e^4TMM&q`{!W>EY4ZL~u zL`mqt%~bVqGGbmxZl`cZ(MZJo+;`6sJk|UF-)8^I{%z_9FOwsxB)*9eNlhoNA;TSJ zXAVW$$tJX1wn!QTzXKb*9gI#))bD6F+r@K=J3<>7xELPGoTZK7uy#+PJ)U zvMHHg2Ul&pMM>28XFep!<_630=rfyT6o9;AROCK2ZWcAooPB$+=a>aaMI?5GrR4VW z_64xHO9T#7_JJil+`jIP!#DN)dXl}{N|ku|`mF*F0^L^T5j)WZ#hUH)fBTj9@VH`-dcI zmUGe{-9+3y=Yn;WfA7D!2!vv%g9XvHuuf$qY+cV;zSd__K=B0UXYh&pbS0GU{cP}E z;9b9x?J)`}n_7x|wk`=KeNV0es*&k9t0#>NQoJ6mm1LIQKTY&4iXn~~LcFIdL0vdW zZ+8*=oA$%F;h|OxH6csWNpt2fxua0{*HkyZI;Q|+oYCaMSFvpNh?&i(8b*V?^-0ZWFzq(lu@n zm~y}U#_-mdaAo-O(C1&Pkzc)K6v&TAjrpcO#$rA#xGh}F2cEVO^9Oj^MlTCNSYgdS z@K0>Kw;i1|={7lmT}ij2A-Pj9Jo?8BmcJ1Mv5gostEcXW3f)L;N5wo<`6s55L@kU( zJLlwGlr+;ahwT%b=#Hd++$Pw`yYna92evJ}-^S~)J}uNvUTV)~<>u&CElaa8JR^PQ z^#I`_D`5JIwlY<{%>C-fNJqtPfH9x&tu!8dz|TF-GM&lrIMgk`%PYU24?WKrYqh0N zzQOdv;gZBX*Y$65xt_VM#t1zk@TT7D)w|?QYfFsiv-m0r)2s1De}yhHGZ9_qpsNG96{TspsCK4PjV-%QPJ z%VBQEdNKyQHH=X-HI!@q%;+AXBv`X}91UznVP>ei6{0zL?LKS|o# zU;bW*_VYH zPh2pMZWi|G(;`9H#VAT`ednmz_PoAdrIXFd#soc70Y}1Yh;S=;u0BC#JEUt8Gp?S@ z{U_O@@9ra4DhW=X-aCKgV>=`;bKO~`&-}&xl%_%0w;XQS-D;naTB1;RRVuH1!ukj) zA{|X&T)fZ~+zFMGSunDP7YITR!4e+oYcJ0vw@ACcx2v#rv3IsymRi1g<16#_0oIMI zQ)bEA_pw3)3(|tJ8=MnAV_(V;b>ygey?XQ#_wsVVK9pQXUrw%T>KL*gC%$~O{z{N?QmE_gAmbrQR+)fMaj@0VIgYqA-?lE|oM zUkoV@OPf6Oo8x2y4k~Ns67h3r0TB)1RRR>!S@QICM~`W+uF&&2Msk5ZQ3Nc{2S+DKu%_oDI~ zZM_D*?0FE1H1%+}W!3?9COr?P7-+}3K9aX^e zxzZJUm_Mn9lj~W@;=QslvX}?(O3$D6hPZFt!P?FPMkMElZJ=retBjO#QwGiI0`dp!NA_|72AR2dt}LK^b$N5J$@pY366x>$>t%8-zN? zL!UNat%&JTOP(%|g?*@)pnG8IKT$HoynMQu*+G%mUJVoIqY83URRXkztVwlawmn8} zl|=xyiU5f?wa*z(S2l)MXTpJFge-dLGld1IyiT|8bTPQ?`6;OsA@ z^f{Y)u`IIXrnsxivn z=`xnXZ)ABk$RU%5lq)Hgz?%LlXNQ^ogNCiv{Hn!_FASJpvJH7&)4tu#-kj_8b3Ub8 zPWuAb01Duc1(JGrt48ygqp$~G=BPLNiR!{Y z&A@BaKQJlZ@L^GG2WFw$Weg!^;Vv?wp{Ww`8XsYI`{o39^bZUpB0yZ!h@=2iU)y%Zi?I$^9xL)-Jw|9MoB!Det5r>*2fZ(QFd%H|k4+Z}k4V zfjA>pPnzQUqg-)&Y#eX9xOD zF>;|RX%UZWnLKn~I+pY*dczp zA1iK@iWE6yywVH!JRmAZBLh9~%pEqT)swb4t#u8=G|7SQf*s@B^mmy)Zt@bWedHEiL`En~*4jmt zHZB!7^7)3_sLt168eNDgK z;$2*H_y?B?@0TH?t!c^6u zLMuudgA_6%xxncn0vSF`=hX1|`b51}dbTcV)HWo3c+v_Hnqo0qb&?&!>aUCdDve5# zUdX18S-vddoA-1S{65yR4%TU-!6stP=M`4Gj4Zq3$95 zHivF;rmf#4y{}nY)OeiJmh=%bHb%A6ZJ{EslVLKpF%IK zITbk2f{ob-Ms0y7{4exw1m&OPxzP82#R$59vVB7PK?m zPqR={2fM3WmtfJ>YN!Q2Zr`&#nUI+v)b7&<$JmQzFgJHXPCSo7P)*xT#~3`)*sCo3 z7cyO*(Uh@1Sj}f}qz?Wrm{bXUGQm8U|E9_=FhrE6w$H;f)c1ZvJCm2zigxs3Q1czGKbk(WIFF*OSDP!J!-8C* z`a=jAwKMY)kx~tjcx_kLh0jGWL7q32-Ha}c3;sK-rO zQ*EqHGthn)xv*KP; zn+M9i7iwG=VK;-3%LMoL!xSai*Mj0kBH_f8n0`yvhIL9zCJ$O=M_ZqSEiMk?wt8Y8 z;^s$4%22@31J5idqil-&!ji$zu&x46|5R)xe(0<8w+`YxW+iGgi9SoBx%nDD3a#`t zZB@OjLBOLWrG<#Q;XMzA#oj$4Ni&BO@0uiBl%?M)#Mmp|o$ZIFg&wZyQgF5}E3&@{ zi){1L3|V3N7C2}hHg-8#LaIgtdtogi&iE+S-M#&ZTY~xi2&N2(x2i!$HWDEd_P3Lj zy_IL_nfpD?tEs}g>qEb^tqm4F>r$E5en@Z}+CUAtLRUVcKTP;15ylRA5ejea_GZBt z_`TVDlaGlr)PO9@@#iG;+W8)2%1>0}v0U+jB+CfNX1)}Oc9Es$wiO{pSVEt|TaczV zEcVmsqosp2R+7J)Fig|go9x6^hqXTmyV9_pjWSUUjZV9xrgVGw@b2|wK?u>R{fXVt zhjMKNX=TYkMSNzreGr?w0WA~sX~}N-A1}pD7SS4V8JE3%px3$Kb4Q823oH- z8R(`-V`?z{otGfsjvkugYkO@CCGWKz70jgter`81uTvKeLU;GyJv1U| z*IyQyrgaDAZO!X0gM7@nna3J*!`*M;b9~DTPlXXlBp~4L@0MYuzKGn%& z3pPeq)Rt2sbx99#Q)cz#+DB|{z_k&LNQ#YDp9S{X$K>%|b+SUoy6mkg??8z41B-da zVe&-fIA%bBzl=dQ=RRdF>{cx#1MbXm$UY2o}1Q8D}s@StEFp7yqS^ zC{j{ParvE0SjkVP7)9YTLA;k;Rcp!hYdNZ->5nd{3OB7ZAO6Od~;nt8?}2G;rupZ(%bn#FVDAo+b(o>-op-FOO4{s$%yftww5;I5o#x-X_PQ`obH@5hHvYABhoA3x>=TpXeFLC1NX z*K&;VBIJb<%r}M88d|RA)-pkXGD@vTE&m4#APGDn?-h(mQZ@J~-^d6i4b!hc-{5R< zmQL@&4+CmpZ>GXt-H}y3j^j7wG)@@OsmQo1R85KzPR&iDR=RBlq&w=N$Bq!yk_ z^)bnIVwEWpeM>>sbL_RihAQ<`J)NwOnF*v_#V`)yb7o+|;o{?%i#X!B9Y3T~I{?F_ zb}#CX)h3+KrX~r*ql_^uMT_3WyXi8!^^cAnam(JMTzLbl0^U!2S9Z|;Wu+7ZsLg?x ziP%4TJ;2S6!vvxnCca9gq&z_uDqIV>{;Wt_)ZikN+$Q_q7OEe@nLub23kc94h5#*` zE;hsH$2IH`$E}ZFOK=AZOk-j1>z{Ibyv%puWN+1!lT62(z=0w{TuEukIbao@N0xfa zB7dDF==;@zH5_xRrAJIYC7Sx$YYRXe5DGNz>sOToc@#x%F>E0*zgyt5TG{9ViR^lq zwFhpw(>lc1IoB}ur4Hs3QsMY9aCYol1M#g1sLw~>L{&07ySl2u5`~qeMp}F}z3Pc$ zZ>`a&)%~7(?~4AOyFkfz?YW6yCdh5ZBbI4uIAUH6Cz(3KJ(O5@>0HwSbqIx*RvP!v z`n`hl*Rm7x=pdaBp0g`@9&w~5K7Dj zLdVjSv(ZKy0XS?p+EV$L)&i<&{S3D(M-4$WRi_T-c%E6NrZ(r^;t(FEA^81#W>(`YdBNYHH%xP_(L4$8lFO`eCx*q=g*#{b6Oq=tdk{I1*ak=pO5 z-@B43bZmm3Le|PuOH?lk#K0lXk;W`jc?v!2u?`@Bl~!<}1r zYN6Kp1FIY+R|?VOs)1;RkSeK4{9_dlu1)*2T?f$)B;%?vjm>7#R#hG61B+RT_R%6$ zT2Z?Gu0vN2{BXIPl&l7ve7`-Ry7}4Z7teJoS#^L=h8;A@nwA9zKBg z!@?l0aM$k+R`)+u7!EY?mp~{!l^XQ-dfyzuvd6N>YRzYa``@-Vw>*)+GdH|S>3jq~ zArXvoyH}sp$qczR1uLFlLb;$0F*K(0<$YEL<4o9Vehd~^HYrg*h9SrKYKa4~a++!0 zK~JF2OJ3CPX-F{_M}>ONFcz3W%2u<-*F_-73p&aL4oPI2?chR8=ow_GcD=6+DuKhiwr;@j~SLoHM zt9UPt^mRU{n=b)`fxq5oAJ2BIz?oDs?x8coIPM2Z3oh@AH9y)FYwAQ=>C$5^e0-W6 z77Yl7Lfeyx48PsdZrMK3Ck6Fw?v#M%*e+60ny38Cec0?JyXm`C3^NwU}**1OI}r0Fbg?e!2%omFe{$>+K-tURr5 z4EQU!I@6?y4qhoGHB`aA^1`ypal*AUQ5%!g&31wE!OnDKdXomulPPZ2_D1WgCARoq zFKf>{ZFBeu`++li8o{~ISE89NH5|P75Kt}aadyqU!B17V&fuB_6ovnxXB*aV;(W1Z$ z`sBt}2Nd#)`J3(vLX^wOTw=lm{^fz3smUkwFzEjJtFqlKJp`8z)5L=V>kxGc5HeS0 zG5v{9-#GKy3W#QL;mLoEn~#NA^Og5gY)5z7o0QhTaN#lieTnA#A>erTeKsya+$*6- zX>3s3*%b}xh)C_JFnUUgv9%7sJ+Y%k1p$R`{Qi5Ax!)5O0;JLbNBBUit@MZnQ+^E$ z@?EeznPGnxBioKWS9*D zY=9s`0c4LLB=K5MRBJ4Jc8dimnc)NnVeJiY@kh?A?Bg2$7>RhBMQtI7<<;P-7cD&L zr}VRi40px8?){fdsSx+sos9v7IlA_KMZE?FY6u0opV170s(^LNxP;*<&47}qI9$9O zIrSHIZ9ZOt!`UwKT@_CM-fwXD&=}tPp=Oyj6zeGbKs8Ce$Byy~T zu~TIFsT3*g;dSAEm|Qw0=-kGga+f5;xTM_Oy!`ezk046^9beIHpWQqOwEXeH$HxW; zt{gdV0S8iUE25q+ls*vs8-OJ`0GXzb0GI@E< z4Ss^$*)^c`IeS_{K~GohvJ+}LLyxQx`B{-j3c;))(>FZOTC2L*VYiJ)G%qACf3`g$ zVS-$dBRdhre+gTvI$>pNRaw2Odu(!74Hen=Z5E^ik&3n<`l;H&5U%E(z#H3e*r^bh z!zyIuDUl6uiNV(TGmP*>Uf&;8OtXTV2;jXKW5ZZ+EZ_OAy*ye~L7#Ym<>U`0f9(+6 z?>dSE34z{?G)qXk++l$G!e?fO)@;fIYr$V&meT0IFc{L41S<#^Af~?BrI}$vminyIET>veDSwyjAb9F!!`jYHRlu zUzDvo8+ull{p&G2z2%~8XaSip_X*cKP+^x~euBH7(q!J5T`R?RMv#B`NF|%aQA zI0d`R*2q54XBzRfL9`HYb~N)H%&Tr#0lZa3l0)j2=a_DOTvea<82YXEwfET--^M2| zYcQN0S=mjWJTrje=VSU?+iVUkv*QUv_CyCm#DD_F@=i4(w`IuYaL!o{FJzPM{RS?d z+LJ4Xmv0bB<{wcL!EdJej$eQ63A7}BcnO0W*g*NVdzODn98~c)I~AHWp?y}QWda$Y zKYP6N7#GvMh=!Ph`f#pjw}+^h)vAj=S-Won8=pNN;z2U2)_&X6>NmxG0SMRTP=YI5 zTtmdS-zqz-shGl1Az4DA@YCobkp%>;SK0lDFji|uYkk}flfvLg(P?yi?c{$|&}*t1 zjF^r{h%wRP`BTEvvshfkiLOcoUN5 zt0WZK6HRB3q*AZ(+PerJ${3f z9*UV+D{s>?-$=#y_m`!cWr>my!Dm&L{K}-59#Hu|tiI%Q*Diz~N&aj9(ffHo9lss0 zxAp;CD65?FUdF`VHmx+ugITxfA@p?2#p6zIX5FunkQXOUUjANS`w9gvZ2$ewH85+` z0heO*;CdgLlL^xH0yL)Q-Vd%v+BDy=J?yD!Ri*mp^W86ar5Uz%Yyoa}eP&O4h}O>c zwkOwK%NRi}fZNtpb~NkM66eTmgmmx}Klu-9MKFN#<|ucxpT@%bD*Wb&m2QxOs}b}j zXblv*`Dg8V#j<9&C`Pkg%@3lOIkfULJ^Rmn_&CROHt|kmGO49)F$C)mh^^!j`c2tH z>4;PFRlz^j!A(0Pr*rwNKN|EIy!>Z&73nko@gD>lUjgYExF+9=qe~2Z1k32Z&!U(p*4Vu z^36`^NCyicqicZ!5g*M>Q}9b0LBRDl$wG26smouQDfZMhx@^xBmh;BL&UxdZt?*@U zi02=9V5$(u178#9%_BWTipU#V7yI%yo?R&{xFt^|jpV$b==*cl5FuT|4JZ{qPGyHF z3P6;BNplEBD`b}a#t3O4_n&v3EqH_8hk~_aG+QD3E^^1w)8FqbDBoo&nF^HwOzI-^ z?Md(HR7}v`mUlE;fkPqU;Ar$vCm@R{RmBi=t7oYF3(3}uqtB6e0t&4v zyxfS1COqT?9{#`gb#4GzLvr1hd;T@H+JQl`{U8|dU!vvNw3eUXPd-pv(m!8l(}(akQJ|^V z3NE%4&u;nh&`QbPN^Z;ANqN@olB137&94E1EJKq=0W}-w@u>}a9B`JKM^ar+&0ONYcH{-fCH1pX7`z7!Px`RmpyBDb)Zz@N$#HaGTfYSK zx4}jJu|HcbWf*20mtn3j2V^gfuIK9>#rX~8UQX3u&u8{e{#^^j(h|0SJWumr?;Fos zEmxVzQc!xdp5M;in=bR;E-mGj)!CQuXb@+vMS-S}iW;WdBU==^@_LB*+6&+ z%T%sYnF8x<)k9PXZ+4AK&=sjI&D}mgiFf~KXE)M?{?7K4j;Vi0T}BJ^;)H7jQZNGg zX+4DXM%x{oHN|Yg-&S4UpK2_R+1y1u$VbxIccn#cr3>h~_VXYcHZAkBK{6+KS_9~;kHZ-h^NDf?+i%fBEITdD*R3P zEz7=}dZ{tC9`4Rm)nupO_My=P-XcpZX-7MhTm~J&>pa>bu%oKlA3dAxiU;1W>=cF! zf}l>Zvh;49Tc0mu#!?Tx8Tn<1Ru59@K%WctKI?h|h17)TR&_g3&y>1(T$Jx=wO5Sd zoj&*8Cv5KdDmrZ-xGRzp)V>EZokLDPe`rVI)Pti(6SK3wayorcGrz}uCO^zXn5M## zW&R#Ne!RbV!uP7yR6ha4j-T-_<4}B6wcS0Nre;@O{pMNurs&~&VVkeVf}o=kaDCg( zj_%xX40l=@-d6#AI;825ly~|S&%~OtUdbF4O_GjnUND%W)9HU(jgfIqE{QOiJ#KfV zb8k_xjH?F&TnnzlTDQ_B9-ZV?DUNbi-p%%62>4Npxiv>Spnyy43t*>fzMT5IjX?WI zoRZKV6MQigta=?U4C{mt?@cC0Eu-qBmPkf;J6oq}E;!|@y_9}Icom4a*&|&kfB6(A z(}Iz#(m!mz2dlVZ&k^Sh2A_bz5K9g0;{F;cJIm|s3lOCz{$5;eR*hO1{Ps&XW%M$R zWZkDJwe;^Ycs=3kV|k{EE8-C{(GLM|O?4n}r_Dx3V#1_lIW!c;HrsrXbjTyrG*Qp1 z@0uvV>j!%=&XL)q;M<8NQl8`zyrXJpd>@7}I}c@Bu73)bt%ljW-reDaq{B62!YbPv zSp2;(%e=U-1kJ3js_4y2yoAk%A|o#HPLJeX+juM1C3WsWsisLYhvi${w{>=%@bpyl9V3wFK;B)s#tgN?A8x13 z**r_tmxks32so==ZRc@;nJb?~>4|y*MYyItA_;y@@Y&*-Qi(<8&xxYcL>A?g>L}e2 zhpb8+o#2%Hl3#h|K>k1Lxo3n;hZVxSwn9CpLoX^MzRFZv`+T4 zBb^-;l?N%S$iaQCP=@$W9If-^sm3FgLsmI8&}e_pzI_w_ll$PY{6A|Kv-Q9V%=n|! zacTD4SBFjKm`J}=be`dP_r8YD^fOf%jrGrPqF{BFtRKC9d0mr)B67sq*qRzg8x6rk5DJm?` z(Iiz0Oos8lVWztx81XKS<0uKxdxsU>Lsp)e*qZZ z3%D;jGk-qu30UUDv?9BEY zE&MPkAgt(nvzowdXqj`1&YMz>6zM^Lyas@v_u2Y?njrvgd>FW1&-k?bF9sH@18U|4 zD$g94kl)XT`YyohtWKW&7rLCVGn)K0_P5|qv#Vw7s18DwR5rPTf$S*1)qj|U=&J<{ z1XPXj%ygJ$ULRsPw&n2+$Wn4b*)c53GSZNngUs8}WK#Jkx+(eFI9qbC6=qyHbtFJA z)cBwF5Hqw(X0h}?P+dODtEcZRx^QBxVTvRBE!R9+kzakuLTNB8LsnOsyQqeq$#2tB z+;UbEfSy3oILlCCT8fzdd*zAv-cw)k_Dao^hlF3O1FbVWJCPv{Omk|7XKT(#%Np?d5O7rVue^IZ@qgv zodpUkp9&stsDP97)?8?5!wquZiZIDoGjGvM7 z`J)u}GL)|2lnN8!PVn!rsCqD{m(@-mgFqU#a{JsWn#V0$M@8o)9ciPS8z7(qbIBb@&ZT2D3sCw>b#s;*s1pc++Cm6*E$UMA$Oi@=JE z>p9qEq3I+GW&Qym*JZ7PMkl!bZjz#r^=lbjCN2MjNPRcPYRs%ngf$;&Z;m5;+** zWL>sX-sFAtb+-G}mef_XYO2p%WuB5H6)`CW)8%AkAGhr3#Jn zV5deJycY}qTJV(ZfpxlUS!@58D47%sQJUc$c=j>WZi}-sI@X@C{?Bu)NfxK-23get z_h_i@%L>uvx4|ZG8QKo@2R&1w!yr*4bhcrli(NMp^44|6KOFq$p;uG}&B+_@#7+U+ zs|B=qJu^ORJ9n;T`21lQ8a{o0n%fOLBs2XfdMh;kD-&`k<;RjV1VSlr{=EP<8N=OD zYxA1PS;r;o9%AuD$*<76-B(OVT)}f~-zz5?Mv`}DG-+(&-TOc2^Vu3&weIds1>A^deS$i(017%E>%Icn!$-twcy%* z2brMOSc(FS&G-+M&#W=_W}9v*`c;X**-XsFYum>^8r3=7+4p_5HYZHkHS~W;mwpRT zedNfCXB?8OFo8E2)#yxRK-lO`61?3shp*X2dAPRuQ^%veROc0~*)p$ZX|-&c*twu$ zYKAZ4yoXwJhGYL=t*`m8>OFSC@nBUf8)Wk@Zm-6;c!kpJ=puT;x1eq?iCC<{bfMjH zH_K23k!n3_^j;_uhV8X6zEHkCx`*-IF-crg<BHh4-6XChA4_T)8htegX;V%%^qByYPg=o&S&XD>bb24dl@4hnUw!zm+~gTcOTo zKi+k`g|Wd;1o4nV+2+|fsiM7&yy-gCBa|$v-ws{4wnIX6ukA?M8$LLc^|%&LxP2*= z40O74p0SiMVbW1I1RjcUdWF;3qGdRF!lJRsEvqX}O>kqNj^pEKH+1zMEQks z?gd&@vVzf`#%kV*z7?)k9Y13=gR)>k`Qyqs=hb6~iKGK0+Kz6);`x2vSI^8oa{Su3 zUBH>Kbfp}AEQFW9F~yGZzkZ9YHnZ`S<8-@&?QH>4AFIdXDzA+ep?9myi9|zAI>67(-!*@+uCMno?Ll z-E8|^`N7+UrHT$u2EH(17Z#+4hWZ&uvB_R4yDV$x4qj!q@c%W@SAFasl|TDamNU?lvdf@TKcBr2#I*Tz{dQTyk5Pm1XaD~<;vf03=Bt7~erxXA zd^u@J47~pjX+KUP`zBOuEuWGvj;jT64Qxg-_0+ua|<>}967^p;6m#H*$;wWq7qL&OZxr6Drf#PyLD{GmEPRAK2=>XbF18%g>`fO z@O};`l>Z?5AR{4bQLe(rWl6tZXdn3d#6GXB>-fgxSlRs@ClrJmzfVq=x|^45Y9@4B zy`lLcM~kKJp>GG(H`E4gkN?@6tXP)wItZwe<5-e^+I_EoZPm#egG-D`EVrFqmR#gJoM!b}wLbZt@0Y~wJm=W`n7_G(b2|AP z+IBbd#z?`-yFzOw(`iD5x z;(FMD>W1%$`!#MqVg)+DO5ilx(V_=O8zT%ql$(~-?-I^t-zy@vbLpSyfvpFe zD=!PK1kMI1Nt^TCV3)3Vk?=sFWcPx+dCYa4e|PO?+`%gS+QFr5A(KPOmt&0eO`^=~ zOuw0Lr=10!x5He=`-kiGm-h~``%bJ_!65K)qiz_-oBmkc8`874J3O-O_FYuMeeLCc zDQyN9l_sDIN}g@VE8D%d;clbsg-Y`|br1Lt*dCa>X0~nM_xG+s0nRExYkfCH@|4T} zu;#CRoS=Sc_A`qsMLEX~vp2Nf$f^3y^QYD@IZkQqA|{6=cH541HNK5BpB(r6{k9uV ztV`|FflW!^5f0~k+UD-(PoDelQO?cI6W*`x&FDB`H9J9BGVkcFm*wWqpBjJhWnZ@G zVNRXxo|&+SjVd#0f|o%78Z1&a!^gU>f!f6aE@W=BiuWnufq-X+&(rUnd&gMomK e-1Y50v;MJJ>`SvA-vpkn#Ng@b=d#Wzp$PzDXPGPj literal 0 HcmV?d00001 diff --git a/examples/DemoRunner/Source/Main.cpp b/examples/DemoRunner/Source/Main.cpp index 4d8a120e2b..60d71990a1 100644 --- a/examples/DemoRunner/Source/Main.cpp +++ b/examples/DemoRunner/Source/Main.cpp @@ -37,7 +37,8 @@ { DemoTaskbarComponent() { - setIconImage (getImageFromAssets ("juce_icon.png")); + setIconImage (getImageFromAssets ("juce_icon.png"), + getImageFromAssets ("juce_icon_template.png")); setIconTooltip ("JUCE demo runner!"); } diff --git a/modules/juce_gui_basics/native/juce_mac_MainMenu.mm b/modules/juce_gui_basics/native/juce_mac_MainMenu.mm index 34e1a05d8a..976645a7e7 100644 --- a/modules/juce_gui_basics/native/juce_mac_MainMenu.mm +++ b/modules/juce_gui_basics/native/juce_mac_MainMenu.mm @@ -283,7 +283,11 @@ public: [item setTag: topLevelIndex]; [item setEnabled: i.isEnabled]; + #if defined (MAC_OS_X_VERSION_10_13) && MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_13 + [item setState: i.isTicked ? NSControlStateValueOn : NSControlStateValueOff]; + #else [item setState: i.isTicked ? NSOnState : NSOffState]; + #endif [item setTarget: (id) callback]; auto* juceItem = new PopupMenu::Item (i); diff --git a/modules/juce_gui_extra/misc/juce_SystemTrayIconComponent.h b/modules/juce_gui_extra/misc/juce_SystemTrayIconComponent.h index 3f84c58789..c905c6f18a 100644 --- a/modules/juce_gui_extra/misc/juce_SystemTrayIconComponent.h +++ b/modules/juce_gui_extra/misc/juce_SystemTrayIconComponent.h @@ -56,14 +56,23 @@ class JUCE_API SystemTrayIconComponent : public Component { public: //============================================================================== + /** Constructor. */ SystemTrayIconComponent(); /** Destructor. */ ~SystemTrayIconComponent() override; //============================================================================== - /** Changes the image shown in the taskbar. */ - void setIconImage (const Image& newImage); + /** Changes the image shown in the taskbar. + + On Windows and Linux a full colour Image is used as an icon. + On macOS a template image is used, where all non-transparent regions will be + rendered in a monochrome colour selected dynamically by the operating system. + + @param colourImage An colour image to use as an icon on Windows and Linux + @param templateImage A template image to use as an icon on macOS + */ + void setIconImage (const Image& colourImage, const Image& templateImage); /** Changes the icon's tooltip (if the current OS supports this). */ void setIconTooltip (const String& tooltip); @@ -98,6 +107,10 @@ private: JUCE_PUBLIC_IN_DLL_BUILD (class Pimpl) std::unique_ptr pimpl; + // The new setIconImage function signature requires different images for macOS + // and the other platforms + JUCE_DEPRECATED (void setIconImage (const Image& newImage)); + JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (SystemTrayIconComponent) }; diff --git a/modules/juce_gui_extra/native/juce_linux_X11_SystemTrayIcon.cpp b/modules/juce_gui_extra/native/juce_linux_X11_SystemTrayIcon.cpp index bab3c8a901..e9c6145ffa 100644 --- a/modules/juce_gui_extra/native/juce_linux_X11_SystemTrayIcon.cpp +++ b/modules/juce_gui_extra/native/juce_linux_X11_SystemTrayIcon.cpp @@ -96,16 +96,16 @@ private: //============================================================================== -void SystemTrayIconComponent::setIconImage (const Image& newImage) +void SystemTrayIconComponent::setIconImage (const Image& colourImage, const Image&) { pimpl.reset(); - if (newImage.isValid()) + if (colourImage.isValid()) { if (! isOnDesktop()) addToDesktop (0); - pimpl.reset (new Pimpl (newImage, (Window) getWindowHandle())); + pimpl.reset (new Pimpl (colourImage, (Window) getWindowHandle())); setVisible (true); toFront (false); diff --git a/modules/juce_gui_extra/native/juce_mac_SystemTrayIcon.cpp b/modules/juce_gui_extra/native/juce_mac_SystemTrayIcon.cpp index 19c9f6b7d3..886967f7a9 100644 --- a/modules/juce_gui_extra/native/juce_mac_SystemTrayIcon.cpp +++ b/modules/juce_gui_extra/native/juce_mac_SystemTrayIcon.cpp @@ -33,59 +33,79 @@ extern NSMenu* createNSMenu (const PopupMenu&, const String& name, int topLevelM class SystemTrayIconComponent::Pimpl : private Timer { public: + //============================================================================== Pimpl (SystemTrayIconComponent& iconComp, const Image& im) : owner (iconComp), statusIcon (imageToNSImage (im)) { - static SystemTrayViewClass cls; - view = [cls.createInstance() init]; - SystemTrayViewClass::setOwner (view, this); - SystemTrayViewClass::setImage (view, statusIcon); - - setIconSize(); - - statusItem = [[[NSStatusBar systemStatusBar] statusItemWithLength: NSSquareStatusItemLength] retain]; - [statusItem setView: view]; - - SystemTrayViewClass::frameChanged (view, SEL(), nullptr); + static ButtonEventForwarderClass cls; + eventForwarder.reset ([cls.createInstance() init]); + ButtonEventForwarderClass::setOwner (eventForwarder.get(), this); + + configureIcon(); + + statusItem.reset ([[[NSStatusBar systemStatusBar] statusItemWithLength: NSSquareStatusItemLength] retain]); + auto button = [statusItem.get() button]; + button.image = statusIcon.get(); + button.target = eventForwarder.get(); + button.action = @selector (handleEvent:); + #if defined (MAC_OS_X_VERSION_10_12) && MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_12 + [button sendActionOn: NSEventMaskLeftMouseDown | NSEventMaskRightMouseDown | NSEventMaskScrollWheel]; + #else + [button sendActionOn: NSLeftMouseDownMask | NSRightMouseDownMask | NSScrollWheelMask]; + #endif + } - [[NSNotificationCenter defaultCenter] addObserver: view - selector: @selector (frameChanged:) - name: NSWindowDidMoveNotification - object: nil]; + //============================================================================== + void updateIcon (const Image& newImage) + { + statusIcon.reset (imageToNSImage (newImage)); + configureIcon(); + [statusItem.get() button].image = statusIcon.get(); } - ~Pimpl() override + void setHighlighted (bool shouldHighlight) { - [[NSNotificationCenter defaultCenter] removeObserver: view]; - [[NSStatusBar systemStatusBar] removeStatusItem: statusItem]; - SystemTrayViewClass::setOwner (view, nullptr); - SystemTrayViewClass::setImage (view, nil); - [statusItem release]; - [view release]; - [statusIcon release]; + [[statusItem.get() button] setHighlighted: shouldHighlight]; } - void updateIcon (const Image& newImage) + void showMenu (const PopupMenu& menu) { - [statusIcon release]; - statusIcon = imageToNSImage (newImage); - setIconSize(); - SystemTrayViewClass::setImage (view, statusIcon); - [statusItem setView: view]; + if (NSMenu* m = createNSMenu (menu, "MenuBarItem", -2, -3, true)) + { + setHighlighted (true); + stopTimer(); + + // There's currently no good alternative to this... + #if defined __clang__ && defined (MAC_OS_X_VERSION_10_14) && MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_14 + #define IGNORE_POPUP_DEPRECATION 1 + #pragma clang diagnostic push + #pragma clang diagnostic ignored "-Wdeprecated-declarations" + #endif + + [statusItem.get() popUpStatusItemMenu: m]; + + #if IGNORE_POPUP_DEPRECATION + #pragma clang diagnostic pop + #endif + + startTimer (1); + } } - void setHighlighted (bool shouldHighlight) + //============================================================================== + NSStatusItem* getStatusItem() { - isHighlighted = shouldHighlight; - [view setNeedsDisplay: true]; + return statusItem.get(); } - void handleStatusItemAction (NSEvent* e) + //============================================================================== + void handleEvent() { + auto e = [NSApp currentEvent]; NSEventType type = [e type]; - const bool isLeft = (type == NSEventTypeLeftMouseDown || type == NSEventTypeLeftMouseUp); - const bool isRight = (type == NSEventTypeRightMouseDown || type == NSEventTypeRightMouseUp); + const bool isLeft = (type == NSEventTypeLeftMouseDown); + const bool isRight = (type == NSEventTypeRightMouseDown); if (owner.isCurrentlyBlockedByAnotherModalComponent()) { @@ -104,22 +124,22 @@ public: auto mouseSource = Desktop::getInstance().getMainMouseSource(); auto pressure = (float) e.pressure; - if (isLeft || isRight) // Only mouse up is sent by the OS, so simulate a down/up + if (isLeft || isRight) { - setHighlighted (true); - startTimer (150); - - owner.mouseDown (MouseEvent (mouseSource, {}, - eventMods.withFlags (isLeft ? ModifierKeys::leftButtonModifier - : ModifierKeys::rightButtonModifier), - pressure, MouseInputSource::invalidOrientation, MouseInputSource::invalidRotation, - MouseInputSource::invalidTiltX, MouseInputSource::invalidTiltY, - &owner, &owner, now, {}, now, 1, false)); - - owner.mouseUp (MouseEvent (mouseSource, {}, eventMods.withoutMouseButtons(), pressure, - MouseInputSource::invalidOrientation, MouseInputSource::invalidRotation, - MouseInputSource::invalidTiltX, MouseInputSource::invalidTiltY, - &owner, &owner, now, {}, now, 1, false)); + owner.mouseDown ({ mouseSource, {}, + eventMods.withFlags (isLeft ? ModifierKeys::leftButtonModifier + : ModifierKeys::rightButtonModifier), + pressure, + MouseInputSource::invalidOrientation, MouseInputSource::invalidRotation, + MouseInputSource::invalidTiltX, MouseInputSource::invalidTiltY, + &owner, &owner, now, {}, now, 1, false }); + + owner.mouseUp ({ mouseSource, {}, + eventMods.withoutMouseButtons(), + pressure, + MouseInputSource::invalidOrientation, MouseInputSource::invalidRotation, + MouseInputSource::invalidTiltX, MouseInputSource::invalidTiltY, + &owner, &owner, now, {}, now, 1, false }); } else if (type == NSEventTypeMouseMoved) { @@ -131,28 +151,12 @@ public: } } - void showMenu (const PopupMenu& menu) - { - if (NSMenu* m = createNSMenu (menu, "MenuBarItem", -2, -3, true)) - { - setHighlighted (true); - stopTimer(); - [statusItem popUpStatusItemMenu: m]; - startTimer (1); - } - } - - SystemTrayIconComponent& owner; - NSStatusItem* statusItem = nil; - private: - NSImage* statusIcon = nil; - NSControl* view = nil; - bool isHighlighted = false; - - void setIconSize() + //============================================================================== + void configureIcon() { - [statusIcon setSize: NSMakeSize (20.0f, 20.0f)]; + [statusIcon.get() setSize: NSMakeSize (20.0f, 20.0f)]; + [statusIcon.get() setTemplate: true]; } void timerCallback() override @@ -161,79 +165,49 @@ private: setHighlighted (false); } - struct SystemTrayViewClass : public ObjCClass + //============================================================================== + class ButtonEventForwarderClass : public ObjCClass { - SystemTrayViewClass() : ObjCClass ("JUCESystemTrayView_") + public: + ButtonEventForwarderClass() : ObjCClass ("JUCEButtonEventForwarderClass_") { addIvar ("owner"); - addIvar ("image"); - addMethod (@selector (mouseDown:), handleEventDown, "v@:@"); - addMethod (@selector (rightMouseDown:), handleEventDown, "v@:@"); - addMethod (@selector (drawRect:), drawRect, "v@:@"); - addMethod (@selector (frameChanged:), frameChanged, "v@:@"); + addMethod (@selector (handleEvent:), handleEvent, "v@:@"); registerClass(); } static Pimpl* getOwner (id self) { return getIvar (self, "owner"); } - static NSImage* getImage (id self) { return getIvar (self, "image"); } static void setOwner (id self, Pimpl* owner) { object_setInstanceVariable (self, "owner", owner); } - static void setImage (id self, NSImage* image) { object_setInstanceVariable (self, "image", image); } - - static void frameChanged (id self, SEL, NSNotification*) - { - if (auto* owner = getOwner (self)) - { - NSRect r = [[[owner->statusItem view] window] frame]; - NSRect sr = [[[NSScreen screens] objectAtIndex: 0] frame]; - r.origin.y = sr.size.height - r.origin.y - r.size.height; - owner->owner.setBounds (convertToRectInt (r)); - } - } private: - static void handleEventDown (id self, SEL, NSEvent* e) + static void handleEvent (id self, SEL, id) { if (auto* owner = getOwner (self)) - owner->handleStatusItemAction (e); - } - - static void drawRect (id self, SEL, NSRect) - { - NSRect bounds = [self bounds]; - - if (auto* owner = getOwner (self)) - [owner->statusItem drawStatusBarBackgroundInRect: bounds - withHighlight: owner->isHighlighted]; - - if (NSImage* const im = getImage (self)) - { - NSSize imageSize = [im size]; - - [im drawInRect: NSMakeRect (bounds.origin.x + ((bounds.size.width - imageSize.width) / 2.0f), - bounds.origin.y + ((bounds.size.height - imageSize.height) / 2.0f), - imageSize.width, imageSize.height) - fromRect: NSZeroRect - operation: NSCompositingOperationSourceOver - fraction: 1.0f]; - } + owner->handleEvent(); } }; + //============================================================================== + SystemTrayIconComponent& owner; + std::unique_ptr statusItem; + std::unique_ptr eventForwarder; + std::unique_ptr statusIcon; + JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (Pimpl) }; //============================================================================== -void SystemTrayIconComponent::setIconImage (const Image& newImage) +void SystemTrayIconComponent::setIconImage (const Image&, const Image& templateImage) { - if (newImage.isValid()) + if (templateImage.isValid()) { if (pimpl == nullptr) - pimpl.reset (new Pimpl (*this, newImage)); + pimpl.reset (new Pimpl (*this, templateImage)); else - pimpl->updateIcon (newImage); + pimpl->updateIcon (templateImage); } else { @@ -264,7 +238,7 @@ void SystemTrayIconComponent::hideInfoBubble() void* SystemTrayIconComponent::getNativeHandle() const { - return pimpl != nullptr ? pimpl->statusItem : nullptr; + return pimpl != nullptr ? pimpl->getStatusItem() : nullptr; } void SystemTrayIconComponent::showDropdownMenu (const PopupMenu& menu) diff --git a/modules/juce_gui_extra/native/juce_win32_SystemTrayIcon.cpp b/modules/juce_gui_extra/native/juce_win32_SystemTrayIcon.cpp index 66b540a400..061bc1decd 100644 --- a/modules/juce_gui_extra/native/juce_win32_SystemTrayIcon.cpp +++ b/modules/juce_gui_extra/native/juce_win32_SystemTrayIcon.cpp @@ -196,11 +196,11 @@ private: }; //============================================================================== -void SystemTrayIconComponent::setIconImage (const Image& newImage) +void SystemTrayIconComponent::setIconImage (const Image& colourImage, const Image&) { - if (newImage.isValid()) + if (colourImage.isValid()) { - HICON hicon = IconConverters::createHICONFromImage (newImage, TRUE, 0, 0); + HICON hicon = IconConverters::createHICONFromImage (colourImage, TRUE, 0, 0); if (pimpl == nullptr) pimpl.reset (new Pimpl (*this, hicon, (HWND) getWindowHandle()));