From 5b0b97473cae44812ce9c85d9b32c060b5398529 Mon Sep 17 00:00:00 2001 From: hogliux Date: Thu, 29 Mar 2018 10:45:09 +0100 Subject: [PATCH] macOS: Fixed a bug which would prevent a SystemTrayIconComponent from creating a native popup window --- modules/juce_gui_basics/native/juce_mac_MainMenu.mm | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/modules/juce_gui_basics/native/juce_mac_MainMenu.mm b/modules/juce_gui_basics/native/juce_mac_MainMenu.mm index b4b5f6a260..662e55e1a8 100644 --- a/modules/juce_gui_basics/native/juce_mac_MainMenu.mm +++ b/modules/juce_gui_basics/native/juce_mac_MainMenu.mm @@ -143,14 +143,17 @@ public: auto menuNames = currentModel->getMenuBarNames(); auto indexOfMenu = (int) [superMenu indexOfItemWithSubmenu: menu] - 1; - removeItemRecursive (menu); + if (indexOfMenu >= 0) + { + removeItemRecursive (menu); - auto updatedPopup = currentModel->getMenuForIndex (indexOfMenu, menuNames[indexOfMenu]); + auto updatedPopup = currentModel->getMenuForIndex (indexOfMenu, menuNames[indexOfMenu]); - for (PopupMenu::MenuItemIterator iter (updatedPopup); iter.next();) - addMenuItem (iter, menu, 1, indexOfMenu); + for (PopupMenu::MenuItemIterator iter (updatedPopup); iter.next();) + addMenuItem (iter, menu, 1, indexOfMenu); - [menu update]; + [menu update]; + } } void menuBarItemsChanged (MenuBarModel*) override