From 780967a3c8865913e510d970e3922172de8b0075 Mon Sep 17 00:00:00 2001 From: falkTX Date: Tue, 19 Mar 2019 22:01:31 +0100 Subject: [PATCH 1/2] Add -mstackrealign build flag to windows Signed-off-by: falkTX --- Makefile.base.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.base.mk b/Makefile.base.mk index 5e10d7da..90c22da9 100644 --- a/Makefile.base.mk +++ b/Makefile.base.mk @@ -112,6 +112,8 @@ ifeq ($(WIN32),true) # mingw has issues with this specific optimization # See https://github.com/falkTX/Carla/issues/696 BASE_OPTS += -fno-rerun-cse-after-loop +# See https://github.com/falkTX/Carla/issues/855 +BASE_OPTS += -mstackrealign ifeq ($(BUILDING_FOR_WINDOWS),true) BASE_FLAGS += -DBUILDING_CARLA_FOR_WINDOWS endif From c3bf5ecada36bd49f599f20aba63182522ea04cf Mon Sep 17 00:00:00 2001 From: Patrick Desaulniers Date: Sat, 6 Apr 2019 10:30:12 -0400 Subject: [PATCH 2/2] Document DISTRHO_PLUGIN_WANT_FULL_STATE (#135) * Document DISTRHO_PLUGIN_WANT_FULL_STATE * Tweak DISTRHO_PLUGIN_WANT_FULL_STATE summary --- distrho/DistrhoInfo.hpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/distrho/DistrhoInfo.hpp b/distrho/DistrhoInfo.hpp index b38976f1..355eeca9 100644 --- a/distrho/DistrhoInfo.hpp +++ b/distrho/DistrhoInfo.hpp @@ -543,6 +543,16 @@ START_NAMESPACE_DISTRHO */ #define DISTRHO_PLUGIN_WANT_STATE 1 +/** + Wherever the plugin implements the full state API. + When this macro is enabled, the plugin must implement a new getState(const char* key) function, which the host calls when saving its session/project. + This is useful for plugins that have custom internal values not exposed to the host as key-value state pairs or parameters. + Most simple effects and synths will not need this. + @note this macro is automatically enabled if a plugin has programs and state, as the key-value state pairs need to be updated when the current program changes. + @see Plugin::getState(const char*) + */ +#define DISTRHO_PLUGIN_WANT_FULL_STATE 1 + /** Wherever the plugin wants time position information from the host. @see Plugin::getTimePosition()