From fdaf1ec204e7dfd80340b8d8c5cfacbd9bf65e8d Mon Sep 17 00:00:00 2001 From: falkTX Date: Mon, 25 Apr 2022 23:50:36 +0100 Subject: [PATCH] Update Fundamental, mention it in README and LICENSES Signed-off-by: falkTX --- .github/workflows/build.yml | 2 +- README.md | 1 + docs/FAQ.md | 13 ------------- docs/LICENSES.md | 2 ++ plugins/Fundamental | 2 +- 5 files changed, 5 insertions(+), 15 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3522c5e..bcae802 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -448,7 +448,7 @@ jobs: run: | pushd deps/PawPaw; source local.env macos-universal; popd git clone --depth=1 -b master https://github.com/juce-framework/JUCE.git jucewrapper/JUCE - mkdir jucewrapper/build + mkdir -p jucewrapper/build pushd jucewrapper/build; cmake -DCMAKE_OSX_ARCHITECTURES='arm64;x86_64' -DCMAKE_OSX_DEPLOYMENT_TARGET=10.12 -DCMAKE_BUILD_TYPE=Release .. && make -j $(sysctl -n hw.logicalcpu); popd mv jucewrapper/build/*_artefacts/Release/AU/*.component bin/ - name: Build macOS universal (packaging) diff --git a/README.md b/README.md index 66df12a..dcee0fb 100644 --- a/README.md +++ b/README.md @@ -130,6 +130,7 @@ At the moment the following 3rd-party modules are provided: - ExpertSleepers Encoders - Extratone - Fehler Fabrik +- Fundamental - Glue the Giant - GoodSheperd - Grande diff --git a/docs/FAQ.md b/docs/FAQ.md index 5619603..abdceff 100644 --- a/docs/FAQ.md +++ b/docs/FAQ.md @@ -9,19 +9,6 @@ But basically we want an open-source plugin version of "Rack Pro", where we are free to change things as we see fit, work on new features and fix bugs. This is simply not possible with proprietary software, which is the case of "Rack Pro". -## Where is Fundamental? - -There are some artwork license issues that prevent us from using Fundamental exactly as we want. -We could in theory use it as-is, VCV logo and everything, but it looks out of place with Cardinal's general dark mode theme. -The artwork license does not allow modifications, and that VCV logo being present on the panels makes Cardinal's authors unease. -Cardinal is not a VCV product in any way, or endorsed by it. Would be quite bad to give that impression. - -Current plan is to redo Fundamental panel graphics in a more liberal license, so it then can be included in Cardinal. -In the mean time, check [this wiki page](https://github.com/DISTRHO/Cardinal/wiki/Fundamental-replacements) -for a list of module replacements for Fundamental stuff. - -PS: Don't forget to contribute back as well! ;) - ## Can I install extra modules? No, Cardinal is intentionally a fully self-contained plugin. diff --git a/docs/LICENSES.md b/docs/LICENSES.md index 39b2ca4..c8ccce1 100644 --- a/docs/LICENSES.md +++ b/docs/LICENSES.md @@ -36,6 +36,7 @@ Bellow follows a list of all code licenses used in Cardinal and linked submodule | ExpertSleepers Encoders | MIT | | | Extratone | GPL-3.0-or-later | | | Fehler Fabrik | GPL-3.0-or-later | | +| Fundamental | GPL-3.0-or-later | | | Glue the Giant | GPL-3.0-or-later | | | GoodSheperd | GPL-3.0-or-later | | | Grande | GPL-3.0-or-later | | @@ -136,6 +137,7 @@ Below is a list of artwork licenses from plugins | ExpertSleepers-Encoders/* | MIT | [Same license as source code](https://github.com/expertsleepersltd/vcvrack-encoders/issues/3) | | Extratone/* | GPL-3.0-or-later | [Same license as source code](https://github.com/EaterOfSheep/Extratone/issues/7) | | FehlerFabrik/* | GPL-3.0-or-later | No artwork specific license provided, see [FehlerFabrik#17](https://github.com/RCameron93/FehlerFabrik/issues/17) | +| Fundamental/* | GPL-3.0-or-later | Same license as source code | | GlueTheGiant/* | GPL-3.0-or-later | Same license as source code | | GlueTheGiant/fonts/DSEG7-* | OFL-1.1-RFN | | | GoodSheperd/* | GPL-3.0-or-later | No artwork specific license provided | diff --git a/plugins/Fundamental b/plugins/Fundamental index 37ced22..7903f41 160000 --- a/plugins/Fundamental +++ b/plugins/Fundamental @@ -1 +1 @@ -Subproject commit 37ced22bdbd928234dd89182fc8061ca6b48f535 +Subproject commit 7903f41e0d78614933395b8534bf20aa201f8f90