From fcbed2797c40ecbe209d96d3f443d504449e6c13 Mon Sep 17 00:00:00 2001
From: falkTX <falktx@falktx.com>
Date: Sat, 25 Feb 2023 16:36:58 +0100
Subject: [PATCH] Do not reset pitch when receiving all-notes-off Closes #464
 Signed-off-by: falkTX <falktx@falktx.com>

---
 plugins/Cardinal/src/HostMIDI.cpp | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/plugins/Cardinal/src/HostMIDI.cpp b/plugins/Cardinal/src/HostMIDI.cpp
index 7469a8e..6d13ea3 100644
--- a/plugins/Cardinal/src/HostMIDI.cpp
+++ b/plugins/Cardinal/src/HostMIDI.cpp
@@ -148,22 +148,27 @@ struct HostMIDI : TerminalModule {
             channels = 1;
             polyMode = ROTATE_MODE;
             pwRange = 0;
-            panic();
+            panic(true);
         }
 
         /** Resets performance state */
-        void panic()
+        void panic(const bool resetPitch)
         {
             for (int c = 0; c < 16; c++) {
                 notes[c] = 60;
                 gates[c] = false;
                 velocities[c] = 0;
                 aftertouches[c] = 0;
-                pws[c] = 8192;
-                mods[c] = 0;
                 pwFilters[c].reset();
                 modFilters[c].reset();
             }
+            if (resetPitch) {
+                for (int c = 0; c < 16; c++) {
+                    notes[c] = 60;
+                    pws[c] = 8192;
+                    mods[c] = 0;
+                }
+            }
             pedal = false;
             rotateIndex = -1;
             heldNotes.clear();
@@ -374,7 +379,7 @@ struct HostMIDI : TerminalModule {
                 // all notes off (panic)
                 case 0x7b: {
                     if (msg.getValue() == 0) {
-                        panic();
+                        panic(false);
                     }
                 } break;
                 default: break;
@@ -529,7 +534,7 @@ struct HostMIDI : TerminalModule {
             if (channels == this->channels)
                 return;
             this->channels = channels;
-            panic();
+            panic(true);
         }
 
         void setPolyMode(const PolyMode polyMode)
@@ -537,7 +542,7 @@ struct HostMIDI : TerminalModule {
             if (polyMode == this->polyMode)
                 return;
             this->polyMode = polyMode;
-            panic();
+            panic(true);
         }
     } midiInput;
 
@@ -886,7 +891,7 @@ struct HostMIDIWidget : ModuleWidgetWith9HP {
         menu->addChild(createMenuLabel("MIDI Input & Output"));
 
         menu->addChild(createMenuItem("Panic", "",
-            [=]() { module->midiInput.panic(); module->midiOutput.panic(); }
+            [=]() { module->midiInput.panic(true); module->midiOutput.panic(); }
         ));
     }
 };