From cff3535efa3a112656649d50c70a5a2c27f12eec Mon Sep 17 00:00:00 2001 From: falkTX Date: Mon, 7 Feb 2022 14:57:25 +0000 Subject: [PATCH] Remove befaco Signed-off-by: falkTX --- .gitmodules | 3 --- README.md | 1 - doc/LICENSES.md | 5 +---- plugins/Makefile | 16 ---------------- plugins/plugins.cpp | 45 --------------------------------------------- 5 files changed, 1 insertion(+), 69 deletions(-) diff --git a/.gitmodules b/.gitmodules index 09a2a27..af51fdf 100644 --- a/.gitmodules +++ b/.gitmodules @@ -13,9 +13,6 @@ [submodule "plugins/Fundamental"] path = plugins/Fundamental url = https://github.com/CardinalModules/Fundamental.git -[submodule "plugins/Befaco"] - path = plugins/Befaco - url = https://github.com/VCVRack/Befaco.git [submodule "plugins/AudibleInstruments"] path = plugins/AudibleInstruments url = https://github.com/CardinalModules/AudibleInstruments.git diff --git a/README.md b/README.md index 40e83b4..d509e01 100644 --- a/README.md +++ b/README.md @@ -126,7 +126,6 @@ At the moment the following 3rd-party modules are provided: Potentially coming soon, currently sorting out license situation: - Atelier -- Befaco - Fundamental Additionally Cardinal provides its own modules for DAW/Host automation, time position and internal plugin hosting. diff --git a/doc/LICENSES.md b/doc/LICENSES.md index ce17d77..37e105d 100644 --- a/doc/LICENSES.md +++ b/doc/LICENSES.md @@ -54,8 +54,7 @@ Bellow follows a list of code licenses from potentially coming modules. | Name | License(s) | Pending reason | |-------------------------|-----------------------|----------------| | Atelier | GPL-3.0-or-later | Custom artwork license, needs permission request | -| Befaco | GPL-3.0-or-later | Custom artwork license, needs permission request | -| Fundamental | GPL-3.0-or-later | CC-ND, needs permission for dark mode | +| Fundamental | GPL-3.0-or-later | CC-ND without permission for runtime mode, panels need to be redone | | ZZC | GPL-3.0-or-later | Artwork license terms unclear | ## ARTWORK / PANEL LICENSES @@ -154,8 +153,6 @@ Bellow follows a list of artwork licenses from potentially coming plugins. | Name | License(s) | Additional notes | |-----------------------------------------|------------------|------------------| | Atelier/* | Custom | Copyright © Pyer 2020, used and distributed with permission (TODO ask for it) | -| Befaco/components/* | CC-BY-NC-4.0 | | -| Befaco/panels/* | Custom | Copyright © [Befaco](https://www.befaco.org/), used and distributed with permission (TODO ask for it) | | Fundamental/* | CC-BY-NC-ND-4.0 | | ### Rack diff --git a/plugins/Makefile b/plugins/Makefile index da4a470..0fe0350 100644 --- a/plugins/Makefile +++ b/plugins/Makefile @@ -376,15 +376,6 @@ PLUGIN_FILES += $(filter-out BaconPlugs/src/BaconPlugs.cpp,$(wildcard BaconPlugs PLUGIN_FILES += $(wildcard BaconPlugs/libs/midifile/src/*.cpp) PLUGIN_FILES += $(wildcard BaconPlugs/libs/open303-code/Source/DSPCode/*.cpp) -# -------------------------------------------------------------- -# Befaco - -# PLUGIN_FILES += $(filter-out Befaco/src/plugin.cpp,$(wildcard Befaco/src/*.cpp)) -# PLUGIN_BINARIES += Befaco/src/SpringReverbIR.pcm -# -# # modules/types which are present in other plugins -# BEFACO_CUSTOM = ADSR Mixer - # -------------------------------------------------------------- # Bidoo @@ -1029,13 +1020,6 @@ $(BUILD_DIR)/BaconPlugs/%.cpp.o: BaconPlugs/%.cpp -Wno-array-bounds \ -Wno-strict-aliasing -$(BUILD_DIR)/Befaco/%.cpp.o: Befaco/%.cpp - -@mkdir -p "$(shell dirname $(BUILD_DIR)/$<)" - @echo "Compiling $<" - $(SILENT)$(CXX) $< $(BUILD_CXX_FLAGS) -c -o $@ \ - $(foreach m,$(BEFACO_CUSTOM),$(call custom_module_names,$(m),Befaco)) \ - -DpluginInstance=pluginInstance__Befaco - $(BUILD_DIR)/Bidoo/%.cpp.o: Bidoo/%.cpp -@mkdir -p "$(shell dirname $(BUILD_DIR)/$<)" @echo "Compiling $<" diff --git a/plugins/plugins.cpp b/plugins/plugins.cpp index 6d4c342..fa67116 100644 --- a/plugins/plugins.cpp +++ b/plugins/plugins.cpp @@ -108,15 +108,6 @@ extern Model* modelChord; #undef SCREW_WIDTH #undef RACK_HEIGHT -// Befaco -/* -#define modelADSR modelBefacoADSR -#define modelMixer modelBefacoMixer -#include "Befaco/src/plugin.hpp" -#undef modelADSR -#undef modelMixer -*/ - // Bidoo #include "Bidoo/src/plugin.hpp" @@ -539,7 +530,6 @@ Plugin* pluginInstance__Aria; Plugin* pluginInstance__AudibleInstruments; extern Plugin* pluginInstance__Autinn; Plugin* pluginInstance__Bacon; -// Plugin* pluginInstance__Befaco; Plugin* pluginInstance__Bidoo; Plugin* pluginInstance__BogaudioModules; Plugin* pluginInstance__cf; @@ -915,40 +905,6 @@ static void initStatic__Bacon() } } -/* -static void initStatic__Befaco() -{ - Plugin* const p = new Plugin; - pluginInstance__Befaco = p; - - const StaticPluginLoader spl(p, "Befaco"); - if (spl.ok()) - { -#define modelADSR modelBefacoADSR -#define modelMixer modelBefacoMixer - p->addModel(modelEvenVCO); - p->addModel(modelRampage); - p->addModel(modelABC); - p->addModel(modelSpringReverb); - p->addModel(modelMixer); - p->addModel(modelSlewLimiter); - p->addModel(modelDualAtenuverter); - p->addModel(modelPercall); - p->addModel(modelHexmixVCA); - p->addModel(modelChoppingKinky); - p->addModel(modelKickall); - p->addModel(modelSamplingModulator); - p->addModel(modelMorphader); - p->addModel(modelADSR); - p->addModel(modelSTMix); - p->addModel(modelMuxlicer); - p->addModel(modelMex); -#undef modelADSR -#undef modelMixer - } -} -*/ - static void initStatic__Bidoo() { Plugin* const p = new Plugin; @@ -1905,7 +1861,6 @@ void initStaticPlugins() initStatic__AudibleInstruments(); initStatic__Autinn(); initStatic__Bacon(); - // initStatic__Befaco(); initStatic__Bidoo(); initStatic__BogaudioModules(); initStatic__cf();