Browse Source

Stop using VCV name

Signed-off-by: falkTX <falktx@falktx.com>
tags/22.02
falkTX 3 years ago
parent
commit
994ff05567
6 changed files with 14 additions and 17 deletions
  1. +2
    -1
      README.md
  2. +2
    -2
      doc/DIFFERENCES.md
  3. +6
    -6
      plugins/Core.json
  4. +1
    -1
      plugins/Fundamental
  5. +2
    -6
      src/override/MenuBar.cpp
  6. +1
    -1
      src/override/asset.cpp

+ 2
- 1
README.md View File

@@ -91,6 +91,7 @@ At the moment the following 3rd-party modules are provided:
- Fundamental
- Glue the Giant
- Grande
- HetrickCV
- Impromptu
- JW-Modules
- MindMeld
@@ -132,7 +133,7 @@ While Rack tries to mitigate this as much as possible, crashes due to conflictin
On the other side, Cardinal redefines class and function names as needed to avoid as many conflicts as possible.

Support for ARM and non-mainstream platforms (for example BSD) has also always been missing from the official Rack since the start.
While we can patch the Rack free version to support these, same can't be done with VCV Rack Pro with it being a closed-source product.
While we can patch the Rack free version to support these, same can't be done with Rack Pro with it being a closed-source product.
The online library/store only supports a very specific set of platforms too,
so non-supported platforms would need any 3rd-party modules to be manually compiled to make them usable.



+ 2
- 2
doc/DIFFERENCES.md View File

@@ -1,6 +1,6 @@
# RACK PRO VS CARDINAL DIFFERENCES

This document describes the differences between VCV Rack Pro plugin and Cardinal.
This document describes the differences between Rack Pro plugin and Cardinal.
It is not possible to know all the internal details of the official plugin due to it not being open-source,
so more technical details are best-guesses based on its behaviour.

@@ -12,7 +12,7 @@ Online access is also not allowed.

Bellow follows a list of features comparing the official plugin to Cardinal.

| Feature | VCV Rack Pro | Cardinal | Additional notes |
| Feature | Rack Pro | Cardinal | Additional notes |
|--------------------------------|---------------------------|---------------------------------|------------------|
| Open-Source | No | Yes | |
| Free (of cost) | No | Yes | |


+ 6
- 6
plugins/Core.json View File

@@ -1,16 +1,16 @@
{
"slug": "Core",
"name": "VCV Core",
"version": "2.0.0",
"name": "Cardinal Core",
"version": "2.0.1",
"license": "GPL-3.0-or-later",
"author": "VCV",
"brand": "VCV",
"author": "Vortico",
"brand": "Vortico",
"authorEmail": "support@vcvrack.com",
"authorUrl": "https://vcvrack.com/",
"manualUrl": "https://vcvrack.com/manual/Core",
"sourceUrl": "https://github.com/VCVRack/Rack",
"changelogUrl": "https://github.com/VCVRack/Rack/blob/v2/CHANGELOG.md",
"description": "Necessary modules built into VCV Rack",
"description": "Necessary modules built into Cardinal",
"modules": [
{
"slug": "AudioInterface2",
@@ -130,4 +130,4 @@
]
}
]
}
}

+ 1
- 1
plugins/Fundamental

@@ -1 +1 @@
Subproject commit 08b9a2841f9c84b73c915950afdc695307db8516
Subproject commit a171111f442edf7e4c0357e9863506775b4bc208

+ 2
- 6
src/override/MenuBar.cpp View File

@@ -618,11 +618,7 @@ struct HelpButton : MenuButton {
menu->cornerFlags = BND_CORNER_TOP;
menu->box.pos = getAbsoluteOffset(math::Vec(0, box.size.y));

menu->addChild(createMenuItem("Tips", "", [=]() {
APP->scene->addChild(tipWindowCreate());
}));

menu->addChild(createMenuItem("VCV User manual", "F1", [=]() {
menu->addChild(createMenuItem("Rack User manual", "F1", [=]() {
system::openBrowser("https://vcvrack.com/manual/");
}));

@@ -634,7 +630,7 @@ struct HelpButton : MenuButton {

menu->addChild(createMenuLabel(APP_EDITION + " " + APP_EDITION_NAME));

menu->addChild(createMenuLabel("VCVRack " + APP_VERSION + " Compatible"));
menu->addChild(createMenuLabel("Rack " + APP_VERSION + " Compatible"));
}
};



+ 1
- 1
src/override/asset.cpp View File

@@ -81,7 +81,7 @@ std::string pluginManifest(const std::string& dirname) {
if (bundlePath.empty())
{
if (dirname == "Core")
return system::join(systemDir, "Core.json");
return system::join(systemDir, "..", "..", "plugins", "Core.json");
return system::join(systemDir, "..", "..", "plugins", dirname, "plugin.json");
}
return system::join(bundlePath, dirname + ".json");


Loading…
Cancel
Save