From 4aa6d614b34617c293f7760f4dd2dd5b57ca51c7 Mon Sep 17 00:00:00 2001
From: fixxxedpoint <42604451+fixxxedpoint@users.noreply.github.com>
Date: Wed, 26 Nov 2025 21:07:04 +0100
Subject: [PATCH] review: using array of uint8_t instead of char[] for
 recognizing magic number of an zstd archive

---
 src/CardinalPlugin.cpp | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/CardinalPlugin.cpp b/src/CardinalPlugin.cpp
index a1db4a9..eab38c3 100644
--- a/src/CardinalPlugin.cpp
+++ b/src/CardinalPlugin.cpp
@@ -28,7 +28,6 @@
 #endif
 
 #include <cfloat>
-#include <cstddef>
 #include <list>
 
 #include "CardinalCommon.hpp"
@@ -1105,10 +1104,9 @@ protected:
         rack::system::removeRecursively(fAutosavePath);
         rack::system::createDirectories(fAutosavePath);
 
-        static constexpr const std::size_t zstdMagicSize = 4
-        static constexpr const char zstdMagic[zstdMagicSize + 1] = "\x28\xb5\x2f\xfd";
+        static constexpr const uint8_t zstdMagic[] = { 0x28, 0xb5, 0x2f, 0xfd };
 
-        if (std::memcmp(data.data(), zstdMagic, zstdMagicSize) != 0)
+        if (std::memcmp(data.data(), zstdMagic, sizeof(zstdMagic)) != 0)
         {
             FILE* const f = std::fopen(rack::system::join(fAutosavePath, "patch.json").c_str(), "w");
             DISTRHO_SAFE_ASSERT_RETURN(f != nullptr,);