From 9132ddb9752bc1b0dd70dd668a0f8c4d2d5ac411 Mon Sep 17 00:00:00 2001 From: falkTX Date: Thu, 14 Aug 2025 16:33:31 +0300 Subject: [PATCH 1/6] Fix crash when connecting to OSC remote Signed-off-by: falkTX --- src/override/Scene.cpp | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/src/override/Scene.cpp b/src/override/Scene.cpp index 909b498..5b6e85a 100644 --- a/src/override/Scene.cpp +++ b/src/override/Scene.cpp @@ -1,6 +1,6 @@ /* * DISTRHO Cardinal Plugin - * Copyright (C) 2021-2024 Filipe Coelho + * Copyright (C) 2021-2025 Filipe Coelho * SPDX-License-Identifier: GPL-3.0-or-later */ @@ -207,20 +207,23 @@ void Scene::step() { (internal->historyActionIndex != actionIndex && actionIndex > 0 && time - internal->lastSceneChangeTime >= 1.0)) { - remoteDetails->first = false; - - const std::string& name(APP->history->actions[actionIndex - 1]->name); - static const std::vector ignoredNames = { - "move knob", - "move modules", - "move switch", - }; - if (std::find(ignoredNames.cbegin(), ignoredNames.cend(), name) == ignoredNames.cend()) { - printf("action '%s'\n", APP->history->actions[actionIndex - 1]->name.c_str()); + if (remoteDetails->first) { + remoteDetails->first = false; remoteUtils::sendFullPatchToRemote(remoteDetails); - - if (remoteDetails->screenshot) { - window::generateScreenshot(); + } else { + const std::string& name(APP->history->actions[actionIndex - 1]->name); + static const std::vector ignoredNames = { + "move knob", + "move modules", + "move switch", + }; + if (std::find(ignoredNames.cbegin(), ignoredNames.cend(), name) == ignoredNames.cend()) { + d_debug("action '%s'\n", APP->history->actions[actionIndex - 1]->name.c_str()); + remoteUtils::sendFullPatchToRemote(remoteDetails); + + if (remoteDetails->screenshot) { + window::generateScreenshot(); + } } } internal->historyActionIndex = actionIndex; From e162c4a266e0e9673635d99d46d0d56c4d19b961 Mon Sep 17 00:00:00 2001 From: Cody Geary Date: Sat, 16 Aug 2025 13:37:28 +0200 Subject: [PATCH 2/6] CV funk v2.0.24 (#850) * CV funk v2.0.24 Adding new modules: Tatami - stereo polyphonic wavelder Cartesia - 4x4x4 channel 3D sequencer JunkDNA - A DNA sequence generator and gate sequencer Picus - Burst Generator Node - 2Channel stereo crossfading mixer Weave - Advanced chord generator and permutator Wonk - Chaotic LFO Hammer - Rotating clock modulator Hub - 2X bipolar VCAs for LFO mixing. * Resolve conflict with Node Treated Node the same as Steps in the makefile and plugins.cpp. Hopefully it works to resolve things. * Update plugins.cpp Fixing the fix.. There was an earlier part in plugins.cpp where I also had to temp rename/unrename 'Node'. --- plugins/CVfunk | 2 +- plugins/Makefile | 2 +- plugins/plugins.cpp | 13 +++++++++++++ 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/plugins/CVfunk b/plugins/CVfunk index a116e6b..51f2b4e 160000 --- a/plugins/CVfunk +++ b/plugins/CVfunk @@ -1 +1 @@ -Subproject commit a116e6b18ac05974a23509cc47adfd86e8406385 +Subproject commit 51f2b4e61cde7978fb84cdd892a1d3aaedc0ff5b diff --git a/plugins/Makefile b/plugins/Makefile index e641c00..45c50b3 100644 --- a/plugins/Makefile +++ b/plugins/Makefile @@ -678,7 +678,7 @@ COMPUTERSCARE_CUSTOM = Quantizer PanelBorder PLUGIN_FILES += $(filter-out CVfunk/src/plugin.cpp,$(wildcard CVfunk/src/*.cpp)) # modules/types which are present in other plugins -CVFUNK_CUSTOM = Steps +CVFUNK_CUSTOM = Steps Node # -------------------------------------------------------------- # dBiz diff --git a/plugins/plugins.cpp b/plugins/plugins.cpp index e012e94..edcf204 100644 --- a/plugins/plugins.cpp +++ b/plugins/plugins.cpp @@ -343,9 +343,11 @@ extern Model* modelTestVCF; #include "cf/src/plugin.hpp" // CVfunk +#define modelNode modelCVfunkNode #define modelSteps modelCVfunkSteps #include "CVfunk/src/plugin.hpp" #undef modelSteps +#undef modelNode // ChowDSP #include "ChowDSP/src/plugin.hpp" @@ -2048,6 +2050,7 @@ static void initStatic__CVfunk() if (spl.ok()) { #define modelSteps modelCVfunkSteps + #define modelNode modelCVfunkNode p->addModel(modelSteps); p->addModel(modelEnvelopeArray); p->addModel(modelPentaSequencer); @@ -2069,6 +2072,16 @@ static void initStatic__CVfunk() p->addModel(modelPreeeeeeeeeeessedDuck); p->addModel(modelArrange); p->addModel(modelTriDelay); + p->addModel(modelTatami); + p->addModel(modelCartesia); + p->addModel(modelJunkDNA); + p->addModel(modelPicus); + p->addModel(modelNode); + p->addModel(modelWeave); + p->addModel(modelWonk); + p->addModel(modelHammer); + p->addModel(modelHub); + #undef modelNode #undef modelSteps } } From 2b9e629a7332a38a30a2d0c7a782a549628788f6 Mon Sep 17 00:00:00 2001 From: falkTX Date: Sat, 16 Aug 2025 16:06:51 +0200 Subject: [PATCH 3/6] Update dpf, fix wasm audio input quality Signed-off-by: falkTX --- carla | 2 +- dpf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/carla b/carla index c9b6055..bd96b7c 160000 --- a/carla +++ b/carla @@ -1 +1 @@ -Subproject commit c9b60551497a7a9b76d86d694b6af08afe96335c +Subproject commit bd96b7c403832bfc2f96e55c71711f136e1a4f88 diff --git a/dpf b/dpf index 8c30f9f..79e5339 160000 --- a/dpf +++ b/dpf @@ -1 +1 @@ -Subproject commit 8c30f9f1eddba89805f4131aeb2d6ca3e31a46b1 +Subproject commit 79e5339bef455583a4b5762addfd6578d4230f05 From 595e3a5c9fda3b95a86d9f5b33e8ef476928537b Mon Sep 17 00:00:00 2001 From: falkTX Date: Sat, 16 Aug 2025 17:39:50 +0200 Subject: [PATCH 4/6] Fix wasm build Signed-off-by: falkTX --- carla | 2 +- src/Makefile.cardinal.mk | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/carla b/carla index bd96b7c..31c97d2 160000 --- a/carla +++ b/carla @@ -1 +1 @@ -Subproject commit bd96b7c403832bfc2f96e55c71711f136e1a4f88 +Subproject commit 31c97d211808a20d0b5ade0612bcd09e0f31785d diff --git a/src/Makefile.cardinal.mk b/src/Makefile.cardinal.mk index 576a893..e246242 100644 --- a/src/Makefile.cardinal.mk +++ b/src/Makefile.cardinal.mk @@ -264,6 +264,9 @@ endif ifeq ($(WASM),true) APP_EXT = .js +UI_TYPE = gles2 +else +UI_TYPE = opengl endif USE_VST2_BUNDLE = true From 670471e81e19bbd2a3b46accffb0c2a0ec67f564 Mon Sep 17 00:00:00 2001 From: falkTX Date: Sat, 16 Aug 2025 22:11:24 +0200 Subject: [PATCH 5/6] carla related build fixes Signed-off-by: falkTX --- carla | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/carla b/carla index 31c97d2..034d0c4 160000 --- a/carla +++ b/carla @@ -1 +1 @@ -Subproject commit 31c97d211808a20d0b5ade0612bcd09e0f31785d +Subproject commit 034d0c4242ba834e0b5a8967a5eefedf9d97178c From 39eda2c307a3396fa94a677fff1d83a5a5473efa Mon Sep 17 00:00:00 2001 From: falkTX Date: Sat, 16 Aug 2025 22:43:36 +0200 Subject: [PATCH 6/6] Fix wasm build Signed-off-by: falkTX --- Makefile | 23 ++++++++++++++++------- src/Makefile.cardinal.mk | 2 -- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/Makefile b/Makefile index ce97c4b..be09b5d 100644 --- a/Makefile +++ b/Makefile @@ -1,12 +1,12 @@ #!/usr/bin/make -f # DISTRHO Cardinal Plugin -# Copyright (C) 2021-2024 Filipe Coelho +# Copyright (C) 2021-2025 Filipe Coelho # SPDX-License-Identifier: GPL-3.0-or-later ROOT = . include $(ROOT)/Makefile.base.mk -# ----------------------------------------------------------------------------- +# --------------------------------------------------------------------------------------------------------------------- # Set version # also set in: @@ -17,18 +17,18 @@ include $(ROOT)/Makefile.base.mk # .github/ISSUE_TEMPLATE/bug.yaml src/CardinalCommon.cpp src/CardinalPlugin.cpp utils/macOS/Info_{JACK,Native}.plist VERSION = 25.06 -# -------------------------------------------------------------- +# --------------------------------------------------------------------------------------------------------------------- # Build targets all: cardinal carla deps dgl plugins gen resources -# -------------------------------------------------------------- +# --------------------------------------------------------------------------------------------------------------------- # Build config PREFIX ?= /usr/local DESTDIR ?= -# -------------------------------------------------------------- +# --------------------------------------------------------------------------------------------------------------------- # Carla config CARLA_EXTRA_ARGS = \ @@ -44,7 +44,16 @@ ifneq ($(DEBUG),true) CARLA_EXTRA_ARGS += EXTERNAL_PLUGINS=true endif -# -------------------------------------------------------------- +# --------------------------------------------------------------------------------------------------------------------- +# DGL config + +ifeq ($(WASM),true) +UI_TYPE = gles2 +else +UI_TYPE = opengl +endif + +# --------------------------------------------------------------------------------------------------------------------- # Check for required system-wide dependencies ifeq ($(SYSDEPS),true) @@ -183,7 +192,7 @@ endif dgl: ifneq ($(HEADLESS),true) - $(MAKE) opengl -C dpf/dgl $(DGL_EXTRA_ARGS) + $(MAKE) $(UI_TYPE) -C dpf/dgl $(DGL_EXTRA_ARGS) endif plugins: deps diff --git a/src/Makefile.cardinal.mk b/src/Makefile.cardinal.mk index e246242..2701aa5 100644 --- a/src/Makefile.cardinal.mk +++ b/src/Makefile.cardinal.mk @@ -265,8 +265,6 @@ endif ifeq ($(WASM),true) APP_EXT = .js UI_TYPE = gles2 -else -UI_TYPE = opengl endif USE_VST2_BUNDLE = true