Stop using cardinal-specific settings::darkMode

Signed-off-by: falkTX <falktx@falktx.com>

deps/Makefile

@@ -286,7 +286,7 @@ SURGE_ENV = env \
 SURGE_LIB = $(SURGE_DEP_PATH)/src/common/libsurge-common.a
 
 $(SURGE_LIB): $(SURGE_DEP_PATH)/Makefile
-	$(DEP_MAKE) -C $(SURGE_DEP_PATH) surge-common
+	+$(DEP_MAKE) -C $(SURGE_DEP_PATH) surge-common
 
 $(SURGE_DEP_PATH)/Makefile: $(SURGE_SRC_PATH)/CMakeLists.txt
 	mkdir -p $(SURGE_DEP_PATH)

dpf

@@ -1 +1 @@
-Subproject commit 311bc24f3bfb44c3297a23839cd8dbae3b63e83b
+Subproject commit 564a47745b584c94892a122066d76843af4b4200

include/settings.hpp

@@ -1,18 +1,7 @@
 /*
  * DISTRHO Cardinal Plugin
- * Copyright (C) 2021-2023 Filipe Coelho <falktx@falktx.com>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 3 of
- * the License, or any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * For a full copy of the GNU General Public License see the LICENSE file.
+ * Copyright (C) 2021-2024 Filipe Coelho <falktx@falktx.com>
+ * SPDX-License-Identifier: GPL-3.0-or-later
  */
 
 #pragma once
@@ -24,8 +13,5 @@ namespace settings {
 
 extern int rateLimit;
 
-// TODO remove after updating all plugins
-extern bool darkMode;
-
 } // namespace settings
 } // namespace rack

plugins/AnimatedCircuits

@@ -1 +1 @@
-Subproject commit bf78cd8ed22970fe9dc5ebff8e3907898904c747
+Subproject commit 65f1f203884f13a5eb8cccfae81c751de68d437f

plugins/GlueTheGiant

@@ -1 +1 @@
-Subproject commit 7e20713eacc51179cd7faf0f4428def2b82273a9
+Subproject commit d40d707fc76fbbdada64ce4d4a64b4f2fbd7e865

plugins/Prism

@@ -1 +1 @@
-Subproject commit 8d2796da76e5d7f79bbf461c95a7858035bb0736
+Subproject commit 16a80544d0389db9c1225c4ed1e29e5f47306a01

plugins/RebelTech

@@ -1 +1 @@
-Subproject commit 2d06199dd36ecdfe33d640ed1602f1041930f013
+Subproject commit 6f610187ffb2a9707035a63706effe00335fe7f6

plugins/stoermelder-packone

@@ -1 +1 @@
-Subproject commit ec3c0972440edddfb00d5e5ad189f345c68be471
+Subproject commit 851efdf426b36a77c5099a8286a6e58f46b9d20c

src/CardinalCommon.hpp

@@ -1,18 +1,7 @@
 /*
  * DISTRHO Cardinal Plugin
- * Copyright (C) 2021-2023 Filipe Coelho <falktx@falktx.com>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 3 of
- * the License, or any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * For a full copy of the GNU General Public License see the LICENSE file.
+ * Copyright (C) 2021-2024 Filipe Coelho <falktx@falktx.com>
+ * SPDX-License-Identifier: GPL-3.0-or-later
  */
 
 #pragma once
@@ -87,8 +76,9 @@ void openBrowser(const std::string& url);
 # define CARDINAL_INIT_OSC_THREAD
 #endif
 
-typedef void* lo_server;
-typedef void* lo_server_thread;
+#ifdef HAVE_LIBLO
+# include <lo/lo_types.h>
+#endif
 
 START_NAMESPACE_DISTRHO
 

src/custom/dep.cpp

@@ -19,7 +19,6 @@ namespace settings {
 int rateLimit = 0;
 extern bool preferDarkPanels;
 extern std::string uiTheme;
-bool darkMode; // TODO remove after updating all plugins
 }
 namespace ui {
 void refreshTheme();
@@ -1451,7 +1450,6 @@ namespace rack {
 void switchDarkMode(const bool darkMode)
 {
    #ifndef HEADLESS
-    settings::darkMode = darkMode; // TODO remove after updating all plugins
     settings::preferDarkPanels = darkMode;
     settings::uiTheme = darkMode ? "dark" : "light";
     ui::refreshTheme();